From 7dcac240d44dafaf17a0850fbb27ec5ecd647c75 Mon Sep 17 00:00:00 2001
From: Eduardo Quezada <eduardo602002@gmail.com>
Date: Sun, 4 Sep 2022 21:23:24 -0300
Subject: [PATCH] Review changes

---
 src/battle_controller_link_opponent.c |  4 ----
 src/battle_controllers.c              | 13 +++----------
 src/pokemon_jump.c                    |  2 +-
 3 files changed, 4 insertions(+), 15 deletions(-)

diff --git a/src/battle_controller_link_opponent.c b/src/battle_controller_link_opponent.c
index 0d2c5b213..6e9fb7c61 100644
--- a/src/battle_controller_link_opponent.c
+++ b/src/battle_controller_link_opponent.c
@@ -305,13 +305,9 @@ static void CompleteOnHealthbarDone(void)
     SetHealthboxSpriteVisible(gHealthboxSpriteIds[gActiveBattler]);
 
     if (hpValue != -1)
-    {
         UpdateHpTextInHealthbox(gHealthboxSpriteIds[gActiveBattler], hpValue, HP_CURRENT);
-    }
     else
-    {
         LinkOpponentBufferExecCompleted();
-    }
 }
 
 static void HideHealthboxAfterMonFaint(void)
diff --git a/src/battle_controllers.c b/src/battle_controllers.c
index a641c3c4f..ba56b0db1 100644
--- a/src/battle_controllers.c
+++ b/src/battle_controllers.c
@@ -367,18 +367,12 @@ static void PrepareBufferDataTransfer(u8 bufferId, u8 *data, u16 size)
         switch (bufferId)
         {
         case BUFFER_A:
-            for (i = 0; i < size; i++)
-            {
+            for (i = 0; i < size; data++, i++)
                 gBattleBufferA[gActiveBattler][i] = *data;
-                data++;
-            }
             break;
         case BUFFER_B:
-            for (i = 0; i < size; i++)
-            {
+            for (i = 0; i < size; data++, i++)
                 gBattleBufferB[gActiveBattler][i] = *data;
-                data++;
-            }
             break;
         }
     }
@@ -508,8 +502,7 @@ static void Task_HandleSendLinkBuffersData(u8 taskId)
         }
         break;
     case 5:
-        gTasks[taskId].data[13]--;
-        if (gTasks[taskId].data[13] == 0)
+        if (--gTasks[taskId].data[13] == 0)
         {
             gTasks[taskId].data[13] = 5;
             gTasks[taskId].data[11] = 3;
diff --git a/src/pokemon_jump.c b/src/pokemon_jump.c
index 1c501bac6..4ea4e1d1b 100644
--- a/src/pokemon_jump.c
+++ b/src/pokemon_jump.c
@@ -709,7 +709,7 @@ static void Task_StaticCountdown_Run(u8 taskId)
     u16 packet[RFU_PACKET_SIZE];
     s16 *data = gTasks[taskId].data;
 
-    if (gReceivedRemoteLinkPlayers != 0)
+    if (gReceivedRemoteLinkPlayers)
     {
         // Read link timer
         if (gRecvCmds[0][1] == LINKCMD_COUNTDOWN)