Review changes

This commit is contained in:
Eduardo Quezada
2022-08-01 15:37:00 -04:00
parent 95b16a2391
commit b1bc05ec05
3 changed files with 21 additions and 26 deletions
+3 -8
View File
@@ -356,9 +356,8 @@ void FreeMonMarkingsMenu(void)
u16 i;
for (i = 0; i < 3; i++)
{
FreeSpriteTilesByTag(sMenu->baseTileTag + i);
}
FreeSpritePaletteByTag(sMenu->basePaletteTag);
FreeSpritePaletteByTag(sMenu->basePaletteTag + 1);
for (i = 0; i < ARRAY_COUNT(sMenu->windowSprites); i++)
@@ -385,20 +384,16 @@ bool8 HandleMonMarkingsMenuInput(void)
if (JOY_NEW(DPAD_UP))
{
s8 pos;
PlaySE(SE_SELECT);
pos = --sMenu->cursorPos;
if (pos < 0)
if (--sMenu->cursorPos < 0)
sMenu->cursorPos = SELECTION_CANCEL;
return TRUE;
}
if (JOY_NEW(DPAD_DOWN))
{
s8 pos;
PlaySE(SE_SELECT);
pos = ++sMenu->cursorPos;
if (pos > SELECTION_CANCEL)
if (++sMenu->cursorPos > SELECTION_CANCEL)
sMenu->cursorPos = 0;
return TRUE;
}