From 2894084a39b23854d36c821a1af73738b5613d6a Mon Sep 17 00:00:00 2001 From: PikalaxALT Date: Thu, 11 Oct 2018 11:24:28 -0400 Subject: [PATCH 1/2] Dump trainer class names --- asm/battle_message.s | 4 +- asm/link_rfu_3.s | 4 +- data/data.s | 5 +- data/text/trainer_class_names.inc | 107 ++++++++++++++++++++++++++++++ 4 files changed, 114 insertions(+), 6 deletions(-) create mode 100644 data/text/trainer_class_names.inc diff --git a/asm/battle_message.s b/asm/battle_message.s index 9a9ca1f2f..dcd4b41e4 100644 --- a/asm/battle_message.s +++ b/asm/battle_message.s @@ -1726,12 +1726,12 @@ _080D8084: movs r0, 0xD _080D8094: muls r1, r0 - ldr r0, _080D80A0 @ =gUnknown_823E558 + ldr r0, _080D80A0 @ =gTrainerClassNames adds r4, r1, r0 b _080D8382 .align 2, 0 _080D809C: .4byte gTrainers -_080D80A0: .4byte gUnknown_823E558 +_080D80A0: .4byte gTrainerClassNames _080D80A4: ldr r0, _080D80E8 @ =gTrainerBattleOpponent_A ldrh r2, [r0] diff --git a/asm/link_rfu_3.s b/asm/link_rfu_3.s index f4e12b60f..1cdc807b3 100644 --- a/asm/link_rfu_3.s +++ b/asm/link_rfu_3.s @@ -10960,7 +10960,7 @@ sub_811B31C: @ 811B31C lsrs r0, 16 movs r1, 0xD muls r1, r0 - ldr r0, _0811B4B4 @ =gUnknown_823E558 + ldr r0, _0811B4B4 @ =gTrainerClassNames adds r1, r0 adds r0, r6, 0 bl StringCopy @@ -11109,7 +11109,7 @@ _0811B45E: b _0811B4F0 .align 2, 0 _0811B4B0: .4byte gUnknown_2039624 -_0811B4B4: .4byte gUnknown_823E558 +_0811B4B4: .4byte gTrainerClassNames _0811B4B8: .4byte gUnknown_84594B0 _0811B4BC: .4byte gUnknown_84594C4 _0811B4C0: .4byte gStringVar4 diff --git a/data/data.s b/data/data.s index 7f2b474aa..16dc5b93c 100644 --- a/data/data.s +++ b/data/data.s @@ -115,9 +115,10 @@ gUnknown_8239FD4:: @ 8239FD4 gUnknown_823A004:: @ 823A004 .incbin "baserom.gba", 0x23A004, 0x4554 -gUnknown_823E558:: @ 823E558 - .incbin "baserom.gba", 0x23E558, 0x570 +gTrainerClassNames:: @ 823E558 + .include "data/text/trainer_class_names.inc" + .align 2, 0 gTrainers:: @ 823EAD8 .incbin "baserom.gba", 0x23EAC8, 0x7418 diff --git a/data/text/trainer_class_names.inc b/data/text/trainer_class_names.inc new file mode 100644 index 000000000..29194851d --- /dev/null +++ b/data/text/trainer_class_names.inc @@ -0,0 +1,107 @@ + .string "{PKMN} TRAINER$ " + .string "{PKMN} TRAINER$ " + .string "AQUA LEADER$ " + .string "TEAM AQUA$ " + .string "AROMA LADY$ " + .string "RUIN MANIAC$ " + .string "INTERVIEWER$ " + .string "TUBER$ " + .string "TUBER$ " + .string "COOLTRAINER$ " + .string "HEX MANIAC$ " + .string "LADY$ " + .string "BEAUTY$ " + .string "RICH BOY$ " + .string "POKéMANIAC$ " + .string "SWIMMER♂$ " + .string "BLACK BELT$ " + .string "GUITARIST$ " + .string "KINDLER$ " + .string "CAMPER$ " + .string "BUG MANIAC$ " + .string "PSYCHIC$ " + .string "GENTLEMAN$ " + .string "ELITE FOUR$ " + .string "LEADER$ " + .string "SCHOOL KID$ " + .string "SR. AND JR.$ " + .string "POKéFAN$ " + .string "EXPERT$ " + .string "YOUNGSTER$ " + .string "CHAMPION$ " + .string "FISHERMAN$ " + .string "TRIATHLETE$ " + .string "DRAGON TAMER$" + .string "BIRD KEEPER$ " + .string "NINJA BOY$ " + .string "BATTLE GIRL$ " + .string "PARASOL LADY$" + .string "SWIMMER♀$ " + .string "PICNICKER$ " + .string "TWINS$ " + .string "SAILOR$ " + .string "BOARDER$ " + .string "COLLECTOR$ " + .string "{PKMN} TRAINER$ " + .string "{PKMN} BREEDER$ " + .string "{PKMN} RANGER$ " + .string "MAGMA LEADER$" + .string "TEAM MAGMA$ " + .string "LASS$ " + .string "BUG CATCHER$ " + .string "HIKER$ " + .string "YOUNG COUPLE$" + .string "OLD COUPLE$ " + .string "SIS AND BRO$ " + .string "AQUA ADMIN$ " + .string "MAGMA ADMIN$ " + .string "YOUNGSTER$ " + .string "BUG CATCHER$ " + .string "LASS$ " + .string "SAILOR$ " + .string "CAMPER$ " + .string "PICNICKER$ " + .string "POKéMANIAC$ " + .string "SUPER NERD$ " + .string "HIKER$ " + .string "BIKER$ " + .string "BURGLAR$ " + .string "ENGINEER$ " + .string "FISHERMAN$ " + .string "SWIMMER♂$ " + .string "CUE BALL$ " + .string "GAMER$ " + .string "BEAUTY$ " + .string "SWIMMER♀$ " + .string "PSYCHIC$ " + .string "ROCKER$ " + .string "JUGGLER$ " + .string "TAMER$ " + .string "BIRD KEEPER$ " + .string "BLACK BELT$ " + .string "RIVAL$ " + .string "SCIENTIST$ " + .string "BOSS$ " + .string "LEADER$ " + .string "TEAM ROCKET$ " + .string "COOLTRAINER$ " + .string "ELITE FOUR$ " + .string "GENTLEMAN$ " + .string "RIVAL$ " + .string "CHAMPION$ " + .string "CHANNELER$ " + .string "TWINS$ " + .string "COOL COUPLE$ " + .string "YOUNG COUPLE$" + .string "CRUSH KIN$ " + .string "SIS AND BRO$ " + .string "{PKMN} PROF.$ " + .string "PLAYER$ " + .string "CRUSH GIRL$ " + .string "TUBER$ " + .string "{PKMN} BREEDER$ " + .string "{PKMN} RANGER$ " + .string "AROMA LADY$ " + .string "RUIN MANIAC$ " + .string "LADY$ " + .string "PAINTER$ " From f4e4efedc701fc09c5fed97ddb3dff87b29f575b Mon Sep 17 00:00:00 2001 From: PikalaxALT Date: Thu, 11 Oct 2018 13:11:31 -0400 Subject: [PATCH 2/2] Use proper syntax for null-padded strings --- data/text/trainer_class_names.inc | 214 +++++++++++++++--------------- 1 file changed, 107 insertions(+), 107 deletions(-) diff --git a/data/text/trainer_class_names.inc b/data/text/trainer_class_names.inc index 29194851d..3c4955064 100644 --- a/data/text/trainer_class_names.inc +++ b/data/text/trainer_class_names.inc @@ -1,107 +1,107 @@ - .string "{PKMN} TRAINER$ " - .string "{PKMN} TRAINER$ " - .string "AQUA LEADER$ " - .string "TEAM AQUA$ " - .string "AROMA LADY$ " - .string "RUIN MANIAC$ " - .string "INTERVIEWER$ " - .string "TUBER$ " - .string "TUBER$ " - .string "COOLTRAINER$ " - .string "HEX MANIAC$ " - .string "LADY$ " - .string "BEAUTY$ " - .string "RICH BOY$ " - .string "POKéMANIAC$ " - .string "SWIMMER♂$ " - .string "BLACK BELT$ " - .string "GUITARIST$ " - .string "KINDLER$ " - .string "CAMPER$ " - .string "BUG MANIAC$ " - .string "PSYCHIC$ " - .string "GENTLEMAN$ " - .string "ELITE FOUR$ " - .string "LEADER$ " - .string "SCHOOL KID$ " - .string "SR. AND JR.$ " - .string "POKéFAN$ " - .string "EXPERT$ " - .string "YOUNGSTER$ " - .string "CHAMPION$ " - .string "FISHERMAN$ " - .string "TRIATHLETE$ " - .string "DRAGON TAMER$" - .string "BIRD KEEPER$ " - .string "NINJA BOY$ " - .string "BATTLE GIRL$ " - .string "PARASOL LADY$" - .string "SWIMMER♀$ " - .string "PICNICKER$ " - .string "TWINS$ " - .string "SAILOR$ " - .string "BOARDER$ " - .string "COLLECTOR$ " - .string "{PKMN} TRAINER$ " - .string "{PKMN} BREEDER$ " - .string "{PKMN} RANGER$ " - .string "MAGMA LEADER$" - .string "TEAM MAGMA$ " - .string "LASS$ " - .string "BUG CATCHER$ " - .string "HIKER$ " - .string "YOUNG COUPLE$" - .string "OLD COUPLE$ " - .string "SIS AND BRO$ " - .string "AQUA ADMIN$ " - .string "MAGMA ADMIN$ " - .string "YOUNGSTER$ " - .string "BUG CATCHER$ " - .string "LASS$ " - .string "SAILOR$ " - .string "CAMPER$ " - .string "PICNICKER$ " - .string "POKéMANIAC$ " - .string "SUPER NERD$ " - .string "HIKER$ " - .string "BIKER$ " - .string "BURGLAR$ " - .string "ENGINEER$ " - .string "FISHERMAN$ " - .string "SWIMMER♂$ " - .string "CUE BALL$ " - .string "GAMER$ " - .string "BEAUTY$ " - .string "SWIMMER♀$ " - .string "PSYCHIC$ " - .string "ROCKER$ " - .string "JUGGLER$ " - .string "TAMER$ " - .string "BIRD KEEPER$ " - .string "BLACK BELT$ " - .string "RIVAL$ " - .string "SCIENTIST$ " - .string "BOSS$ " - .string "LEADER$ " - .string "TEAM ROCKET$ " - .string "COOLTRAINER$ " - .string "ELITE FOUR$ " - .string "GENTLEMAN$ " - .string "RIVAL$ " - .string "CHAMPION$ " - .string "CHANNELER$ " - .string "TWINS$ " - .string "COOL COUPLE$ " - .string "YOUNG COUPLE$" - .string "CRUSH KIN$ " - .string "SIS AND BRO$ " - .string "{PKMN} PROF.$ " - .string "PLAYER$ " - .string "CRUSH GIRL$ " - .string "TUBER$ " - .string "{PKMN} BREEDER$ " - .string "{PKMN} RANGER$ " - .string "AROMA LADY$ " - .string "RUIN MANIAC$ " - .string "LADY$ " - .string "PAINTER$ " + .string "{PKMN} TRAINER$", 13 + .string "{PKMN} TRAINER$", 13 + .string "AQUA LEADER$", 13 + .string "TEAM AQUA$", 13 + .string "AROMA LADY$", 13 + .string "RUIN MANIAC$", 13 + .string "INTERVIEWER$", 13 + .string "TUBER$", 13 + .string "TUBER$", 13 + .string "COOLTRAINER$", 13 + .string "HEX MANIAC$", 13 + .string "LADY$", 13 + .string "BEAUTY$", 13 + .string "RICH BOY$", 13 + .string "POKéMANIAC$", 13 + .string "SWIMMER♂$", 13 + .string "BLACK BELT$", 13 + .string "GUITARIST$", 13 + .string "KINDLER$", 13 + .string "CAMPER$", 13 + .string "BUG MANIAC$", 13 + .string "PSYCHIC$", 13 + .string "GENTLEMAN$", 13 + .string "ELITE FOUR$", 13 + .string "LEADER$", 13 + .string "SCHOOL KID$", 13 + .string "SR. AND JR.$", 13 + .string "POKéFAN$", 13 + .string "EXPERT$", 13 + .string "YOUNGSTER$", 13 + .string "CHAMPION$", 13 + .string "FISHERMAN$", 13 + .string "TRIATHLETE$", 13 + .string "DRAGON TAMER$", 13 + .string "BIRD KEEPER$", 13 + .string "NINJA BOY$", 13 + .string "BATTLE GIRL$", 13 + .string "PARASOL LADY$", 13 + .string "SWIMMER♀$", 13 + .string "PICNICKER$", 13 + .string "TWINS$", 13 + .string "SAILOR$", 13 + .string "BOARDER$", 13 + .string "COLLECTOR$", 13 + .string "{PKMN} TRAINER$", 13 + .string "{PKMN} BREEDER$", 13 + .string "{PKMN} RANGER$", 13 + .string "MAGMA LEADER$", 13 + .string "TEAM MAGMA$", 13 + .string "LASS$", 13 + .string "BUG CATCHER$", 13 + .string "HIKER$", 13 + .string "YOUNG COUPLE$", 13 + .string "OLD COUPLE$", 13 + .string "SIS AND BRO$", 13 + .string "AQUA ADMIN$", 13 + .string "MAGMA ADMIN$", 13 + .string "YOUNGSTER$", 13 + .string "BUG CATCHER$", 13 + .string "LASS$", 13 + .string "SAILOR$", 13 + .string "CAMPER$", 13 + .string "PICNICKER$", 13 + .string "POKéMANIAC$", 13 + .string "SUPER NERD$", 13 + .string "HIKER$", 13 + .string "BIKER$", 13 + .string "BURGLAR$", 13 + .string "ENGINEER$", 13 + .string "FISHERMAN$", 13 + .string "SWIMMER♂$", 13 + .string "CUE BALL$", 13 + .string "GAMER$", 13 + .string "BEAUTY$", 13 + .string "SWIMMER♀$", 13 + .string "PSYCHIC$", 13 + .string "ROCKER$", 13 + .string "JUGGLER$", 13 + .string "TAMER$", 13 + .string "BIRD KEEPER$", 13 + .string "BLACK BELT$", 13 + .string "RIVAL$", 13 + .string "SCIENTIST$", 13 + .string "BOSS$", 13 + .string "LEADER$", 13 + .string "TEAM ROCKET$", 13 + .string "COOLTRAINER$", 13 + .string "ELITE FOUR$", 13 + .string "GENTLEMAN$", 13 + .string "RIVAL$", 13 + .string "CHAMPION$", 13 + .string "CHANNELER$", 13 + .string "TWINS$", 13 + .string "COOL COUPLE$", 13 + .string "YOUNG COUPLE$", 13 + .string "CRUSH KIN$", 13 + .string "SIS AND BRO$", 13 + .string "{PKMN} PROF.$", 13 + .string "PLAYER$", 13 + .string "CRUSH GIRL$", 13 + .string "TUBER$", 13 + .string "{PKMN} BREEDER$", 13 + .string "{PKMN} RANGER$", 13 + .string "AROMA LADY$", 13 + .string "RUIN MANIAC$", 13 + .string "LADY$", 13 + .string "PAINTER$", 13