dionmoustos/Pokemon-Firered
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix formatting errors and implement review suggestions.

Browse Source
This commit is contained in:
ultima-soul
2019-08-05 16:15:25 -07:00
parent ed90bf2430
commit f0a86aec2d
2 changed files with 23 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ld_script.txt
+4 -4
View File
@@ -422,15 +422,15 @@ SECTIONS {
data/data_83F5738.o(.rodata.83FB134); data/data_83F5738.o(.rodata.83FB134);
src/save.o(.rodata); src/save.o(.rodata);
data/data_83FECCC.o(.rodata); data/data_83FECCC.o(.rodata);
src/intro.o(.rodata); src/intro.o(.rodata);
data/data_83FECCC.o(.rodata.battle_anim_special); data/data_83FECCC.o(.rodata.battle_anim_special);
src/diploma.o(.rodata); src/diploma.o(.rodata);
data/strings.o(.rodata); data/strings.o(.rodata);
data/data_83FECCC.o(.rodata.841EE44); data/data_83FECCC.o(.rodata.841EE44);
src/new_menu_helpers.o(.rodata); src/new_menu_helpers.o(.rodata);
data/data_83FECCC.o(.rodata.841F4B4); data/data_83FECCC.o(.rodata.841F4B4);
src/pokedex.o(.rodata); src/pokedex.o(.rodata);
data/data_83FECCC.o(.rodata.8451EBC); data/data_83FECCC.o(.rodata.8451EBC);
src/list_menu.o(.rodata); src/list_menu.o(.rodata);
data/data_83FECCC.o(.rodata.8452CF4); data/data_83FECCC.o(.rodata.8452CF4);
src/save_location.o(.rodata); src/save_location.o(.rodata);
@@ -549,7 +549,7 @@ SECTIONS {
data/multiboot_pokemon_colosseum.o(.rodata); data/multiboot_pokemon_colosseum.o(.rodata);
} =0 } =0
. = 0x08D00000; . = 0x08D00000;
gfx_data : gfx_data :
ALIGN(4) ALIGN(4)
{ {
src/pokedex.c
+19 -19
View File
@@ -18,12 +18,12 @@ u16 GetPokedexHeightWeight(u16 dexNum, u8 data)
{ {
switch (data) switch (data)
{ {
case 0: // height case 0: // height
return gPokedexEntries[dexNum].height; return gPokedexEntries[dexNum].height;
case 1: // weight case 1: // weight
return gPokedexEntries[dexNum].weight; return gPokedexEntries[dexNum].weight;
default: default:
return 1; return 1;
} }
} }
@@ -63,14 +63,14 @@ u16 GetKantoPokedexCount(u8 caseID)
{ {
switch (caseID) switch (caseID)
{ {
case FLAG_GET_SEEN: case FLAG_GET_SEEN:
if (GetSetPokedexFlag(i + 1, FLAG_GET_SEEN)) if (GetSetPokedexFlag(i + 1, FLAG_GET_SEEN))
count++; count++;
break; break;
case FLAG_GET_CAUGHT: case FLAG_GET_CAUGHT:
if (GetSetPokedexFlag(i + 1, FLAG_GET_CAUGHT)) if (GetSetPokedexFlag(i + 1, FLAG_GET_CAUGHT))
count++; count++;
break; break;
} }
} }
return count; return count;
@@ -100,24 +100,24 @@ bool8 HasAllKantoMons(void)
return TRUE; return TRUE;
} }
u16 HasAllMons(void) bool16 HasAllMons(void)
{ {
u16 i; u16 i;
for (i = 0; i < NATIONAL_DEX_MEWTWO; i++) for (i = 0; i < NATIONAL_DEX_MEWTWO; i++)
{ {
if (!GetSetPokedexFlag(i + 1, FLAG_GET_CAUGHT)) if (!GetSetPokedexFlag(i + 1, FLAG_GET_CAUGHT))
return 0; return FALSE;
} }
for (i = NATIONAL_DEX_MEW; i < NATIONAL_DEX_TYRANITAR; i++) for (i = NATIONAL_DEX_MEW; i < NATIONAL_DEX_TYRANITAR; i++)
{ {
if (!GetSetPokedexFlag(i + 1, FLAG_GET_CAUGHT)) if (!GetSetPokedexFlag(i + 1, FLAG_GET_CAUGHT))
return 0; return FALSE;
} }
for (i = NATIONAL_DEX_CELEBI; i < NATIONAL_DEX_RAYQUAZA; i++) for (i = NATIONAL_DEX_CELEBI; i < NATIONAL_DEX_RAYQUAZA; i++)
{ {
if (!GetSetPokedexFlag(i + 1, FLAG_GET_CAUGHT)) if (!GetSetPokedexFlag(i + 1, FLAG_GET_CAUGHT))
return 0; return FALSE;
} }
return 1; return TRUE;
} }