From 14e85249d1a7bb67af9bc4be04bba9e4a73d75c5 Mon Sep 17 00:00:00 2001
From: Eduardo Quezada <eduardo602002@gmail.com>
Date: Sun, 30 Oct 2022 17:12:13 -0300
Subject: [PATCH] Review changes

---
 .../pokemon/{base_stats.h => species_info.h}  | 52 +++++++++----------
 src/pokemon.c                                 |  4 +-
 2 files changed, 28 insertions(+), 28 deletions(-)
 rename src/data/pokemon/{base_stats.h => species_info.h} (99%)

diff --git a/src/data/pokemon/base_stats.h b/src/data/pokemon/species_info.h
similarity index 99%
rename from src/data/pokemon/base_stats.h
rename to src/data/pokemon/species_info.h
index 115941f81d..5af84df1fd 100644
--- a/src/data/pokemon/base_stats.h
+++ b/src/data/pokemon/species_info.h
@@ -2,7 +2,7 @@
 // 255 (MON_GENDERLESS) is reserved for genderless Pokémon.
 #define PERCENT_FEMALE(percent) min(254, ((percent * 255) / 100))
 
-#define OLD_UNOWN_BASE_STATS                        \
+#define OLD_UNOWN_SPECIES_INFO                      \
     {                                               \
         .baseHP = 50,                               \
         .baseAttack = 150,                          \
@@ -8070,55 +8070,55 @@ const struct SpeciesInfo gSpeciesInfo[] =
         .noFlip = FALSE,
     },
 
-    [SPECIES_OLD_UNOWN_B] = OLD_UNOWN_BASE_STATS,
+    [SPECIES_OLD_UNOWN_B] = OLD_UNOWN_SPECIES_INFO,
 
-    [SPECIES_OLD_UNOWN_C] = OLD_UNOWN_BASE_STATS,
+    [SPECIES_OLD_UNOWN_C] = OLD_UNOWN_SPECIES_INFO,
 
-    [SPECIES_OLD_UNOWN_D] = OLD_UNOWN_BASE_STATS,
+    [SPECIES_OLD_UNOWN_D] = OLD_UNOWN_SPECIES_INFO,
 
-    [SPECIES_OLD_UNOWN_E] = OLD_UNOWN_BASE_STATS,
+    [SPECIES_OLD_UNOWN_E] = OLD_UNOWN_SPECIES_INFO,
 
-    [SPECIES_OLD_UNOWN_F] = OLD_UNOWN_BASE_STATS,
+    [SPECIES_OLD_UNOWN_F] = OLD_UNOWN_SPECIES_INFO,
 
-    [SPECIES_OLD_UNOWN_G] = OLD_UNOWN_BASE_STATS,
+    [SPECIES_OLD_UNOWN_G] = OLD_UNOWN_SPECIES_INFO,
 
-    [SPECIES_OLD_UNOWN_H] = OLD_UNOWN_BASE_STATS,
+    [SPECIES_OLD_UNOWN_H] = OLD_UNOWN_SPECIES_INFO,
 
-    [SPECIES_OLD_UNOWN_I] = OLD_UNOWN_BASE_STATS,
+    [SPECIES_OLD_UNOWN_I] = OLD_UNOWN_SPECIES_INFO,
 
-    [SPECIES_OLD_UNOWN_J] = OLD_UNOWN_BASE_STATS,
+    [SPECIES_OLD_UNOWN_J] = OLD_UNOWN_SPECIES_INFO,
 
-    [SPECIES_OLD_UNOWN_K] = OLD_UNOWN_BASE_STATS,
+    [SPECIES_OLD_UNOWN_K] = OLD_UNOWN_SPECIES_INFO,
 
-    [SPECIES_OLD_UNOWN_L] = OLD_UNOWN_BASE_STATS,
+    [SPECIES_OLD_UNOWN_L] = OLD_UNOWN_SPECIES_INFO,
 
-    [SPECIES_OLD_UNOWN_M] = OLD_UNOWN_BASE_STATS,
+    [SPECIES_OLD_UNOWN_M] = OLD_UNOWN_SPECIES_INFO,
 
-    [SPECIES_OLD_UNOWN_N] = OLD_UNOWN_BASE_STATS,
+    [SPECIES_OLD_UNOWN_N] = OLD_UNOWN_SPECIES_INFO,
 
-    [SPECIES_OLD_UNOWN_O] = OLD_UNOWN_BASE_STATS,
+    [SPECIES_OLD_UNOWN_O] = OLD_UNOWN_SPECIES_INFO,
 
-    [SPECIES_OLD_UNOWN_P] = OLD_UNOWN_BASE_STATS,
+    [SPECIES_OLD_UNOWN_P] = OLD_UNOWN_SPECIES_INFO,
 
-    [SPECIES_OLD_UNOWN_Q] = OLD_UNOWN_BASE_STATS,
+    [SPECIES_OLD_UNOWN_Q] = OLD_UNOWN_SPECIES_INFO,
 
-    [SPECIES_OLD_UNOWN_R] = OLD_UNOWN_BASE_STATS,
+    [SPECIES_OLD_UNOWN_R] = OLD_UNOWN_SPECIES_INFO,
 
-    [SPECIES_OLD_UNOWN_S] = OLD_UNOWN_BASE_STATS,
+    [SPECIES_OLD_UNOWN_S] = OLD_UNOWN_SPECIES_INFO,
 
-    [SPECIES_OLD_UNOWN_T] = OLD_UNOWN_BASE_STATS,
+    [SPECIES_OLD_UNOWN_T] = OLD_UNOWN_SPECIES_INFO,
 
-    [SPECIES_OLD_UNOWN_U] = OLD_UNOWN_BASE_STATS,
+    [SPECIES_OLD_UNOWN_U] = OLD_UNOWN_SPECIES_INFO,
 
-    [SPECIES_OLD_UNOWN_V] = OLD_UNOWN_BASE_STATS,
+    [SPECIES_OLD_UNOWN_V] = OLD_UNOWN_SPECIES_INFO,
 
-    [SPECIES_OLD_UNOWN_W] = OLD_UNOWN_BASE_STATS,
+    [SPECIES_OLD_UNOWN_W] = OLD_UNOWN_SPECIES_INFO,
 
-    [SPECIES_OLD_UNOWN_X] = OLD_UNOWN_BASE_STATS,
+    [SPECIES_OLD_UNOWN_X] = OLD_UNOWN_SPECIES_INFO,
 
-    [SPECIES_OLD_UNOWN_Y] = OLD_UNOWN_BASE_STATS,
+    [SPECIES_OLD_UNOWN_Y] = OLD_UNOWN_SPECIES_INFO,
 
-    [SPECIES_OLD_UNOWN_Z] = OLD_UNOWN_BASE_STATS,
+    [SPECIES_OLD_UNOWN_Z] = OLD_UNOWN_SPECIES_INFO,
 
     [SPECIES_TREECKO] =
     {
diff --git a/src/pokemon.c b/src/pokemon.c
index a66641520a..1e40220e29 100644
--- a/src/pokemon.c
+++ b/src/pokemon.c
@@ -1388,7 +1388,7 @@ const s8 gNatureStatTable[NUM_NATURES][NUM_NATURE_STATS] =
 #include "data/pokemon/trainer_class_lookups.h"
 #include "data/pokemon/cry_ids.h"
 #include "data/pokemon/experience_tables.h"
-#include "data/pokemon/base_stats.h"
+#include "data/pokemon/species_info.h"
 #include "data/pokemon/level_up_learnsets.h"
 #include "data/pokemon/evolution.h"
 #include "data/pokemon/level_up_learnset_pointers.h"
@@ -2806,7 +2806,7 @@ static u16 CalculateBoxMonChecksum(struct BoxPokemon *boxMon)
 
 #define CALC_STAT(base, iv, ev, statIndex, field)               \
 {                                                               \
-    u8 baseStat = gSpeciesInfo[species].base;                     \
+    u8 baseStat = gSpeciesInfo[species].base;                   \
     s32 n = (((2 * baseStat + iv + ev / 4) * level) / 100) + 5; \
     u8 nature = GetNature(mon);                                 \
     n = ModifyStatByNature(nature, n, statIndex);               \