Various BUGFIXes and UBFIXes

This commit is contained in:
ExpoSeed committed 2021-05-15 15:56:17 -05:00
1 parent ab8318cc79
commit 361fa594b3
10 files changed
+48 -9

No files matched your search

+6 -2
View File
@@ -135,8 +135,10 @@ void SoundTask_PlayCryHighPitch(u8 taskId)
{
if (gBattleAnimArgs[0] == ANIM_ATTACKER)
species = gContestResources->moveAnim->species;
#ifndef UBFIX
else
DestroyAnimVisualTask(taskId); // UB: function should return upon destroying task.
DestroyAnimVisualTask(taskId); // UB: task gets destroyed twice.
#endif
}
else
{
@@ -179,8 +181,10 @@ void SoundTask_PlayDoubleCry(u8 taskId)
{
if (gBattleAnimArgs[0] == ANIM_ATTACKER)
species = gContestResources->moveAnim->species;
#ifndef UBFIX
else
DestroyAnimVisualTask(taskId); // UB: function should return upon destroying task.
DestroyAnimVisualTask(taskId); // UB: task gets destroyed twice.
#endif
}
else
{