Some of the INVALID_ are likely erroneously placed, due to lack of documentation
This commit is contained in:
@@ -4825,7 +4825,7 @@ static u16 GetCurrentMapWildMonHeaderId(void)
|
||||
for (i = 0; ; i++)
|
||||
{
|
||||
const struct WildPokemonHeader *wildHeader = &gWildMonHeaders[i];
|
||||
if (wildHeader->mapGroup == 0xFF)
|
||||
if (wildHeader->mapGroup == INVALID_U8)
|
||||
break;
|
||||
|
||||
if (gWildMonHeaders[i].mapGroup == gSaveBlock1Ptr->location.mapGroup &&
|
||||
@@ -4845,7 +4845,7 @@ static u16 GetCurrentMapWildMonHeaderId(void)
|
||||
}
|
||||
}
|
||||
|
||||
return -1;
|
||||
return INVALID_S16;
|
||||
}
|
||||
|
||||
static u8 PickWildMonNature(void)
|
||||
@@ -5079,7 +5079,7 @@ bool8 StandardWildEncounter(u16 currMetaTileBehavior, u16 previousMetaTileBehavi
|
||||
return FALSE;
|
||||
|
||||
headerId = GetCurrentMapWildMonHeaderId();
|
||||
if (headerId == 0xFFFF) // invalid
|
||||
if (headerId == INVALID_U16)
|
||||
{
|
||||
if (gMapHeader.mapLayoutId == 0x166)
|
||||
{
|
||||
@@ -5190,7 +5190,7 @@ void RockSmashWildEncounter(void)
|
||||
{
|
||||
u16 headerId = GetCurrentMapWildMonHeaderId();
|
||||
|
||||
if (headerId != 0xFFFF)
|
||||
if (headerId != INVALID_U16)
|
||||
{
|
||||
const struct WildPokemonInfo *wildPokemonInfo = gWildMonHeaders[headerId].rockSmashMonsInfo;
|
||||
|
||||
@@ -5222,7 +5222,7 @@ bool8 SweetScentWildEncounter(void)
|
||||
|
||||
PlayerGetDestCoords(&x, &y);
|
||||
headerId = GetCurrentMapWildMonHeaderId();
|
||||
if (headerId == 0xFFFF) // invalid
|
||||
if (headerId == INVALID_U16)
|
||||
{
|
||||
if (gMapHeader.mapLayoutId == 0x166)
|
||||
{
|
||||
@@ -5292,7 +5292,7 @@ bool8 DoesCurrentMapHaveFishingMons(void)
|
||||
{
|
||||
u16 headerId = GetCurrentMapWildMonHeaderId();
|
||||
|
||||
if (headerId != 0xFFFF && gWildMonHeaders[headerId].fishingMonsInfo != NULL)
|
||||
if (headerId != INVALID_U16 && gWildMonHeaders[headerId].fishingMonsInfo != NULL)
|
||||
return TRUE;
|
||||
else
|
||||
return FALSE;
|
||||
@@ -5326,7 +5326,7 @@ u16 GetLocalWildMon(bool8 *isWaterMon)
|
||||
|
||||
*isWaterMon = FALSE;
|
||||
headerId = GetCurrentMapWildMonHeaderId();
|
||||
if (headerId == 0xFFFF)
|
||||
if (headerId == INVALID_U16)
|
||||
return SPECIES_NONE;
|
||||
landMonsInfo = gWildMonHeaders[headerId].landMonsInfo;
|
||||
waterMonsInfo = gWildMonHeaders[headerId].waterMonsInfo;
|
||||
@@ -5358,7 +5358,7 @@ u16 GetLocalWaterMon(void)
|
||||
{
|
||||
u16 headerId = GetCurrentMapWildMonHeaderId();
|
||||
|
||||
if (headerId != 0xFFFF)
|
||||
if (headerId != INVALID_U16)
|
||||
{
|
||||
const struct WildPokemonInfo *waterMonsInfo = gWildMonHeaders[headerId].waterMonsInfo;
|
||||
|
||||
|
||||
Reference in New Issue
Block a user