Use a constant instead of integer literals when checking for shinyness

2019-07-11 20:16:39 +02:00
parent ae01afdd30
commit 75f165ed74
3 changed files with 8 additions and 5 deletions
@@ -2029,7 +2029,7 @@ void sub_8172EF0(u8 battler, struct Pokemon *mon)
    if (IsBattlerSpriteVisible(battler))
    {
        shinyValue = HIHALF(otId) ^ LOHALF(otId) ^ HIHALF(personality) ^ LOHALF(personality);
-        if (shinyValue < 8)
+        if (shinyValue < SHINY_ODDS)
            isShiny = TRUE;

        if (isShiny)