Undo PokeCodec's PRs
This commit undoes most of PokeCodec's PRs after the debate in chat. Some harmless or completely superseded PRs have been left alone, as there is not much benefit in attempting to undo them. Reverts #1104, #1108, #1115, #1118, #1119, #1124, #1126, #1127, #1132, #1136, #1137, #1139, #1140, #1144, #1148, #1149, #1150, #1153, #1155, #1177, #1179, #1180, #1181, #1182 and #1183.
This commit is contained in:
+5
-5
@@ -430,7 +430,7 @@ static const struct ListMenuTemplate sPokeblockListMenuTemplate =
|
||||
// code
|
||||
void OpenPokeblockCase(u8 caseId, void (*callback)(void))
|
||||
{
|
||||
sPokeblockMenu = Alloc(sizeof(struct PokeblockMenuStruct));
|
||||
sPokeblockMenu = Alloc(sizeof(*sPokeblockMenu));
|
||||
sPokeblockMenu->caseId = caseId;
|
||||
sPokeblockMenu->callbackOnUse = NULL;
|
||||
sPokeblockMenu->unkTaskId = 0xFF;
|
||||
@@ -984,7 +984,7 @@ static void Task_HandlePokeblockMenuInput(u8 taskId)
|
||||
|
||||
if (!gPaletteFade.active && MenuHelpers_CallLinkSomething() != TRUE)
|
||||
{
|
||||
if (JOY_NEW(SELECT_BUTTON))
|
||||
if (gMain.newKeys & SELECT_BUTTON)
|
||||
{
|
||||
ListMenuGetScrollAndRow(data[0], &sSavedPokeblockData.lastItemPage, &sSavedPokeblockData.lastItemPos);
|
||||
if (sSavedPokeblockData.lastItemPage + sSavedPokeblockData.lastItemPos != sPokeblockMenu->itemsNo - 1)
|
||||
@@ -1035,7 +1035,7 @@ static void Task_HandlePokeblocksSwapInput(u8 taskId)
|
||||
if (MenuHelpers_CallLinkSomething() == TRUE)
|
||||
return;
|
||||
|
||||
if (JOY_NEW(SELECT_BUTTON))
|
||||
if (gMain.newKeys & SELECT_BUTTON)
|
||||
{
|
||||
PlaySE(SE_SELECT);
|
||||
ListMenuGetScrollAndRow(data[0], &sSavedPokeblockData.lastItemPage, &sSavedPokeblockData.lastItemPos);
|
||||
@@ -1069,7 +1069,7 @@ static void Task_HandlePokeblocksSwapInput(u8 taskId)
|
||||
break;
|
||||
case LIST_CANCEL: // same id as STOW CASE field
|
||||
PlaySE(SE_SELECT);
|
||||
if (JOY_NEW(A_BUTTON))
|
||||
if (gMain.newKeys & A_BUTTON)
|
||||
HandlePokeblocksSwap(taskId, FALSE);
|
||||
else
|
||||
HandlePokeblocksSwap(taskId, TRUE);
|
||||
@@ -1193,7 +1193,7 @@ static void TossPokeblockChoice_Yes(u8 taskId)
|
||||
|
||||
static void HandleErasePokeblock(u8 taskId)
|
||||
{
|
||||
if (JOY_NEW(A_BUTTON | B_BUTTON))
|
||||
if (gMain.newKeys & (A_BUTTON | B_BUTTON))
|
||||
{
|
||||
s16 *data;
|
||||
u16 *lastPage, *lastPos;
|
||||
|
||||
Reference in New Issue
Block a user