Review changes from https://github.com/pret/pokefirered/pull/525

2022-08-01 15:37:05 -04:00
parent cc288e3786
commit b49f8c10ad
2 changed files with 9 additions and 13 deletions
@@ -396,20 +396,16 @@ bool8 HandleMonMarkingsMenuInput(void)

    if (JOY_NEW(DPAD_UP))
    {
-        s8 pos;
        PlaySE(SE_SELECT);
-        pos = --sMenu->cursorPos;
-        if (pos < 0)
+        if (--sMenu->cursorPos < 0)
            sMenu->cursorPos = SELECTION_CANCEL;
        return TRUE;
    }

    if (JOY_NEW(DPAD_DOWN))
    {
-        s8 pos;
        PlaySE(SE_SELECT);
-        pos = ++sMenu->cursorPos;
-        if (pos > SELECTION_CANCEL)
+        if (++sMenu->cursorPos > SELECTION_CANCEL)
            sMenu->cursorPos = 0;
        return TRUE;
    }