dionmoustos/PokemonEmeraldSafariFrontier
1
0
Fork 0
Code Issues 21 Pull Requests Actions Packages Projects Releases Wiki Activity

adds constants, cleans up callstd and msgbox code

Browse Source 
* adds some constants for standard script names and messagebox types
* replaces some callstd calls with msgbox calls where equivalent
* replaces msgbox and callstd calls using raw digits with versions that use the constants
This commit is contained in:
Melody
2018-12-02 03:37:46 -05:00
parent 145047d438
commit c557ac61ae
354 changed files with 4538 additions and 4531 deletions
Download Patch File Download Diff File Expand all files Collapse all files
data/maps/BattleFrontier_BattleDomePreBattleRoom/scripts.inc
+15 -15
View File
@@ -69,7 +69,7 @@ BattleFrontier_BattleDomePreBattleRoom_EventScript_24B33F:: @ 824B33F
goto BattleFrontier_BattleDomePreBattleRoom_EventScript_24B24F
BattleFrontier_BattleDomePreBattleRoom_EventScript_24B349:: @ 824B349
msgbox BattleFrontier_BattleDomePreBattleRoom_Text_24BA69, 5
msgbox BattleFrontier_BattleDomePreBattleRoom_Text_24BA69, MSGBOX_YESNO
switch VAR_RESULT
case 0, BattleFrontier_BattleDomePreBattleRoom_EventScript_24B24F
case 1, BattleFrontier_BattleDomePreBattleRoom_EventScript_24B3BB
@@ -104,7 +104,7 @@ BattleFrontier_BattleDomePreBattleRoom_EventScript_24B3BB:: @ 824B3BB
end
BattleFrontier_BattleDomePreBattleRoom_EventScript_24B3DD:: @ 824B3DD
msgbox BattleFrontier_BattleDomePreBattleRoom_Text_24B9B5, 4
msgbox BattleFrontier_BattleDomePreBattleRoom_Text_24B9B5, MSGBOX_DEFAULT
fadescreen 1
setvar VAR_0x8004, 6
special CallBattleDomeFunction
@@ -131,19 +131,19 @@ BattleFrontier_BattleDomePreBattleRoom_EventScript_24B40A:: @ 824B40A
return
BattleFrontier_BattleDomePreBattleRoom_EventScript_24B449:: @ 824B449
msgbox BattleFrontier_BattleDomePreBattleRoom_Text_24B9D9, 4
msgbox BattleFrontier_BattleDomePreBattleRoom_Text_24B9D9, MSGBOX_DEFAULT
return
BattleFrontier_BattleDomePreBattleRoom_EventScript_24B452:: @ 824B452
msgbox BattleFrontier_BattleDomePreBattleRoom_Text_24B9FD, 4
msgbox BattleFrontier_BattleDomePreBattleRoom_Text_24B9FD, MSGBOX_DEFAULT
return
BattleFrontier_BattleDomePreBattleRoom_EventScript_24B45B:: @ 824B45B
msgbox BattleFrontier_BattleDomePreBattleRoom_Text_24BA21, 4
msgbox BattleFrontier_BattleDomePreBattleRoom_Text_24BA21, MSGBOX_DEFAULT
return
BattleFrontier_BattleDomePreBattleRoom_EventScript_24B464:: @ 824B464
msgbox BattleFrontier_BattleDomePreBattleRoom_Text_24BA46, 4
msgbox BattleFrontier_BattleDomePreBattleRoom_Text_24BA46, MSGBOX_DEFAULT
return
BattleFrontier_BattleDomePreBattleRoom_EventScript_24B46D:: @ 824B46D
@@ -167,7 +167,7 @@ BattleFrontier_BattleDomePreBattleRoom_EventScript_24B46D:: @ 824B46D
special CallBattleDomeFunction
setvar VAR_0x8004, 9
special CallBattleDomeFunction
msgbox BattleFrontier_BattleDomePreBattleRoom_Text_24B748, 4
msgbox BattleFrontier_BattleDomePreBattleRoom_Text_24B748, MSGBOX_DEFAULT
closemessage
applymovement 1, BattleFrontier_BattleDomePreBattleRoom_Movement_24B64F
waitmovement 0
@@ -221,28 +221,28 @@ BattleFrontier_BattleDomePreBattleRoom_EventScript_24B54C:: @ 824B54C
BattleFrontier_BattleDomePreBattleRoom_EventScript_24B58B:: @ 824B58B
checkflag FLAG_TEMP_1
goto_eq BattleFrontier_BattleDomePreBattleRoom_EventScript_24B5B5
msgbox BattleFrontier_BattleDomePreBattleRoom_Text_24BB2E, 4
msgbox BattleFrontier_BattleDomePreBattleRoom_Text_24BB2E, MSGBOX_DEFAULT
setflag FLAG_TEMP_1
return
BattleFrontier_BattleDomePreBattleRoom_EventScript_24B5A0:: @ 824B5A0
checkflag FLAG_TEMP_1
goto_eq BattleFrontier_BattleDomePreBattleRoom_EventScript_24B5BE
msgbox BattleFrontier_BattleDomePreBattleRoom_Text_24BBAC, 4
msgbox BattleFrontier_BattleDomePreBattleRoom_Text_24BBAC, MSGBOX_DEFAULT
setflag FLAG_TEMP_1
return
BattleFrontier_BattleDomePreBattleRoom_EventScript_24B5B5:: @ 824B5B5
msgbox BattleFrontier_BattleDomePreBattleRoom_Text_24BC2A, 4
msgbox BattleFrontier_BattleDomePreBattleRoom_Text_24BC2A, MSGBOX_DEFAULT
return
BattleFrontier_BattleDomePreBattleRoom_EventScript_24B5BE:: @ 824B5BE
msgbox BattleFrontier_BattleDomePreBattleRoom_Text_24BC63, 4
msgbox BattleFrontier_BattleDomePreBattleRoom_Text_24BC63, MSGBOX_DEFAULT
return
BattleFrontier_BattleDomePreBattleRoom_EventScript_24B5C7:: @ 824B5C7
setvar VAR_TEMP_0, 1
msgbox BattleFrontier_BattleDomePreBattleRoom_Text_24B760, 4
msgbox BattleFrontier_BattleDomePreBattleRoom_Text_24B760, MSGBOX_DEFAULT
special LoadPlayerParty
setvar VAR_0x8004, 3
setvar VAR_0x8005, 3
@@ -268,15 +268,15 @@ BattleFrontier_BattleDomePreBattleRoom_EventScript_24B600:: @ 824B600
return
BattleFrontier_BattleDomePreBattleRoom_EventScript_24B634:: @ 824B634
msgbox BattleFrontier_BattleDomePreBattleRoom_Text_24B7A3, 4
msgbox BattleFrontier_BattleDomePreBattleRoom_Text_24B7A3, MSGBOX_DEFAULT
return
BattleFrontier_BattleDomePreBattleRoom_EventScript_24B63D:: @ 824B63D
msgbox BattleFrontier_BattleDomePreBattleRoom_Text_24B7F1, 4
msgbox BattleFrontier_BattleDomePreBattleRoom_Text_24B7F1, MSGBOX_DEFAULT
return
BattleFrontier_BattleDomePreBattleRoom_EventScript_24B646:: @ 824B646
msgbox BattleFrontier_BattleDomePreBattleRoom_Text_24B83F, 4
msgbox BattleFrontier_BattleDomePreBattleRoom_Text_24B83F, MSGBOX_DEFAULT
return
BattleFrontier_BattleDomePreBattleRoom_Movement_24B64F: @ 824B64F