dionmoustos/PokemonEmeraldSafariFrontier
1
0
Fork 0
Code Issues 21 Pull Requests Actions Packages Projects Releases Wiki Activity

adds constants, cleans up callstd and msgbox code

Browse Source 
* adds some constants for standard script names and messagebox types
* replaces some callstd calls with msgbox calls where equivalent
* replaces msgbox and callstd calls using raw digits with versions that use the constants
This commit is contained in:
Melody
2018-12-02 03:37:46 -05:00
parent 145047d438
commit c557ac61ae
354 changed files with 4538 additions and 4531 deletions
Download Patch File Download Diff File Expand all files Collapse all files
data/maps/FallarborTown_House1/scripts.inc
+11 -11
View File
@@ -9,7 +9,7 @@ FallarborTown_House1_EventScript_200F13:: @ 8200F13
checkitem ITEM_METEORITE, 1
compare VAR_RESULT, 1
goto_eq FallarborTown_House1_EventScript_200F38
msgbox FallarborTown_House1_Text_200FEE, 4
msgbox FallarborTown_House1_Text_200FEE, MSGBOX_DEFAULT
release
end
@@ -20,34 +20,34 @@ FallarborTown_House1_EventScript_200F38:: @ 8200F38
call_if 1, FallarborTown_House1_EventScript_200F9C
compare VAR_RESULT, 0
goto_eq FallarborTown_House1_EventScript_200FA5
msgbox FallarborTown_House1_Text_201159, 4
msgbox FallarborTown_House1_Text_201159, MSGBOX_DEFAULT
giveitem_std ITEM_TM27
compare VAR_RESULT, 0
goto_eq FallarborTown_House1_EventScript_272054
setvar VAR_0x8004, 280
call FallarborTown_House1_EventScript_2723E4
setflag FLAG_0x0E5
msgbox FallarborTown_House1_Text_2011A5, 4
msgbox FallarborTown_House1_Text_2011A5, MSGBOX_DEFAULT
release
end
FallarborTown_House1_EventScript_200F8B:: @ 8200F8B
msgbox FallarborTown_House1_Text_200FEE, 4
msgbox FallarborTown_House1_Text_2010A2, 5
msgbox FallarborTown_House1_Text_200FEE, MSGBOX_DEFAULT
msgbox FallarborTown_House1_Text_2010A2, MSGBOX_YESNO
return
FallarborTown_House1_EventScript_200F9C:: @ 8200F9C
msgbox FallarborTown_House1_Text_201249, 5
msgbox FallarborTown_House1_Text_201249, MSGBOX_YESNO
return
FallarborTown_House1_EventScript_200FA5:: @ 8200FA5
setflag FLAG_TEMP_2
msgbox FallarborTown_House1_Text_201212, 4
msgbox FallarborTown_House1_Text_201212, MSGBOX_DEFAULT
release
end
FallarborTown_House1_EventScript_200FB2:: @ 8200FB2
msgbox FallarborTown_House1_Text_2011A5, 4
msgbox FallarborTown_House1_Text_2011A5, MSGBOX_DEFAULT
release
end
@@ -58,17 +58,17 @@ FallarborTown_House1_EventScript_200FBC:: @ 8200FBC
goto_eq FallarborTown_House1_EventScript_200FE4
checkflag FLAG_0x08B
goto_eq FallarborTown_House1_EventScript_200FDA
msgbox FallarborTown_House1_Text_2012BC, 4
msgbox FallarborTown_House1_Text_2012BC, MSGBOX_DEFAULT
release
end
FallarborTown_House1_EventScript_200FDA:: @ 8200FDA
msgbox FallarborTown_House1_Text_201310, 4
msgbox FallarborTown_House1_Text_201310, MSGBOX_DEFAULT
release
end
FallarborTown_House1_EventScript_200FE4:: @ 8200FE4
msgbox FallarborTown_House1_Text_20134B, 4
msgbox FallarborTown_House1_Text_20134B, MSGBOX_DEFAULT
release
end