dionmoustos/PokemonEmeraldSafariFrontier
1
0
Fork 0
Code Issues 21 Pull Requests Actions Packages Projects Releases Wiki Activity

adds constants, cleans up callstd and msgbox code

Browse Source 
* adds some constants for standard script names and messagebox types
* replaces some callstd calls with msgbox calls where equivalent
* replaces msgbox and callstd calls using raw digits with versions that use the constants
This commit is contained in:
Melody
2018-12-02 03:37:46 -05:00
parent 145047d438
commit c557ac61ae
354 changed files with 4538 additions and 4531 deletions
Download Patch File Download Diff File Expand all files Collapse all files
data/maps/FortreeCity/scripts.inc
+12 -12
View File
@@ -12,7 +12,7 @@ FortreeCity_MapScript1_1E25B3: @ 81E25B3
end
FortreeCity_EventScript_1E25B6:: @ 81E25B6
msgbox FortreeCity_Text_1E2676, 2
msgbox FortreeCity_Text_1E2676, MSGBOX_NPC
end
FortreeCity_EventScript_1E25BF:: @ 81E25BF
@@ -20,37 +20,37 @@ FortreeCity_EventScript_1E25BF:: @ 81E25BF
faceplayer
checkflag FLAG_0x127
goto_eq FortreeCity_EventScript_1E25D4
msgbox FortreeCity_Text_1E2738, 4
msgbox FortreeCity_Text_1E2738, MSGBOX_DEFAULT
release
end
FortreeCity_EventScript_1E25D4:: @ 81E25D4
msgbox FortreeCity_Text_1E27B6, 4
msgbox FortreeCity_Text_1E27B6, MSGBOX_DEFAULT
release
end
FortreeCity_EventScript_1E25DE:: @ 81E25DE
msgbox FortreeCity_Text_1E27FE, 2
msgbox FortreeCity_Text_1E27FE, MSGBOX_NPC
end
FortreeCity_EventScript_1E25E7:: @ 81E25E7
msgbox FortreeCity_Text_1E2880, 2
msgbox FortreeCity_Text_1E2880, MSGBOX_NPC
end
FortreeCity_EventScript_1E25F0:: @ 81E25F0
msgbox FortreeCity_Text_1E292E, 2
msgbox FortreeCity_Text_1E292E, MSGBOX_NPC
end
FortreeCity_EventScript_1E25F9:: @ 81E25F9
msgbox FortreeCity_Text_1E299D, 2
msgbox FortreeCity_Text_1E299D, MSGBOX_NPC
end
FortreeCity_EventScript_1E2602:: @ 81E2602
msgbox FortreeCity_Text_1E2AAC, 3
msgbox FortreeCity_Text_1E2AAC, MSGBOX_SIGN
end
FortreeCity_EventScript_1E260B:: @ 81E260B
msgbox FortreeCity_Text_1E2AE6, 3
msgbox FortreeCity_Text_1E2AE6, MSGBOX_SIGN
end
FortreeCity_EventScript_1E2614:: @ 81E2614
@@ -59,19 +59,19 @@ FortreeCity_EventScript_1E2614:: @ 81E2614
checkitem ITEM_DEVON_SCOPE, 1
compare VAR_RESULT, 1
goto_eq FortreeCity_EventScript_1E2630
msgbox FortreeCity_Text_1E29E5, 4
msgbox FortreeCity_Text_1E29E5, MSGBOX_DEFAULT
release
end
FortreeCity_EventScript_1E2630:: @ 81E2630
msgbox FortreeCity_Text_1E2A08, 5
msgbox FortreeCity_Text_1E2A08, MSGBOX_YESNO
compare VAR_RESULT, 1
goto_eq FortreeCity_EventScript_1E2645
release
end
FortreeCity_EventScript_1E2645:: @ 81E2645
msgbox FortreeCity_Text_1E2A48, 4
msgbox FortreeCity_Text_1E2A48, MSGBOX_DEFAULT
closemessage
applymovement VAR_LAST_TALKED, FortreeCity_Movement_2723C7
waitmovement 0