adds constants, cleans up callstd and msgbox code

* adds some constants for standard script names and messagebox types
* replaces some callstd calls with msgbox calls where equivalent
* replaces msgbox and callstd calls using raw digits with versions that use the constants

data/maps/LavaridgeTown_HerbShop/scripts.inc

@@ -7,7 +7,7 @@ LavaridgeTown_HerbShop_EventScript_1FE4D7:: @ 81FE4D7
 	message LavaridgeTown_HerbShop_Text_1FE53E
 	waitmessage
 	pokemart LavaridgeTown_HerbShop_Pokemart_1FE4F0
-	msgbox gUnknown_08272A3F, 4
+	msgbox gUnknown_08272A3F, MSGBOX_DEFAULT
 	release
 	end
 
@@ -22,7 +22,7 @@ LavaridgeTown_HerbShop_Pokemart_1FE4F0: @ 81FE4F0
 	end
 
 LavaridgeTown_HerbShop_EventScript_1FE4FC:: @ 81FE4FC
-	msgbox LavaridgeTown_HerbShop_Text_1FE685, 2
+	msgbox LavaridgeTown_HerbShop_Text_1FE685, MSGBOX_NPC
 	end
 
 LavaridgeTown_HerbShop_EventScript_1FE505:: @ 81FE505
@@ -30,7 +30,7 @@ LavaridgeTown_HerbShop_EventScript_1FE505:: @ 81FE505
 	faceplayer
 	checkflag FLAG_0x0FE
 	goto_eq LavaridgeTown_HerbShop_EventScript_1FE534
-	msgbox LavaridgeTown_HerbShop_Text_1FE584, 4
+	msgbox LavaridgeTown_HerbShop_Text_1FE584, MSGBOX_DEFAULT
 	giveitem_std ITEM_CHARCOAL
 	compare VAR_RESULT, 0
 	goto_eq LavaridgeTown_HerbShop_EventScript_272054
@@ -39,7 +39,7 @@ LavaridgeTown_HerbShop_EventScript_1FE505:: @ 81FE505
 	end
 
 LavaridgeTown_HerbShop_EventScript_1FE534:: @ 81FE534
-	msgbox LavaridgeTown_HerbShop_Text_1FE5EB, 4
+	msgbox LavaridgeTown_HerbShop_Text_1FE5EB, MSGBOX_DEFAULT
 	release
 	end