dionmoustos/PokemonEmeraldSafariFrontier
1
0
Fork 0
Code Issues 21 Pull Requests Actions Packages Projects Releases Wiki Activity

adds constants, cleans up callstd and msgbox code

Browse Source 
* adds some constants for standard script names and messagebox types
* replaces some callstd calls with msgbox calls where equivalent
* replaces msgbox and callstd calls using raw digits with versions that use the constants
This commit is contained in:
Melody
2018-12-02 03:37:46 -05:00
parent 145047d438
commit c557ac61ae
354 changed files with 4538 additions and 4531 deletions
Download Patch File Download Diff File Expand all files Collapse all files
data/maps/LittlerootTown_MaysHouse_1F/scripts.inc
+8 -8
View File
@@ -60,7 +60,7 @@ LittlerootTown_MaysHouse_1F_MapScript2_1F893A: @ 81F893A
LittlerootTown_MaysHouse_1F_EventScript_1F8964:: @ 81F8964
lockall
msgbox LittlerootTown_MaysHouse_1F_Text_1F7B67, 4
msgbox LittlerootTown_MaysHouse_1F_Text_1F7B67, MSGBOX_DEFAULT
closemessage
applymovement 255, LittlerootTown_MaysHouse_1F_Movement_1F898A
applymovement 1, LittlerootTown_MaysHouse_1F_Movement_1F898A
@@ -99,7 +99,7 @@ LittlerootTown_MaysHouse_1F_EventScript_1F89AE:: @ 81F89AE
applymovement 4, LittlerootTown_MaysHouse_1F_Movement_1F89EC
waitmovement 0
special GetRivalSonDaughterString
msgbox LittlerootTown_MaysHouse_1F_Text_1F8BC5, 4
msgbox LittlerootTown_MaysHouse_1F_Text_1F8BC5, MSGBOX_DEFAULT
setflag FLAG_0x057
setvar VAR_0x408C, 2
releaseall
@@ -125,22 +125,22 @@ LittlerootTown_MaysHouse_1F_EventScript_1F89F3:: @ 81F89F3
compare VAR_0x408D, 3
goto_eq LittlerootTown_BrendansHouse_1F_EventScript_1F8A1F
special GetRivalSonDaughterString
msgbox LittlerootTown_BrendansHouse_1F_Text_1F8CA5, 4
msgbox LittlerootTown_BrendansHouse_1F_Text_1F8CA5, MSGBOX_DEFAULT
release
end
LittlerootTown_BrendansHouse_1F_EventScript_1F8A1F:: @ 81F8A1F
msgbox LittlerootTown_BrendansHouse_1F_Text_1F8D37, 4
msgbox LittlerootTown_BrendansHouse_1F_Text_1F8D37, MSGBOX_DEFAULT
release
end
LittlerootTown_BrendansHouse_1F_EventScript_1F8A29:: @ 81F8A29
msgbox LittlerootTown_BrendansHouse_1F_Text_1F8D93, 4
msgbox LittlerootTown_BrendansHouse_1F_Text_1F8D93, MSGBOX_DEFAULT
release
end
LittlerootTown_BrendansHouse_1F_EventScript_1F8A33:: @ 81F8A33
msgbox LittlerootTown_BrendansHouse_1F_Text_1F8E01, 4
msgbox LittlerootTown_BrendansHouse_1F_Text_1F8E01, MSGBOX_DEFAULT
release
end
@@ -149,7 +149,7 @@ LittlerootTown_MaysHouse_1F_EventScript_1F8A3D:: @ 81F8A3D
lock
faceplayer
special GetPlayerBigGuyGirlString
msgbox LittlerootTown_BrendansHouse_1F_Text_1F9262, 4
msgbox LittlerootTown_BrendansHouse_1F_Text_1F9262, MSGBOX_DEFAULT
release
end
@@ -199,7 +199,7 @@ LittlerootTown_MaysHouse_1F_EventScript_1F8A8B:: @ 81F8A8B
call_if 1, LittlerootTown_MaysHouse_1F_EventScript_1F8B40
compare VAR_0x8008, 2
call_if 1, LittlerootTown_MaysHouse_1F_EventScript_1F8B4B
msgbox LittlerootTown_MaysHouse_1F_Text_1F8EC6, 4
msgbox LittlerootTown_MaysHouse_1F_Text_1F8EC6, MSGBOX_DEFAULT
closemessage
compare VAR_0x8008, 0
call_if 1, LittlerootTown_MaysHouse_1F_EventScript_1F8B6A