dionmoustos/PokemonEmeraldSafariFrontier
1
0
Fork 0
Code Issues 21 Pull Requests Actions Packages Projects Releases Wiki Activity

adds constants, cleans up callstd and msgbox code

Browse Source 
* adds some constants for standard script names and messagebox types
* replaces some callstd calls with msgbox calls where equivalent
* replaces msgbox and callstd calls using raw digits with versions that use the constants
This commit is contained in:
Melody
2018-12-02 03:37:46 -05:00
parent 145047d438
commit c557ac61ae
354 changed files with 4538 additions and 4531 deletions
Download Patch File Download Diff File Expand all files Collapse all files
data/maps/PacifidlogTown_House2/scripts.inc
+13 -13
View File
@@ -31,12 +31,12 @@ PacifidlogTown_House2_EventScript_2037DE:: @ 82037DE
return
PacifidlogTown_House2_EventScript_2037F8:: @ 82037F8
msgbox PacifidlogTown_House2_Text_20395B, 4
msgbox PacifidlogTown_House2_Text_20395B, MSGBOX_DEFAULT
return
PacifidlogTown_House2_EventScript_203801:: @ 8203801
msgbox PacifidlogTown_House2_Text_2038C7, 4
msgbox PacifidlogTown_House2_Text_20395B, 4
msgbox PacifidlogTown_House2_Text_2038C7, MSGBOX_DEFAULT
msgbox PacifidlogTown_House2_Text_20395B, MSGBOX_DEFAULT
return
PacifidlogTown_House2_EventScript_203812:: @ 8203812
@@ -44,36 +44,36 @@ PacifidlogTown_House2_EventScript_203812:: @ 8203812
return
PacifidlogTown_House2_EventScript_203816:: @ 8203816
msgbox PacifidlogTown_House2_Text_20396D, 4
msgbox PacifidlogTown_House2_Text_20396D, MSGBOX_DEFAULT
giveitem_std ITEM_TM27
compare VAR_RESULT, 0
goto_eq PacifidlogTown_House2_EventScript_272054
setflag FLAG_0x12B
special SetPacifidlogTMReceivedDay
msgbox PacifidlogTown_House2_Text_203A85, 4
msgbox PacifidlogTown_House2_Text_203A85, MSGBOX_DEFAULT
release
end
PacifidlogTown_House2_EventScript_203845:: @ 8203845
msgbox PacifidlogTown_House2_Text_2039CE, 4
msgbox PacifidlogTown_House2_Text_2039CE, MSGBOX_DEFAULT
release
end
PacifidlogTown_House2_EventScript_20384F:: @ 820384F
msgbox PacifidlogTown_House2_Text_203A2F, 4
msgbox PacifidlogTown_House2_Text_203A2F, MSGBOX_DEFAULT
giveitem_std ITEM_TM21
compare VAR_RESULT, 0
goto_eq PacifidlogTown_House2_EventScript_272054
setflag FLAG_0x12B
special SetPacifidlogTMReceivedDay
msgbox PacifidlogTown_House2_Text_203A85, 4
msgbox PacifidlogTown_House2_Text_203A85, MSGBOX_DEFAULT
release
end
PacifidlogTown_House2_EventScript_20387E:: @ 820387E
specialvar VAR_RESULT, GetDaysUntilPacifidlogTMAvailable
buffernumberstring 0, VAR_RESULT
msgbox PacifidlogTown_House2_Text_203AF4, 4
msgbox PacifidlogTown_House2_Text_203AF4, MSGBOX_DEFAULT
release
end
@@ -82,9 +82,9 @@ PacifidlogTown_House2_EventScript_203891:: @ 8203891
faceplayer
waitse
playmoncry SPECIES_AZURILL, 0
msgbox PacifidlogTown_House2_Text_203B8D, 4
msgbox PacifidlogTown_House2_Text_203B8D, MSGBOX_DEFAULT
waitmoncry
msgbox PacifidlogTown_House2_Text_203B9D, 4
msgbox PacifidlogTown_House2_Text_203B9D, MSGBOX_DEFAULT
release
end
@@ -93,9 +93,9 @@ PacifidlogTown_House2_EventScript_2038AC:: @ 82038AC
faceplayer
waitse
playmoncry SPECIES_AZURILL, 2
msgbox PacifidlogTown_House2_Text_203BCE, 4
msgbox PacifidlogTown_House2_Text_203BCE, MSGBOX_DEFAULT
waitmoncry
msgbox PacifidlogTown_House2_Text_203BDF, 4
msgbox PacifidlogTown_House2_Text_203BDF, MSGBOX_DEFAULT
release
end