dionmoustos/PokemonEmeraldSafariFrontier
1
0
Fork 0
Code Issues 21 Pull Requests Actions Packages Projects Releases Wiki Activity

adds constants, cleans up callstd and msgbox code

Browse Source 
* adds some constants for standard script names and messagebox types
* replaces some callstd calls with msgbox calls where equivalent
* replaces msgbox and callstd calls using raw digits with versions that use the constants
This commit is contained in:
Melody
2018-12-02 03:37:46 -05:00
parent 145047d438
commit c557ac61ae
354 changed files with 4538 additions and 4531 deletions
Download Patch File Download Diff File Expand all files Collapse all files
data/maps/SeafloorCavern_Room9/scripts.inc
+14 -14
View File
@@ -12,27 +12,27 @@ SeafloorCavern_Room9_EventScript_234DC9:: @ 8234DC9
applymovement 255, SeafloorCavern_Room9_Movement_23505C
waitmovement 0
playbgm MUS_AQA_0, 0
msgbox SeafloorCavern_Room9_Text_23505F, 4
msgbox SeafloorCavern_Room9_Text_23505F, MSGBOX_DEFAULT
closemessage
addobject VAR_0x8004
applymovement 255, SeafloorCavern_Room9_Movement_2725A4
waitmovement 0
applymovement VAR_0x8004, SeafloorCavern_Room9_Movement_23502A
waitmovement 0
msgbox SeafloorCavern_Room9_Text_23507C, 4
msgbox SeafloorCavern_Room9_Text_23507C, MSGBOX_DEFAULT
applymovement VAR_0x8004, SeafloorCavern_Room9_Movement_2725A6
waitmovement 0
msgbox SeafloorCavern_Room9_Text_2350A6, 4
msgbox SeafloorCavern_Room9_Text_2350A6, MSGBOX_DEFAULT
applymovement VAR_0x8004, SeafloorCavern_Room9_Movement_27259E
waitmovement 0
msgbox SeafloorCavern_Room9_Text_23512C, 4
msgbox SeafloorCavern_Room9_Text_23512C, MSGBOX_DEFAULT
trainerbattle 3, TRAINER_ARCHIE, 0, SeafloorCavern_Room9_Text_2351BC
msgbox SeafloorCavern_Room9_Text_2351E5, 4
msgbox SeafloorCavern_Room9_Text_2351E5, MSGBOX_DEFAULT
setweather 0
doweather
special sub_80B05B4
waitstate
msgbox SeafloorCavern_Room9_Text_235279, 4
msgbox SeafloorCavern_Room9_Text_235279, MSGBOX_DEFAULT
special WaitWeather
waitstate
setvar VAR_RESULT, 1
@@ -80,21 +80,21 @@ SeafloorCavern_Room9_EventScript_234DC9:: @ 8234DC9
setvar VAR_0x8005, 3
setvar VAR_0x8006, 4
setvar VAR_0x8007, 5
msgbox SeafloorCavern_Room9_Text_2352A7, 4
msgbox SeafloorCavern_Room9_Text_2352A7, MSGBOX_DEFAULT
playse SE_PC_LOGIN
applymovement 255, SeafloorCavern_Room9_Movement_2725A4
waitmovement 0
msgbox SeafloorCavern_Room9_Text_2352F6, 4
msgbox SeafloorCavern_Room9_Text_2352F6, MSGBOX_DEFAULT
closemessage
applymovement VAR_0x8004, SeafloorCavern_Room9_Movement_235035
waitmovement 0
msgbox SeafloorCavern_Room9_Text_23532B, 4
msgbox SeafloorCavern_Room9_Text_23532B, MSGBOX_DEFAULT
closemessage
playse SE_PC_OFF
delay 20
applymovement VAR_0x8004, SeafloorCavern_Room9_Movement_2725AA
waitmovement 0
msgbox SeafloorCavern_Room9_Text_23546F, 4
msgbox SeafloorCavern_Room9_Text_23546F, MSGBOX_DEFAULT
closemessage
addobject VAR_0x8005
addobject VAR_0x8006
@@ -105,19 +105,19 @@ SeafloorCavern_Room9_EventScript_234DC9:: @ 8234DC9
waitmovement 0
applymovement VAR_0x8004, SeafloorCavern_Room9_Movement_2725A4
waitmovement 0
msgbox SeafloorCavern_Room9_Text_2354F0, 4
msgbox SeafloorCavern_Room9_Text_2354F0, MSGBOX_DEFAULT
playse SE_PIN
applymovement VAR_0x8004, SeafloorCavern_Room9_Movement_272598
waitmovement 0
applymovement VAR_0x8004, SeafloorCavern_Room9_Movement_27259A
waitmovement 0
msgbox SeafloorCavern_Room9_Text_2355C2, 4
msgbox SeafloorCavern_Room9_Text_235692, 4
msgbox SeafloorCavern_Room9_Text_2355C2, MSGBOX_DEFAULT
msgbox SeafloorCavern_Room9_Text_235692, MSGBOX_DEFAULT
closemessage
applymovement VAR_0x8005, SeafloorCavern_Room9_Movement_235054
applymovement VAR_0x8004, SeafloorCavern_Room9_Movement_23503A
waitmovement 0
msgbox SeafloorCavern_Room9_Text_235723, 4
msgbox SeafloorCavern_Room9_Text_235723, MSGBOX_DEFAULT
setvar VAR_0x407B, 1
setvar VAR_0x405E, 1
clearflag FLAG_HIDE_SOOTOPOLIS_CITY_STEVEN