dionmoustos/PokemonEmeraldSafariFrontier
1
0
Fork 0
Code Issues 21 Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed ChangeBgY_ScreenOff‘s signature. (#1447)

Browse Source 
* Fix Functions

* Fix ChangeBgY_ScreenOff signature

* Remove unneeded changes

* Fix argument mismatch

Just to get this out of the way

* Not needed

* Update palette.c
This commit is contained in:
gAlfonso-bit
2021-05-27 08:32:09 -04:00
committed by GitHub
parent 2b062e89c1
commit c9c5586068
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
gflib/bg.c
+5 -5
View File
@@ -246,17 +246,17 @@ static void SetBgAffineInternal(u8 bg, s32 srcCenterX, s32 srcCenterY, s16 dispC
switch (sGpuBgConfigs.bgVisibilityAndMode & 0x7) switch (sGpuBgConfigs.bgVisibilityAndMode & 0x7)
{ {
default:
case 0:
return;
case 1: case 1:
if (bg != 2) if (bg != 2)
return; return;
break; break;
case 2: case 2:
if (bg < 2 || bg >= NUM_BACKGROUNDS) if (bg != 2 && bg != 3)
return; return;
break; break;
case 0:
default:
return;
} }
src.texX = srcCenterX; src.texX = srcCenterX;
@@ -689,7 +689,7 @@ s32 ChangeBgY(u8 bg, s32 value, u8 op)
return sGpuBgConfigs2[bg].bg_y; return sGpuBgConfigs2[bg].bg_y;
} }
s32 ChangeBgY_ScreenOff(u8 bg, u32 value, u8 op) s32 ChangeBgY_ScreenOff(u8 bg, s32 value, u8 op)
{ {
u8 mode; u8 mode;
u16 temp1; u16 temp1;
gflib/bg.h
+1 -1
View File
@@ -59,7 +59,7 @@ u16 GetBgAttribute(u8 bg, u8 attributeId);
s32 ChangeBgX(u8 bg, s32 value, u8 op); s32 ChangeBgX(u8 bg, s32 value, u8 op);
s32 GetBgX(u8 bg); s32 GetBgX(u8 bg);
s32 ChangeBgY(u8 bg, s32 value, u8 op); s32 ChangeBgY(u8 bg, s32 value, u8 op);
s32 ChangeBgY_ScreenOff(u8 bg, u32 value, u8 op); s32 ChangeBgY_ScreenOff(u8 bg, s32 value, u8 op);
s32 GetBgY(u8 bg); s32 GetBgY(u8 bg);
void SetBgAffine(u8 bg, s32 srcCenterX, s32 srcCenterY, s16 dispCenterX, s16 dispCenterY, s16 scaleX, s16 scaleY, u16 rotationAngle); void SetBgAffine(u8 bg, s32 srcCenterX, s32 srcCenterY, s16 dispCenterX, s16 dispCenterY, s16 scaleX, s16 scaleY, u16 rotationAngle);
u8 Unused_AdjustBgMosaic(u8 a1, u8 a2); u8 Unused_AdjustBgMosaic(u8 a1, u8 a2);
src/battle_factory.c
+1 -1
View File
@@ -38,7 +38,7 @@ static void GenerateInitialRentalMons(void);
static void GetOpponentMostCommonMonType(void); static void GetOpponentMostCommonMonType(void);
static void GetOpponentBattleStyle(void); static void GetOpponentBattleStyle(void);
static void RestorePlayerPartyHeldItems(void); static void RestorePlayerPartyHeldItems(void);
static u16 GetFactoryMonId(u8 lvlMode, u8 challengeNum, bool8 arg2); static u16 GetFactoryMonId(u8 lvlMode, u8 challengeNum, bool8 useBetterRange);
static u8 GetMoveBattleStyle(u16 move); static u8 GetMoveBattleStyle(u16 move);
// Number of moves needed on the team to be considered using a certain battle style // Number of moves needed on the team to be considered using a certain battle style