c0bc7e8f7b
Fix elevator metatile typo
2020-07-06 16:02:49 -04:00
3264cf697f
fix aggressive loop optimizations
...
Previously, aggressive loop optimizations with a new compiler were not
possible due to undefined behaviour at end of arrays.
A macro "UBFIX" is added to allow ifdefs for fixes which resolve
undefined behavior. For example newer GCC versions will detect various
bugs in the original game code and will otherwise not compile with -Werror.
2020-07-05 18:09:59 +02:00
72edc46ab6
Document unk_transition
2020-07-02 15:45:37 -04:00
1ce929157f
Clean up field effect doc
2020-07-02 05:05:13 -04:00
8589e138a8
Eliminate METATILE_ID() macro
2020-07-02 00:17:14 -04:00
c84f98a7ff
Document misc field control
2020-06-29 17:24:17 -04:00
abdf7cbf02
Label fishing effect functions
2020-06-29 16:53:38 -04:00
eb80012757
Document more misc field effects
2020-06-29 16:32:46 -04:00
a35ab0d023
Fix segfault in gbagfx
2020-06-29 15:28:59 -04:00
4ea6992172
Continue documenting overworld/field effects
2020-06-29 01:26:29 -04:00
7d5ad8f7b4
Use charmap constants for PLAY_SE
2020-06-26 02:44:07 -04:00
2ed1f7c6f9
Byte-align daily flags
2020-06-24 18:05:22 -04:00
06025e887f
Allow flag/var counts to be updated alongside values
2020-06-24 17:00:19 -04:00
a88676094b
Add missed deoxys rock local id
2020-06-23 15:51:23 -04:00
18d57a3802
Document some overworld and field effects
2020-06-23 15:48:53 -04:00
fac6288156
Add local object event ids for referenced objects
2020-06-22 17:18:58 -04:00
7244b80fc6
Created constant for easier Ball Expansion.
2020-06-21 02:36:46 -04:00
8b462f3f6c
Specify confetti util name
2020-06-18 18:14:30 -04:00
d2a760afdb
Rename contest_link_80FC4F4, 80F57C4, and 81D9DE4
2020-06-18 18:01:32 -04:00
24569583e4
Document contest results
2020-06-18 17:50:13 -04:00
f600aff711
Rename rom_81520A8
2020-06-17 03:42:10 -04:00
76f6d05173
Document confetti
2020-06-17 03:39:03 -04:00
e507770425
Remove some unneeded link filler
2020-06-15 13:17:53 -04:00
4c8fd5af7c
Move Pokemon cries to own directory
2020-06-15 13:00:24 -04:00
c2a07276ae
Merge branch 'master' into doc-link
2020-06-13 16:15:11 -04:00
46f4a4bbf7
Merge pull request #1074 from Sierraffinity/item-menu-cleanup
...
Begin item_menu.c cleanup
2020-06-10 17:17:35 -07:00
a05eea9312
Merge pull request #1075 from Sierraffinity/master
...
Fix out of bounds array access in intro Groudon segment
2020-06-10 17:16:04 -07:00
a9a427c6f2
Merge branch 'master' into doc-link
2020-06-10 17:36:43 -04:00
2859900ea9
Second pass on documenting union room
2020-06-10 17:30:59 -04:00
452f1e0047
Fix out of bounds array access in intro Groudon segment
2020-06-10 13:27:46 -07:00
a7815857ad
Merge pull request #1071 from PokeCF/patch-3
...
Unnest if statements
2020-06-10 13:23:57 -07:00
74edaed426
Begin item_menu.c cleanup
2020-06-10 13:07:42 -07:00
70c5f923ad
Merge pull request #1072 from nullableVoidPtr/master
...
Match sub_80F0708
2020-06-10 09:23:38 -04:00
8381828571
Match sub_80F0708
...
Special thanks to @kazblox
2020-06-10 21:13:58 +08:00
760baec098
Unnest if statements
...
Overall, it is generally considered bad style to continually nest loops. However, if this is what the decompiler outputted, then why bother touching it?
However, this can be rewritten as returning early if the playtime is less than 60.
The reason for this is not because of the original code, but because it looks better, has the same output, and is easier to understand.
2020-06-08 17:09:54 -04:00
35867f531b
Some link rfu cleanup / link.c documentation
2020-06-08 15:24:25 -04:00
c98342c973
Document link_rfu_3.c
2020-06-08 00:28:21 -04:00
e6f5c4f264
Sync link_rfu_2.c
2020-06-07 12:54:50 -04:00
3f97763181
Document cable_club.c
2020-06-06 16:10:03 -04:00
675f5ac03e
Remove unnecessary comment
2020-06-03 19:55:15 -05:00
5d752bbe49
shop: document some constants s.t. object events don't break
2020-06-03 19:55:15 -05:00
aaf5d91c18
Document field_message_box.c
2020-06-03 19:47:45 -05:00
83336585e2
Merge pull request #1067 from DizzyEggg/transitions
...
Transitions
2020-06-03 19:45:04 -05:00
9190af73b7
Label union room battle trainer
2020-06-03 15:28:29 -04:00
fd77eb1eb9
Document wireless_communication_status_screen.c
2020-06-03 14:07:40 -04:00
bc6bd36813
Document union_room_battle.c
2020-06-02 19:05:59 -04:00
18a00da820
Split wireless_communication_status_screen.c out
2020-06-02 18:51:26 -04:00
7632404ba5
Document union_room_chat.c
2020-06-02 18:35:00 -04:00
0690abd5a4
its time to ddddddduel
2020-06-02 17:28:47 +02:00
754266cb0f
battle transitions
2020-06-02 13:32:30 +02:00
GriffinR