Commit Graph

5134 Commits

Author SHA1 Message Date
kaboissonneault 3122d744f5 Added BUGFIX for "dual non-immunity" glitch. In certain AI script commands, the call to TypeCalc does not assign effectiveness flags properly, resulting in the check for immunity always failing 2023-11-02 09:48:13 -04:00
LOuroboros d44b2a972d Renamed SendMonToPC to CopyMonToPC instead
"SendMonToPC" implies that the Pokémon affected is actually sent over to the PC, but in reality the function simply copies the data of the Pokémon and then pastes it in the first available slot of the Pokémon Storage System.
2023-10-31 04:36:46 -03:00
Bassoonian cd9ef3a566 Formatting fix 2023-10-28 16:34:11 +02:00
Bassoonian f472d768dd Rename Undiscovered to No Eggs Discovered 2023-10-28 16:32:55 +02:00
GriffinR c169b856d4 Merge pull request #1937 from kittenchilly/removewhitespace
Remove all trailing whitespace
2023-10-26 10:09:00 -04:00
Eduardo Quezada 25d6f8ba74 Fix mini_printf encoded string -Werror=pointer-sign warning 2023-10-26 09:25:50 -03:00
kittenchilly 333523e5f7 Remove all leading whitespace 2023-10-23 13:24:38 -05:00
GriffinR 5712777dc2 Correct dynamic type flag name 2023-10-20 12:57:36 -04:00
GriffinR ffdc2456cb Document datahpupdate 2023-10-20 12:50:32 -04:00
GriffinR f01a6afc98 Merge branch 'master' into misc-tasks 2023-10-07 17:25:20 -04:00
marlux895 0e84c7deb3 corrected comment, tough to smart 2023-10-07 17:23:52 -04:00
Thomas Winwood 054d0f9852 Remove fakematch in NewGameInitPCItems 2023-10-07 12:52:57 -04:00
GriffinR 6f71fbe521 Add some missing trainer hill constant usage 2023-10-06 15:17:55 -04:00
kaboissonneault 0a183c2027 Changed sFixedIVTable access from hardcoded index limits to ARRAY_COUNT 2023-10-05 08:26:34 -04:00
kaboissonneault 3a8a82d385 Fixed out-of-bounds access in GetFactoryMonFixedIV when generating player rentals in round 8 (if player has 15+ swaps) and in round 9 2023-10-04 09:18:02 -04:00
GriffinR 654b6380b1 Merge pull request #1926 from AsparagusEduardo/pret/pr2/EggWall
Solved a bunch of -Wall errors on modern
2023-10-01 11:57:30 -04:00
Eduardo Quezada b724cfc578 Review comment 2023-09-30 18:22:38 -03:00
kittenchilly cc30dc06d5 Add friendship evo threshold constant 2023-09-26 16:25:15 -05:00
GriffinR 3eb1fa6fcb Merge pull request #1925 from AsparagusEduardo/pret/pr2/dayNightConst
Slight RTC documentation + Evolution times constants
2023-09-26 15:01:37 -04:00
Kurausukun 6eb6282c89 add missing constant usage in m4a_1 2023-09-23 17:06:12 -04:00
Eduardo Quezada aff709a3cb Fixed dumb mistake 2023-09-22 14:17:23 -03:00
Eduardo Quezada 03a1e7779b Null dereferencing fix 2023-09-22 11:23:27 -03:00
Eduardo Quezada a56eb4f53f Review changes. 2023-09-22 11:19:00 -03:00
Eduardo Quezada 927e4b6071 Renamed time amounts 2023-09-20 19:04:50 -03:00
Eduardo Quezada af210da972 Solved a bunch of -Wall errors on modern 2023-09-20 19:01:08 -03:00
Eduardo Quezada fb6f45b2c3 Slight RTC documentation + Evolution times constants 2023-09-17 13:45:06 -03:00
sbird 4ed4b69019 [BUGFIX] for abilities affecting wild encounter tables
fixes a potential buffer overread in TryGetAbilityInfluencedWildMonIndex.
The bug can occur if an electric type mon is in the first slots of a fishing
encounter table and the player carries a mon with the `ABILITY_STATIC` ability.
This never happens in the vanilla codebase.
2023-09-15 19:11:25 +02:00
Eduardo Quezada b89722500f Fixed Mr. Mime capitalization 2023-09-12 13:09:56 -03:00
GriffinR d67914e114 Merge pull request #1912 from GriffinRichards/moves-mask
Handful of fixes related to MAX_MON_MOVES
2023-08-27 19:40:59 -04:00
GriffinR 56ff4ce998 Add defines for field effect sprite data, misc task data 2023-08-20 17:45:58 -04:00
GriffinR e70577d59b Add missing sizeof in trainer_see 2023-08-20 17:22:29 -04:00
GriffinR 4941e2602a Merge pull request #1909 from GriffinRichards/stat-anim
Document stat change animation
2023-08-20 14:29:11 -04:00
GriffinR 6792028254 Document title screen task data 2023-08-20 01:18:44 -04:00
GriffinR 5beec06d9d Document Task_MapNamePopUpWindow 2023-08-19 17:20:53 -04:00
GriffinR bdc0ea1037 Add MOD to match mod with powers of 2 2023-08-16 16:44:45 -04:00
GriffinR 057928438a Document ChooseMoveAndTargetInBattlePalace 2023-08-16 16:41:29 -04:00
GriffinR aca7998b93 Add missing use of ALL_MOVES_MASK 2023-08-16 14:33:15 -04:00
GriffinR 10a10e914b Merge pull request #1910 from GriffinRichards/misc-constants
Use miscellaneous missing constants
2023-08-15 17:53:41 -04:00
GriffinR 4c2b12541b Merge pull request #1908 from GriffinRichards/name-buffer
Automatically update nickname buffer sizes
2023-08-12 23:36:19 -04:00
GriffinR 344fe4dd65 Stop double-counting EOS in assert 2023-08-12 23:13:11 -04:00
GriffinR b248791f47 Merge pull request #1904 from GriffinRichards/temp-alias
Add temp flag and var aliases
2023-08-11 15:45:00 -04:00
GriffinR 60a6c9d160 Merge pull request #1903 from GriffinRichards/frontier-gfx
Fix some frontier gfx, adjacent cleanup
2023-08-10 14:49:44 -04:00
GriffinR d5d46bb438 More DISPLAY_WIDTH/HEIGHT constant usage 2023-08-10 01:42:38 -04:00
GriffinR 18319e8da3 Misc missing constant use 2023-08-10 01:42:18 -04:00
GriffinR 079f2da0f6 Fix some missing constant use in Apprentice 2023-08-10 00:38:23 -04:00
GriffinR d1c2a30149 Merge pull request #1907 from GriffinRichards/fix-tv
Fix Bravo Trainer Tower member names
2023-08-09 15:25:45 -04:00
GriffinR 6eaaa50ad5 Correct berry fix graphics colors, more PLTT constant use (#1892) 2023-08-09 12:49:21 -04:00
Martin Griffin 912a80e27a Reference TMs and HMs by move instead of number (#1732) 2023-08-09 10:51:01 -04:00
GriffinR 6598cb30bc Document stat change animation 2023-08-08 23:56:16 -04:00
GriffinR 65fee186f8 Automatically update nickname buffer sizes 2023-08-08 16:28:09 -04:00