Commit Graph

70 Commits

Author SHA1 Message Date
DavidJCobb 7fd0029ed7 Add typedefs for MAPSEC and METLOC values (#2183)
Added typedefs: mapsec_t, metloc_t, and variants for MAPSEC and METLOC values. There are some rough edges that could do with smoothing out, but for now, this gets us close to ideal with a ROM that compares equal.

Per feedback, all typedefs to mention the underlying type within the typedef name. The documentation comments reflect and explain the naming convention.

Updated comments to reflect the fact that we're no longer using SET8 for a Pokemon's met locations, in favor of a new macro (added by this PR) that adjusts to match the width of whatever is being set.
2025-10-19 17:37:13 +01:00
GriffinR 6f8a1bbdb8 Add pack/unpack for data masks (#2163) 2025-07-23 09:28:34 +01:00
cawtds 1672d99060 make linkDirection more robust to member reordering 2025-04-09 13:40:39 +02:00
GriffinR a3d5f54b75 Fix type for offset in MapConnection 2024-08-13 19:10:24 +02:00
GriffinR dbf757be88 Treat map data as const 2023-03-08 12:00:30 -05:00
GriffinR de56e400ff Sync clone object macro 2023-02-08 13:11:10 -05:00
Eduardo Quezada 66d1c9bc65 Documenting padding in structs used by Saveblocks 2022-12-17 22:55:43 -03:00
GriffinR 65d3944a93 Give tileset palettes proper type, name compressed secret base tiles 2022-10-08 02:02:12 -04:00
GriffinR 4f407a1066 Convert tilesets.s to C 2022-09-27 17:23:26 -04:00
GriffinR 03a98c72bc Sync fieldmap 2022-09-02 19:29:35 -04:00
GriffinR 7d2344c07b Merge pull request #1616 from GriffinRichards/missing-req
Add missing :req, remove old macros
2022-02-02 22:09:36 -05:00
GriffinR 2495d18132 Add missing :req, remove old macros 2022-01-23 18:52:04 -05:00
GriffinR fb81d9ad4a Correct map data comment 2022-01-20 23:26:39 -05:00
GriffinR a8b466dc80 Disambiguate fieldmap names 2022-01-19 10:15:32 -05:00
GriffinR f127e64a3c Name overworld tilemaps for their bg, add layer type constants 2022-01-19 09:37:12 -05:00
GriffinR afb9ff3a40 Document files with a few remaining symbols 2021-11-02 18:06:06 -04:00
cbt6 b3d779fd0d Document field player functions 2021-10-27 01:39:00 +08:00
sphericalice 7b5267c799 Rename TILESET_WIDTH to METATILE_ROW_WIDTH 2021-10-25 20:51:04 +01:00
sphericalice 5bce17cbce Fix typo in the TILESET_WIDTH comment 2021-10-25 18:11:06 +01:00
sphericalice 120e75d275 Document the CloseBattlePikeCurtain special 2021-10-25 18:03:14 +01:00
LOuroboros 554210c5e3 Removed trailing spaces in the most relevant files
Command used for the job:
egrep -rl ' $' --include *.c --include *.h --include  *.s --include  *.inc --include  *.txt *  | xargs sed -i 's/\s\+$//g'

Credits to Grant Murphy from Stack Overflow.
2021-08-24 19:59:32 -03:00
ExpoSeed b6b0062bd6 Change map header flags to use a bitfield 2021-06-13 17:02:06 -05:00
GriffinR 86a9d94ce1 Document fieldmap 2021-04-06 16:05:43 -04:00
Kurausukun 58976ebaa8 Merge remote-tracking branch 'upstream/master' into berry_crush 2020-12-10 23:30:52 -05:00
GriffinR bf65c1fb25 Name object event pals/tags 2020-11-23 14:24:48 -05:00
Kaz 1404cf3330 field_player_avatar.c: Fix TryInterruptObjectEventSpecialAnim fakematch. 2020-09-17 18:24:11 -04:00
GriffinR 18d57a3802 Document some overworld and field effects 2020-06-23 15:48:53 -04:00
GriffinR 5bb688df3e Label in_connection's field in ObjectEventTemplate 2020-05-14 17:11:18 -04:00
GriffinR b1d26e10a8 Sync map header property names with pokefirered 2020-04-28 19:59:08 -05:00
GriffinR 487080b425 Minor player avatar doc 2020-04-01 02:54:26 -04:00
GriffinR ef67f2d33b Merge master into ObjEvent rename and prune accidental inclusions 2020-01-08 05:43:06 -05:00
GriffinR 8da7a94423 Merge branch 'master' into fix-eventobj 2019-12-10 17:41:08 -05:00
jiangzhengwenjz f34b8f564a InitEventObjectStateFromTemplate 2019-12-11 05:35:40 +08:00
GriffinR 82cb741d8b Standardize EVENT_OBJECT to OBJECT_EVENT 2019-11-20 23:12:51 -05:00
GriffinR ec3e86f1d2 Standardize Event Object to Object Event 2019-11-20 22:55:44 -05:00
Marcus Huderle 4494b5d4cb Document collision types 2019-10-06 15:48:26 -05:00
Marcus Huderle 799edaf3e6 Document hide/show reflection movement actions 2019-10-06 14:17:34 -05:00
GriffinR a46f7952f9 Use DIR constants for createvobject
Also uses event object ids in LinkContestRoom1
2019-08-21 17:11:06 -05:00
garak f1f420954b add METATILE_ID macro 2019-06-16 10:08:07 -05:00
PikalaxALT 1fe5208560 through sub_801A02C 2019-04-01 12:05:58 -04:00
Phlosioneer da0687987d Pick better names for constants 2019-02-28 22:21:16 -06:00
Phlosioneer 189d387f01 Add macros for metatile manipulation 2019-02-28 22:21:16 -06:00
Deokishisu 447fec26dc Consolidate unused escapeRope MapHeader field into filler_18 field 2018-12-30 19:59:57 -05:00
nullableVoidPtr f24584cd31 Tabs -> spaces & align in include/ 2018-12-07 21:01:59 +08:00
nullableVoidPtr 556bdd52e1 Clean up aligned variables in src/ 2018-11-27 19:37:29 +08:00
Slawter666 3d8874d919 Merge branch 'master' of https://github.com/pret/pokeemerald into synchronise 2018-10-21 00:20:09 +01:00
Diegoisawesome dd3689fdbf Finish porting/decompiling field_player_avatar 2018-10-19 00:05:54 -05:00
Slawter666 b7b1d609d0 More synchronisation 2018-10-17 13:52:26 +01:00
Diegoisawesome e75f0b4f80 Port/decompile field_control_avatar 2018-10-16 21:47:08 -05:00
Slawter666 1435c96b41 Further synchronisation 2018-10-17 01:11:44 +01:00