Commit Graph

4563 Commits

Author SHA1 Message Date
Tustin2121 a708caac6d Suggested changes from review 2019-08-17 13:32:26 -04:00
Tustin2121 1069adae46 Renaming unknown link room ids to be the same as name
This descrepency was causing a lot of annoyance when using porymap, because porymap generated the ids in map_groups.h from the name, and mapjson was generating map_groups.h from the id in the json files. So just name them the same already like every other map in the repo.
2019-08-17 13:26:57 -04:00
Tustin2121 d12a8c10ee Documenting credits a bit 2019-08-17 13:26:44 -04:00
Tustin2121 bac8974ce3 Added note about addvar
The contest scripts actually use addvar to add a -1 to a variable instead of using subvar to subtract a positive number. This is fine in vanilla, where addvar script command does NOT support adding the value of a variable to another variable (like subvar supports), but should anyone want to change it, contests will be inexplicably broken.
2019-08-17 13:26:31 -04:00
Tustin2121 f4d4424618 Folded nops into hidemoneybox and updatemoneybox
The nops are essential to the hidemoneybox and updatemoneybox commands when using vanilla versions of those commands. Even though they're not actually used parameters in the command implementation, they are still consumed, which means if someone were to get rid of the nops (as I did in TriHard) it causes the commands to consume bytecode that are not theirs, resulting in undefined behavior usually leading to softlocks. Folding the extra bytes into the macros means there's no chance of the extra bytes getting losts in scripts.
2019-08-17 13:25:36 -04:00
Tustin2121 9bcd39d86c Document the braille window id. 2019-08-17 13:20:18 -04:00
Tustin2121 6508469259 Rename movobjectoffscreen to copyobjectxytoperm
Renaming the command to something that makes more sense as to what the command actually does. The command copies the current xy of the instantiated object back to its template, so that the object remains in the same place if the player walks away and despawns the object, and then comes back. "moveobjectoffscreen" implies that it might be taking the object and moving it physically to an off-screen location somehow.
2019-08-17 13:18:56 -04:00
Tustin2121 ea724278b7 Juan text buffer overflow note 2019-08-17 13:05:55 -04:00
PikalaxALT 4663564e02 Merge pull request #775 from DizzyEggg/patch-9
Fix modern
2019-08-17 05:17:05 -04:00
GriffinR 3c2576d3a3 trainer rematch macro 2019-08-16 13:48:45 -04:00
PikalaxALT 4541b959b6 Deprecate build_tools.sh 2019-08-15 15:17:13 -04:00
DizzyEggg 08fe3b21ed Fix modern
Fixes freeze on entering Pokemon Storage System
2019-08-12 11:43:31 +02:00
PikalaxALT ca8048c300 Merge pull request #771 from aaaaaa123456789/master
Fix Makefiles to account for the $CC and $CXX environment variables
2019-08-06 20:16:36 -04:00
aaaaaa123456789 e28cf5406b Fix Makefiles to account for the $CC and $CXX environment variables 2019-08-06 20:30:57 -03:00
PikalaxALT 2a0517f0fd Report data decomp in calcrom 2019-08-06 13:00:03 -04:00
PikalaxALT 1bda9ef2f6 Merge pull request #769 from PikalaxALT/pokenav_unk_9
Pokenav unk 9
2019-08-06 12:49:03 -04:00
PikalaxALT 37d23230fa Address review comments 2019-08-06 09:26:55 -04:00
PikalaxALT 1cff6672cf fix s32/int type mismatch on modern 2019-08-06 09:13:19 -04:00
PikalaxALT 5040a5f96b Move pokenav syms around 2019-08-05 20:23:56 -04:00
PikalaxALT b05df0377e Finish pokenav_unk_9 2019-08-05 17:17:05 -04:00
PikalaxALT 1f62caae43 Some cleanup 2019-08-05 15:49:05 -04:00
PikalaxALT 195137b001 Merge pull request #768 from PikalaxALT/pokenav_unk_8
Finish pokenav_unk_8
2019-08-05 15:21:20 -04:00
PikalaxALT 5d07123354 Remove unnecessary casts 2019-08-05 14:32:30 -04:00
PikalaxALT a7eb4f9dd2 Make pokenav_unk_8 syms static, fix gcc-9 warnings 2019-08-05 14:00:38 -04:00
PikalaxALT e2e667d4b5 Finish pokenav_unk_8 2019-08-05 13:47:04 -04:00
PikalaxALT 330fc46df8 through sub_81CF3F8 2019-08-05 12:21:45 -04:00
PikalaxALT 9beeba8424 Merge pull request #764 from GriffinRichards/document-varnames
Document vars that are used and unnamed
2019-08-05 11:59:53 -04:00
GriffinR 191f74525d name unused route state vars 2019-08-05 11:50:29 -04:00
GriffinR c2bf668fdd rename town/city vars 2019-08-05 11:23:45 -04:00
PikalaxALT 18f29c566a through sub_81CF278 2019-08-05 10:54:56 -04:00
PikalaxALT f5e18718d9 Merge pull request #702 from PikalaxALT/pokenav_unk_2
Pokenav unk 2
2019-08-05 09:49:21 -04:00
PikalaxALT 463e1eb6b8 Name some fields in Pokenav2Struct 2019-08-05 09:17:21 -04:00
PikalaxALT 329670e16e Minor fixes 2019-08-05 08:46:52 -04:00
PikalaxALT a42e5c24e6 Use LT return defines 2019-08-05 08:40:03 -04:00
PikalaxALT 51d5ee771d Merge branch 'master' into pokenav_unk_2 2019-08-05 08:33:45 -04:00
PikalaxALT 1fc64b8582 Merge pull request #767 from DizzyEggg/pokenav_8
More pokenav
2019-08-05 08:21:36 -04:00
PikalaxALT ffc7a9be27 Fix build errors 2019-08-04 21:23:38 -04:00
PikalaxALT 483e5173c9 Merge pull request #696 from SatoMew/master
Make installation documentation more straightforward
2019-08-04 21:16:41 -04:00
PikalaxALT ff2166b8fe pokenav_unk_2: unclutter global namespace 2019-08-04 21:10:08 -04:00
PikalaxALT 299c3cf1dc Finish pokenav_unk_2 2019-08-04 20:39:36 -04:00
PikalaxALT 2dee42dbaf through sub_81CA474 2019-08-04 18:15:02 -04:00
SatoMew 667f0837e2 Merge branch 'master' into master 2019-08-04 20:35:38 +01:00
PikalaxALT cd876292d1 Merge branch 'master' into pokenav_unk_2 2019-08-04 15:35:35 -04:00
DizzyEggg c8cc39cb57 More pokemav, massive clean-up, seriously who the left the file in this state??? 2019-08-04 19:09:12 +02:00
PikalaxALT fa5bfc1627 Merge pull request #766 from DizzyEggg/pokenav_10
Decompile pokenav 10
2019-08-04 11:07:10 -04:00
PikalaxALT 41e1f9b224 Merge pull request #763 from DizzyEggg/patch-8
Fakematch sub_819A080
2019-08-04 11:05:17 -04:00
PikalaxALT 0e4c9fb2c4 Merge pull request #757 from DizzyEggg/pok_jump
Decompile pokemon jump + some non/fake matches
2019-08-04 11:04:31 -04:00
DizzyEggg 252df94bc1 Decompile pokenav 10 2019-08-04 13:53:00 +02:00
DizzyEggg bb7e5ecc19 Pokemon jump 2019-08-04 00:18:58 +02:00
DizzyEggg 1641579297 Merge branch 'master' into pok_jump 2019-08-04 00:02:13 +02:00