Merge pull request #396 from hjk321/storage-magic

Change embarassing magic numbers that should have been fixed a long time ago
This commit is contained in:
GriffinR
2021-02-22 11:26:52 -05:00
committed by GitHub
2 changed files with 6 additions and 5 deletions
+2 -2
View File
@@ -3646,7 +3646,7 @@ static u8 SendMonToPC(struct Pokemon* mon)
do
{
for (boxPos = 0; boxPos < 30; boxPos++)
for (boxPos = 0; boxPos < IN_BOX_COUNT; boxPos++)
{
struct BoxPokemon* checkingMon = GetBoxedMonPtr(boxNo, boxPos);
if (GetBoxMonData(checkingMon, MON_DATA_SPECIES, NULL) == SPECIES_NONE)
@@ -3663,7 +3663,7 @@ static u8 SendMonToPC(struct Pokemon* mon)
}
boxNo++;
if (boxNo == 14)
if (boxNo == TOTAL_BOXES_COUNT)
boxNo = 0;
} while (boxNo != StorageGetCurrentBox());