resolve review comments
This commit is contained in:
@@ -1663,7 +1663,7 @@ static void OakOldManHandleSuccessBallThrowAnim(void)
|
||||
{
|
||||
gBattleSpritesDataPtr->animationData->ballThrowCaseId = BALL_3_SHAKES_SUCCESS;
|
||||
gDoingBattleAnim = TRUE;
|
||||
InitAndLaunchSpecialAnimation(gActiveBattler, gActiveBattler, GetBattlerAtPosition(B_POSITION_OPPONENT_LEFT), B_ANIM_SP_4);
|
||||
InitAndLaunchSpecialAnimation(gActiveBattler, gActiveBattler, GetBattlerAtPosition(B_POSITION_OPPONENT_LEFT), B_ANIM_SAFARI_BALL_THROW);
|
||||
gBattlerControllerFuncs[gActiveBattler] = CompleteOnSpecialAnimDone;
|
||||
}
|
||||
|
||||
@@ -1673,7 +1673,7 @@ static void OakOldManHandleBallThrowAnim(void)
|
||||
|
||||
gBattleSpritesDataPtr->animationData->ballThrowCaseId = ballThrowCaseId;
|
||||
gDoingBattleAnim = TRUE;
|
||||
InitAndLaunchSpecialAnimation(gActiveBattler, gActiveBattler, GetBattlerAtPosition(B_POSITION_OPPONENT_LEFT), B_ANIM_SP_4);
|
||||
InitAndLaunchSpecialAnimation(gActiveBattler, gActiveBattler, GetBattlerAtPosition(B_POSITION_OPPONENT_LEFT), B_ANIM_SAFARI_BALL_THROW);
|
||||
gBattlerControllerFuncs[gActiveBattler] = CompleteOnSpecialAnimDone;
|
||||
}
|
||||
|
||||
|
||||
+2
-1
@@ -26,6 +26,7 @@
|
||||
#include "menu_indicators.h"
|
||||
#include "text_window.h"
|
||||
#include "fame_checker.h"
|
||||
#include "constants/trainers.h"
|
||||
|
||||
#define SPRITETAG_SELECTOR_CURSOR 1000
|
||||
#define SPRITETAG_QUESTION_MARK 1001
|
||||
@@ -878,7 +879,7 @@ static void FC_DestroyWindow(u8 windowId)
|
||||
|
||||
static u8 AdjustGiovanniIndexIfBeatenInGym(u8 a0)
|
||||
{
|
||||
if (HasTrainerBeenFought(0x15e) == TRUE)
|
||||
if (HasTrainerBeenFought(TRAINER_LEADER_GIOVANNI) == TRUE)
|
||||
{
|
||||
if (a0 == 9)
|
||||
return FAMECHECKER_GIOVANNI;
|
||||
|
||||
+1
-1
@@ -73,7 +73,7 @@ void CopyItemName(u16 itemId, u8 * dest)
|
||||
{
|
||||
if (itemId == ITEM_ENIGMA_BERRY)
|
||||
{
|
||||
StringCopy(dest, GetBerryInfo(43)->name);
|
||||
StringCopy(dest, GetBerryInfo(ITEM_TO_BERRY(ITEM_ENIGMA_BERRY))->name);
|
||||
StringAppend(dest, gUnknown_84162BD);
|
||||
}
|
||||
else
|
||||
|
||||
Reference in New Issue
Block a user