Review changes

This commit is contained in:
Eduardo Quezada
2022-09-04 21:23:24 -03:00
parent 9241dc6fe7
commit 7dcac240d4
3 changed files with 4 additions and 15 deletions
-4
View File
@@ -305,13 +305,9 @@ static void CompleteOnHealthbarDone(void)
SetHealthboxSpriteVisible(gHealthboxSpriteIds[gActiveBattler]); SetHealthboxSpriteVisible(gHealthboxSpriteIds[gActiveBattler]);
if (hpValue != -1) if (hpValue != -1)
{
UpdateHpTextInHealthbox(gHealthboxSpriteIds[gActiveBattler], hpValue, HP_CURRENT); UpdateHpTextInHealthbox(gHealthboxSpriteIds[gActiveBattler], hpValue, HP_CURRENT);
}
else else
{
LinkOpponentBufferExecCompleted(); LinkOpponentBufferExecCompleted();
}
} }
static void HideHealthboxAfterMonFaint(void) static void HideHealthboxAfterMonFaint(void)
+3 -10
View File
@@ -367,18 +367,12 @@ static void PrepareBufferDataTransfer(u8 bufferId, u8 *data, u16 size)
switch (bufferId) switch (bufferId)
{ {
case BUFFER_A: case BUFFER_A:
for (i = 0; i < size; i++) for (i = 0; i < size; data++, i++)
{
gBattleBufferA[gActiveBattler][i] = *data; gBattleBufferA[gActiveBattler][i] = *data;
data++;
}
break; break;
case BUFFER_B: case BUFFER_B:
for (i = 0; i < size; i++) for (i = 0; i < size; data++, i++)
{
gBattleBufferB[gActiveBattler][i] = *data; gBattleBufferB[gActiveBattler][i] = *data;
data++;
}
break; break;
} }
} }
@@ -508,8 +502,7 @@ static void Task_HandleSendLinkBuffersData(u8 taskId)
} }
break; break;
case 5: case 5:
gTasks[taskId].data[13]--; if (--gTasks[taskId].data[13] == 0)
if (gTasks[taskId].data[13] == 0)
{ {
gTasks[taskId].data[13] = 5; gTasks[taskId].data[13] = 5;
gTasks[taskId].data[11] = 3; gTasks[taskId].data[11] = 3;
+1 -1
View File
@@ -709,7 +709,7 @@ static void Task_StaticCountdown_Run(u8 taskId)
u16 packet[RFU_PACKET_SIZE]; u16 packet[RFU_PACKET_SIZE];
s16 *data = gTasks[taskId].data; s16 *data = gTasks[taskId].data;
if (gReceivedRemoteLinkPlayers != 0) if (gReceivedRemoteLinkPlayers)
{ {
// Read link timer // Read link timer
if (gRecvCmds[0][1] == LINKCMD_COUNTDOWN) if (gRecvCmds[0][1] == LINKCMD_COUNTDOWN)