dionmoustos/Pokemon-Firered
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

CopyValue functions should involve volatile accesses (#720)

Browse Source 
* CopyValue functions should involve volatile accesses

These are writing to specific registers in memory that are memory mapped to do things, so we cannot do any optimizations here regarding memory.

* match pokeemerald's style

---------

Co-authored-by: Marcus Huderle <huderlem@gmail.com>
This commit is contained in:
SiliconA-Z
2026-02-22 09:48:40 -05:00
committed by GitHub
parent 7cf14a8e9e
commit 7e3f822652
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/scanline_effect.c
+4 -4
View File
@@ -107,16 +107,16 @@ void ScanlineEffect_InitHBlankDmaTransfer(void)
static void CopyValue16Bit(void) static void CopyValue16Bit(void)
{ {
u16 *dest = (u16 *)gScanlineEffect.dmaDest; vu16 *dest = (vu16 *)gScanlineEffect.dmaDest;
u16 *src = (u16 *)&gScanlineEffectRegBuffers[gScanlineEffect.srcBuffer]; vu16 *src = (vu16 *)&gScanlineEffectRegBuffers[gScanlineEffect.srcBuffer];
*dest = *src; *dest = *src;
} }
static void CopyValue32Bit(void) static void CopyValue32Bit(void)
{ {
u32 *dest = (u32 *)gScanlineEffect.dmaDest; vu32 *dest = (vu32 *)gScanlineEffect.dmaDest;
u32 *src = (u32 *)&gScanlineEffectRegBuffers[gScanlineEffect.srcBuffer]; vu32 *src = (vu32 *)&gScanlineEffectRegBuffers[gScanlineEffect.srcBuffer];
*dest = *src; *dest = *src;
} }