Address review comments

This commit is contained in:
PikalaxALT
2020-01-17 11:06:59 -05:00
parent afbaa190a2
commit b786145272
3 changed files with 5 additions and 17 deletions
-7
View File
@@ -1,7 +0,0 @@
#include "constants/region_map.h"
#include "constants/flags.h"
#include "constants/moves.h"
.include "asm/macros.inc"
.include "constants/constants.inc"
.section .rodata
.align 2
+1 -1
View File
@@ -182,7 +182,7 @@ static bool16 VerifySectorWipe(u32 sector)
u16 i;
u32 *saveDataBuffer = (void *)&gSaveDataBuffer;
ReadFlash(sector0, 0, saveDataBuffer, 0x1000);
for (i = 0; i < 0x1000 / 4; i++, saveDataBuffer++)
for (i = 0; i < 0x1000 / sizeof(u32); i++, saveDataBuffer++)
{
if (*saveDataBuffer != 0)
return TRUE;
+4 -9
View File
@@ -16,7 +16,6 @@
.align 2
.include "src/link.o"
.space 8
.align 2
.include "src/battle_controllers.o"
.align 2
@@ -144,6 +143,7 @@ gUnknown_20386A4: @ 20386A4
gUnknown_20386A8: @ 20386A8
.space 0x4
.align 2
.include "src/battle_setup.o"
.align 2
.include "src/wild_encounter.o"
@@ -154,7 +154,6 @@ gFieldEffectArguments: @ 20386E0
.align 2
.include "src/scanline_effect.o"
.align 2
.include "src/option_menu.o"
.align 2
@@ -454,6 +453,7 @@ gUnknown_203B0E8: @ 203B0E8
.include "src/oak_speech.o"
.align 2
.include "src/tm_case.o"
.align 2
.include "src/menu_indicators.o"
gUnknown_203B140: @ 203B140
@@ -500,13 +500,8 @@ gUnknown_203B170: @ 203B170
.include "src/berry_pouch.o"
.align 2
.include "src/slot_machine.o"
sLocationHistory: @ 203F3A8
.space 0x6
sRoamerLocation: @ 203F3AE
.space 0x2
.align 2
.include "src/roamer.o"
.align 2
.include "src/mystery_gift_menu.o"
.align 2