Merge pull request #2137 from mrgriffin/pret-suspicious-setvar

Warn on suspicious setvar usages
This commit is contained in:
GriffinR
2025-05-15 17:21:00 -04:00
committed by GitHub

View File

@@ -145,7 +145,10 @@
.endm
@ Changes the value of destination to value.
.macro setvar destination:req, value:req
.macro setvar destination:req, value:req, warn=TRUE
.if \warn && ((\value >= VARS_START && \value <= VARS_END) || (\value >= SPECIAL_VARS_START && \value <= SPECIAL_VARS_END))
.warning "setvar with a value that might be a VAR_ constant; did you mean copyvar instead?"
.endif
.byte SCR_OP_SETVAR
.2byte \destination
.2byte \value