Commit Graph

150 Commits

Author SHA1 Message Date
Eduardo Quezada af210da972 Solved a bunch of -Wall errors on modern 2023-09-20 19:01:08 -03:00
GriffinR 36e6981ac0 Replace some & usage with % 2023-04-26 16:12:00 -04:00
GriffinR dbf757be88 Treat map data as const 2023-03-08 12:00:30 -05:00
GriffinR de56e400ff Sync clone object macro 2023-02-08 13:11:10 -05:00
GriffinR 0cc10a1ada Merge branch 'master' of https://github.com/pret/pokeemerald into ui-standardize 2023-01-18 11:07:12 -05:00
GriffinR a203c03eac Add bugfix to LoadObjectEventPalette 2023-01-18 10:33:39 -05:00
tustin2121 33f3a7c11a Adding FindObjectEventPaletteIndexByTag bugfix
The code in event_object_movement.c indicates that OBJ_EVENT_PAL_TAG_NONE was meant to be a sentinel for the bottom of each of the tables involving palettes in there. sObjectEventSpritePalettes is the exception, but the functions that access it look for OBJ_EVENT_PAL_TAG_NONE even though it's not in the table. If the palette tag isn't in the table, the functions which scan it fall off the bottom of the table into an infinite loop of scanning 256 "entries" of the table (because it uses a u8 index), and the game locks up. In vanilla, the search simply never falls off the bottom of the table. It seems the developers intended for that last entry to be {NULL, OBJ_EVENT_PAL_TAG_NONE}.
2022-11-07 06:09:21 -05:00
GriffinR 6db489e2d5 Use constants for overworld object palette slots 2022-09-27 20:16:48 -04:00
Eduardo Quezada 8a68596b64 Removed free macro 2022-09-16 20:36:44 -03:00
Eduardo Quezada 63156b4398 Removed malloc macro 2022-09-16 20:24:26 -03:00
Eduardo Quezada 65108c3192 Cleaned trailing whitespace 2022-09-11 14:14:49 -04:00
GriffinR 898ec580ae Merge pull request #1737 from GriffinRichards/lock-unlock
Clean up lock/unlock anim movement
2022-08-22 01:30:33 -04:00
Martin Griffin 6fed961ed6 Write palette IDs in hex 2022-08-19 15:29:35 +01:00
GriffinR 5515e328b2 Clean up lock/unlock anim movement 2022-08-12 21:18:10 -04:00
GriffinR e5c36cd745 MapGridIsImpassableAt -> MapGridGetCollisionAt, and add fixes 2022-08-03 14:21:13 -04:00
Eduardo Quezada 01558ff8f3 Struct pointers star standarizing 2022-07-29 11:15:33 -04:00
Eduardo Quezada 7b3401ee27 Standarized use of star in pointer types 2022-07-29 10:17:58 -04:00
GriffinR 1ca1bff81c Merge branch 'master' of https://github.com/GriffinRichards/pokeemerald into doc-arg 2022-06-03 15:43:21 -04:00
GriffinR 34438e6bc4 Continue documenting generic arguments 2022-06-03 15:38:03 -04:00
cbt6 6d6dac3add Use ARRAY_COUNT in sStepTimes for step functions 2022-05-15 21:44:04 +08:00
GriffinR 5d58cdd297 Fix bunny hoppy typo 2022-02-28 13:34:39 -05:00
GriffinR 1ff0b0efa9 Add missing collision constant usage 2022-01-29 21:13:46 -05:00
GriffinR 3d0326106e Z coord / height -> elevation 2022-01-21 12:48:19 -05:00
cbt6 c59c7b0518 Use enums for jump distances 2021-11-28 12:01:29 +08:00
cbt6 b6430098d4 Rename speed parameter to distance in jump functions 2021-11-28 12:01:29 +08:00
GriffinR b5b5d95de6 Distinguish 'virtual object' names from object events 2021-11-17 23:40:53 -05:00
GriffinR c940b67716 Continue macro comment updating 2021-11-17 17:45:59 -05:00
GriffinR 04cc923d6c Handle optional arguments for warp commands, add WARP_ID_NONE 2021-11-16 10:53:00 -05:00
GriffinR c1130592fa Drop some overworld prefixes 2021-11-15 10:58:05 -05:00
cbt6 0fe3881961 Rename WalkInPlaceFastest to WalkInPlaceFaster 2021-11-05 01:54:34 +08:00
GriffinR 3e49ac804b Merge branch 'master' into doc-finalmisc 2021-11-03 13:56:22 -04:00
cbt6 fca863244b Index sStepTimes and sNpcStepFuncTables 2021-11-03 23:07:05 +08:00
cbt6 680f5f4458 Revert movement speed constants for jump movements 2021-11-03 23:00:37 +08:00
cbt6 87a094edcb Use constants for movement speeds 2021-11-03 20:51:41 +08:00
GriffinR afb9ff3a40 Document files with a few remaining symbols 2021-11-02 18:06:06 -04:00
cbt6 510ccbdf4c Move definition of constants for movement speed 2021-11-03 02:56:23 +08:00
cbt6 4cedd2d551 Rename WalkFastest functions to WalkFaster 2021-11-03 01:50:53 +08:00
cbt6 a2c2d7e230 Label indexes for movement speeds 2021-11-03 01:50:47 +08:00
cbt6 9a1764f83e Label some animation index numbers 2021-10-30 01:37:49 +08:00
cbt6 b3d779fd0d Document field player functions 2021-10-27 01:39:00 +08:00
GriffinR ff01eb951b Use TRACKS constants for sGroundEffectTracksFuncs 2021-10-09 13:21:14 -04:00
GriffinR 862febe03a Add MAP_OFFSET 2021-10-09 13:19:27 -04:00
GriffinR 42d2fefe02 Merge branch 'master' into tag-none 2021-09-24 10:17:34 -04:00
GriffinR f8f7617946 Add TAG_NONE 2021-09-14 13:14:14 -04:00
LOuroboros 554210c5e3 Removed trailing spaces in the most relevant files
Command used for the job:
egrep -rl ' $' --include *.c --include *.h --include  *.s --include  *.inc --include  *.txt *  | xargs sed -i 's/\s\+$//g'

Credits to Grant Murphy from Stack Overflow.
2021-08-24 19:59:32 -03:00
PikalaxALT 810ca5f8ff Flatten pos fields in struct Sprite 2021-07-07 09:11:52 -04:00
GriffinR d717a635c8 event_object_movement cleanup 2021-04-06 17:55:29 -04:00
GriffinR 8bad478b49 Document disguise field effects 2021-04-06 14:51:39 -04:00
GriffinR 756fad0e61 Document some event object movement 2021-04-06 14:34:36 -04:00
GriffinR 806abe2999 Document some objev anims, make objevgfx info static 2021-04-05 19:52:35 -04:00