70617d56e4
Merge pull request #1104 from PokeCodec/Explcit-Casting
...
Reduce "Implicit conversion" warnings
2020-07-28 11:10:00 -04:00
1e8ffcb898
Merge branch 'Explcit-Casting' of https://github.com/PokeCodec/pokeemerald into Explcit-Casting
2020-07-28 10:25:33 -04:00
b401e2eb86
Fix naming style of function
2020-07-27 21:22:16 -05:00
fb6f859edd
semicolon
2020-07-27 19:17:34 -04:00
71dc5edf2e
Document some battle_util.c
2020-07-27 17:10:42 -05:00
5f6e7e2279
Update secret_base.c
2020-07-27 14:59:37 -04:00
11178a49db
Fix undefined behaviour in protect animation
...
gPlttBufferFaded[sprite->data[2] + ++i] = gPlttBufferFaded[sprite->data[2] + i + 1]
The above does NOT make it certain that i gets incremented before reading from the right side. Changed it, so the function always increments i first, then reads from pal buffer.
2020-07-27 13:17:18 -04:00
1c55734e44
Document faraway island
2020-07-27 13:14:48 -04:00
ddd012f3ed
holding back on casts
2020-07-27 12:47:08 -04:00
f007165c53
Fix undefined behaviour in protect animation
...
gPlttBufferFaded[sprite->data[2] + ++i] = gPlttBufferFaded[sprite->data[2] + i + 1]
The above does NOT make it certain that i gets incremented before reading from the right side. Changed it, so the function always increments i first, then reads from pal buffer.
2020-07-27 12:27:35 +02:00
c5aa91741b
Change signedness and add casts to avoid implicit conversion warnings
2020-07-24 22:18:57 -04:00
5348674bc4
Merge pull request #1102 from GriffinRichards/doc-faraway
...
Document faraway island
2020-07-23 09:12:19 -04:00
af5090c892
Update agb_flash.c
2020-07-22 19:25:09 +02:00
bfa7dfcd58
Merge pull request #1105 from AsparagusEduardo/Coordinates
...
Changed mon front and back coordinates from hex to decimal so they're easier to edit.
2020-07-21 19:43:14 -04:00
6eccf019db
Fixed missing changes.
2020-07-21 19:32:33 -04:00
97ceca6527
Match AnimTask_RotateAuroraRingColors_Step
2020-07-21 16:11:11 -04:00
f825ba875e
Reverted size.
2020-07-19 21:17:32 -04:00
49ee0fd953
Front pic coordinates.
2020-07-19 20:54:12 -04:00
10c4debe31
Back pic coordinates
2020-07-19 20:37:11 -04:00
2273458d50
Label option menu pal
2020-07-19 15:44:58 -04:00
a1cc7d2bd6
Document faraway island
2020-07-19 14:12:38 -04:00
551334b20b
Fixed missing lowercase field name.
2020-07-18 23:10:37 -04:00
3bec840419
Fixed field names lowercase.
2020-07-18 23:08:44 -04:00
9b32cafd57
Some PSS documentation.
2020-07-18 21:58:01 -04:00
8e6dd3bafe
Merge pull request #1086 from GriffinRichards/doc-unktrans
...
Document unk_transition
2020-07-18 20:22:58 -04:00
1a27af8855
Merge pull request #1100 from GriffinRichards/clean-battlescrdata
...
Misc battle and battle palace documentation
2020-07-18 20:22:44 -04:00
aba42513d3
Clean up some battle scr cmd data
2020-07-18 18:10:15 -04:00
1cf2470aac
Merge pull request #1097 from PokeCodec/asm
...
Allow assembly on Clang
2020-07-17 18:19:06 -04:00
96fd719a19
Merge pull request #1081 from GriffinRichards/add-localids
...
Add local object event ids for referenced objects
2020-07-17 18:18:47 -04:00
50e48898d2
Merge pull request #1088 from GriffinRichards/doc-starterchoose
...
Document starter_choose.c
2020-07-17 16:02:10 -04:00
98441b1199
Sort out asm
2020-07-16 18:28:38 -04:00
c8e1079736
Use stat constants in MonGainEVs
2020-07-16 09:58:16 +02:00
7bea28cb84
Merge pull request #1093 from GriffinRichards/fix-frontiermonconst
...
Clean up some frontier mon use in battle factory
2020-07-15 13:37:07 -04:00
0c4f3b269e
Merge pull request #1083 from GriffinRichards/playse-constants
...
Use charmap constants for PLAY_SE
2020-07-15 02:53:53 -04:00
3c356a1d7a
Merge pull request #1082 from GriffinRichards/add-flagvarsave
...
Allow flag/var counts to be updated alongside values
2020-07-14 19:58:38 -04:00
a583dfcc42
Merge pull request #1094 from DizzyEggg/rename
...
Give proper names to some functions
2020-07-14 19:56:46 -04:00
c177872c9c
Merge pull request #1080 from AsparagusEduardo/EndBalls
...
Created constant for easier Ball Expansion.
2020-07-14 19:56:20 -04:00
0425cb66ef
Give proper names to some functions
2020-07-14 11:13:03 +02:00
1c75396276
Clean up some frontier mon use in battle factory
2020-07-13 00:47:30 -04:00
b31efcd6e3
Renamed constant,
2020-07-12 01:49:32 -04:00
535189bf14
Fix some UB exposed with GCC 10.1.0
2020-07-11 10:22:34 -04:00
4ba2799849
Update pokemon.c
2020-07-09 14:52:19 -04:00
beeb673ba1
Merge branch 'master' of https://github.com/pret/pokeemerald into add-flagvarsave
2020-07-08 16:03:32 -04:00
89bcf3cbd9
Merge branch 'master' into add-localids
2020-07-08 15:47:45 -04:00
431c60c92c
Merge branch 'master' of https://github.com/pret/pokeemerald into doc-confetti
2020-07-08 15:45:31 -04:00
8b80b417e2
Merge pull request #1069 from GriffinRichards/doc-link
...
Document linking
2020-07-08 15:43:45 -04:00
550875757b
Merge pull request #1087 from ipatix/fix_aggressive_loop_optimizations
...
fix aggressive loop optimizations
2020-07-08 15:42:08 -04:00
938aec45d3
Match CreatePokeDexList
...
Cherry-picked from the pret Ruby repo
2020-07-07 20:57:20 -04:00
43c48d95c2
Document starter_choose.c
2020-07-06 17:26:25 -04:00
3264cf697f
fix aggressive loop optimizations
...
Previously, aggressive loop optimizations with a new compiler were not
possible due to undefined behaviour at end of arrays.
A macro "UBFIX" is added to allow ifdefs for fixes which resolve
undefined behavior. For example newer GCC versions will detect various
bugs in the original game code and will otherwise not compile with -Werror.
2020-07-05 18:09:59 +02:00
PikalaxALT