Commit Graph

1460 Commits

Author SHA1 Message Date
GriffinR 826fc3154e condense secret base mapscript labels 2019-09-06 13:01:45 -04:00
GriffinR cb82d868af fix secret base jsons 2019-09-06 02:49:26 -04:00
GriffinR 9fbcd552de document remainder of secret_base scripts, delete unneeded scripts.incs 2019-09-06 02:12:00 -04:00
PikalaxALT f3bed6045e Disassemble data/ereader_screen.s 2019-09-05 20:48:48 -05:00
PikalaxALT b510100503 Port trainer hill sets to C objects 2019-09-05 20:48:48 -05:00
Eduardo Quezada D'Ottone de02805388 Changed names. 2019-09-05 20:42:15 -05:00
Eduardo Quezada D'Ottone e2689d2a27 Documented Mechadoll answers. 2019-09-05 20:42:15 -05:00
GriffinR 8c6b5648d4 document secret_base_1.inc 2019-09-05 16:16:21 -04:00
GriffinR 1d703e786b move some data out of event_scripts, use game stat constants 2019-09-05 14:56:34 -04:00
GriffinR 6b04ea0727 Merge branch 'master' into document-eventscripts 2019-09-03 22:22:14 -04:00
PikalaxALT 1f4c88c952 Copy Berry Fix MB dism from FR (#777)
* Copy Berry Fix MB dism from FR
2019-09-03 15:33:11 -04:00
DizzyEggg 6a3b74c59c Use item constant in pretty petal flower shop 2019-08-30 09:48:59 +02:00
GriffinR a46f7952f9 Use DIR constants for createvobject
Also uses event object ids in LinkContestRoom1
2019-08-21 17:11:06 -05:00
GriffinR f08615881e Changes from review 2019-08-21 17:06:55 -05:00
GriffinR 5fb7ab05dd clean up 2019-08-21 17:06:55 -05:00
GriffinR d931ba9602 document remaining funcs 2019-08-21 17:06:55 -05:00
GriffinR 7fc99f3952 favor lady funcs 2019-08-21 17:06:55 -05:00
GriffinR 009caa21c8 some contest lady funcs 2019-08-21 17:06:55 -05:00
GriffinR 23979c4d7d initial documentation commit 2019-08-21 17:06:55 -05:00
tustin2121 82744ba636 Replace {STRING 5} with {KUN}
Since we already have the KUN placeholder, there's no need for this {STRING 5} stuff.

Also, it makes it easier to delete all the {KUN}s in hacks later on if desired.
2019-08-21 14:05:22 -04:00
Tustin2121 18dee14170 Review fixes 2019-08-17 23:26:46 -04:00
Tustin2121 d63a8ba817 Replaced createvobject numbers with EVENT_OBJ_GTX defines
Doing this allows someone to renumber the event object graphics and still have working contests.
2019-08-17 13:38:13 -04:00
Tustin2121 1069adae46 Renaming unknown link room ids to be the same as name
This descrepency was causing a lot of annoyance when using porymap, because porymap generated the ids in map_groups.h from the name, and mapjson was generating map_groups.h from the id in the json files. So just name them the same already like every other map in the repo.
2019-08-17 13:26:57 -04:00
Tustin2121 f4d4424618 Folded nops into hidemoneybox and updatemoneybox
The nops are essential to the hidemoneybox and updatemoneybox commands when using vanilla versions of those commands. Even though they're not actually used parameters in the command implementation, they are still consumed, which means if someone were to get rid of the nops (as I did in TriHard) it causes the commands to consume bytecode that are not theirs, resulting in undefined behavior usually leading to softlocks. Folding the extra bytes into the macros means there's no chance of the extra bytes getting losts in scripts.
2019-08-17 13:25:36 -04:00
Tustin2121 6508469259 Rename movobjectoffscreen to copyobjectxytoperm
Renaming the command to something that makes more sense as to what the command actually does. The command copies the current xy of the instantiated object back to its template, so that the object remains in the same place if the player walks away and despawns the object, and then comes back. "moveobjectoffscreen" implies that it might be taking the object and moving it physically to an off-screen location somehow.
2019-08-17 13:18:56 -04:00
Tustin2121 ea724278b7 Juan text buffer overflow note 2019-08-17 13:05:55 -04:00
GriffinR ecf2097abb initial event_scripts documentation 2019-08-14 23:38:42 -04:00
PikalaxALT 9beeba8424 Merge pull request #764 from GriffinRichards/document-varnames
Document vars that are used and unnamed
2019-08-05 11:59:53 -04:00
GriffinR 191f74525d name unused route state vars 2019-08-05 11:50:29 -04:00
GriffinR c2bf668fdd rename town/city vars 2019-08-05 11:23:45 -04:00
DizzyEggg 1641579297 Merge branch 'master' into pok_jump 2019-08-04 00:02:13 +02:00
GriffinR 0f5d96e5f5 name used and unnamed vars 2019-08-03 14:12:48 -04:00
PikalaxALT 9f50c4fa80 Merge pull request #760 from ultima-soul/use_pokeblock_data
Decompile use_pokeblock data
2019-08-03 11:01:05 -04:00
DizzyEggg 9306c142b3 Merge dodrio with master 2019-08-02 00:45:49 +02:00
DizzyEggg 4d2d8779bf Dodrio berry picking decompiled 2019-08-02 00:41:55 +02:00
DizzyEggg 02cadbee60 MORE DODRIO BERRY PICKINGgit status! 2019-08-01 19:01:50 +02:00
ultima-soul 9a152f8fe6 Decompile data/use_pokeblock.s 2019-07-30 17:21:17 -07:00
DizzyEggg ba1a70419a Start dodrio magic 2019-07-31 00:27:30 +02:00
DizzyEggg e634e722cc Decompile pokemon jump 2019-07-29 12:35:57 +02:00
garak dfa3e079c0 finish pokenav data decomp 2019-07-19 22:57:33 -04:00
garak f9a9297d4f decompile pokenav 7/8 data 2019-07-19 22:06:42 -04:00
garak f6d55db535 decompile pokenav_unk_5 data 2019-07-19 21:05:55 -04:00
garak 690a0c4390 decompile pokenav_unk_4 rodata 2019-07-19 19:36:17 -04:00
garak c400d1dc7f decompile pokenav_unk_3 data 2019-07-19 18:31:42 -04:00
garak b68ab6106d pokenav unk 2 data decomp 2019-07-19 17:23:52 -04:00
garak a43dcd26bd finish labeling metatiles 2019-06-16 10:08:07 -05:00
garak 713f61de7c continue labeling metatiles for scripts 2019-06-16 10:08:07 -05:00
DizzyEggg f64c1dfabf Some pokenav work 2019-05-26 07:20:51 -05:00
Slawter666 5f292d621a Use event object constants 2019-05-25 14:41:48 -05:00
DizzyEggg 39770f7fde Use constants for new game berries setting script 2019-05-25 08:27:07 -05:00