57e3f5e0f8
Mirror pokeemerald PR#1329 & PR#1335 to pokefirered
...
The `giftRibbons` field in `SaveBlock1` has been split out into proper subfields. The new ExternalEvent structs deal with interconnectivity between external games/peripherals and FRLG. US & JP Colosseum Bonus Discs', Colosseum and XD's, Pokémon Channel's, and PokémonBox: Ruby & Sapphire's interactions with these fields has been documented.
The `giftRibbon#` fields in `PokemonSubstruct3` have also been renamed to their appropriate ribbons, and commented with distribution info if applicable. The previous `fatefulEncounter` field was actually filler, and relabeled as such, while the `obedient` bit was renamed `eventLegal`. All relevant constants and functions dealing with the Pokémon data structure were renamed with these changes in mind.
I still maintain that `eventLegal` is a misnomer and it should be called `fatefulEncounter` in all three repos.
2021-02-16 16:56:31 -05:00
bb56d4a3f4
Give songs meaningful english names
2020-08-29 03:11:03 -04:00
8f8665e1dc
Some documentation of berry_crush
2020-04-11 14:34:45 -04:00
aea30489fc
Create COPYWIN defines for CopyWindowToVram calls
2020-04-10 16:17:46 -04:00
5f7ed93363
Name as many symbols as I could in trade.c
2020-04-10 12:03:37 -04:00
fc7f04322d
Address review comments, 3
2020-04-10 11:16:53 -04:00
fd66e15464
Address review comments, 2
2020-04-10 11:11:47 -04:00
61a06dffe7
Address review comments
2020-04-10 10:57:20 -04:00
d79a499d91
Attempt to doc trade
2020-04-09 14:43:08 -04:00
f0fe4904d0
through sub_8056918
2020-03-28 14:03:51 -04:00
3aeb294572
Port pokemon_storage_2 from emerald
2020-03-11 13:32:30 -04:00
b7c28c4be7
Remove redundant include lines
2020-02-21 15:00:56 -05:00
b3167d579b
use uroom size/count macros; travis reverts back to agbcc master
2020-02-15 14:49:27 -05:00
57c2ea74a8
Address review comments
2020-02-12 17:02:45 -05:00
aa4a979334
More function documentation in union_room, link, link_rfu_2
2020-02-12 15:32:14 -05:00
4770fac9eb
More mevent documentation
2020-02-04 14:16:45 -05:00
7bd0a83d35
I'm so original with these commit names
2020-02-03 16:41:25 -05:00
c0b05784d6
Finish union_room_chat_display
2020-01-25 13:35:34 -05:00
246e3461c7
Move GFtgtGname out of librfu.h
2020-01-14 12:41:43 -05:00
a436d79177
partially sync with knizz's documentation
2020-01-09 12:38:56 +08:00
a36b4dde1f
sub_804F284
2019-12-20 10:07:14 +08:00
84d9a1e723
sub_804C728; sub_804CF14
2019-12-19 13:43:11 +08:00
36b2301fd2
mostly standardize to object event to prep for disassembly
2019-12-17 15:05:23 -05:00
5c1bdd0eb5
party_menu third quarter
2019-11-23 08:09:23 +08:00
49eb350462
party_menu second quarter
2019-11-23 08:09:23 +08:00
1d96920da0
party_menu data
2019-11-23 08:09:23 +08:00
a4e7a35960
document some symbols
2019-11-23 08:09:22 +08:00
f86bb07027
Review comments and documentation
2019-10-30 21:06:15 -04:00
1ba6cb2245
Some renaming; resolve trade bss
2019-10-30 16:51:43 -04:00
84e1b97eac
Ape trade graphics from Emerald
2019-10-30 15:09:13 -04:00
6c209e32a8
trade.c static symbols
2019-10-30 14:23:33 -04:00
f6d768d5ed
Trade data; split off trade_scene
2019-10-30 14:20:32 -04:00
2c2c179eb9
Finish trade code
2019-10-30 12:49:16 -04:00
265f8b5b25
trade through sub_8053E1C; dynamic sys flags start idx
2019-10-30 11:16:26 -04:00
0f0fb927a9
Port sub_805232C
2019-10-30 06:36:12 -04:00
e7a66b2941
port sub_8050F3C
2019-10-29 21:29:10 -04:00
e9592bee5d
Finish sub_8050968
2019-10-29 20:28:17 -04:00
316337b031
trade partway through sub_8050968
2019-10-29 17:05:56 -04:00
ce5c3fdd77
Trade through sub_804FFE4
2019-10-29 12:58:40 -04:00
a1ec6ccff1
Port through sub_804FE00
2019-10-29 11:40:48 -04:00
4c5e645e90
trade port through sub_804FA14
2019-10-29 11:02:57 -04:00
4e296b8777
trade through sub_804EED4
2019-10-28 16:31:59 -04:00
efe914a5ba
trade through sub_804E944
2019-10-28 15:55:57 -04:00
e9cf9fc104
port shedinja_maker_maybe; resolve within-array party pointers
2019-10-28 12:16:01 -04:00
a5ff9f2d00
trade through sub_804D814
2019-10-28 11:15:08 -04:00
b290a1a570
trade through sub_804D694
2019-10-28 10:43:57 -04:00
3710c0a370
Nonmatching sub_804CF14
2019-10-28 10:23:51 -04:00
47534a1471
Merge branch 'master' of github.com:pret/pokefirered into trade
2019-10-27 20:52:55 -04:00
b8fec3d9f6
Merge branch 'master' into trade
2019-10-14 10:46:04 -04:00
9fe74ac590
trade through sub_804C728 (nonmatching
2019-10-14 09:40:17 -04:00
Deokishisu