Commit Graph

73 Commits

Author SHA1 Message Date
GriffinR 3de70980e5 Document text window 2022-10-05 15:00:58 -04:00
GriffinR 7b2da8e402 Sync/document the rest of strings.c 2022-09-13 14:48:54 -04:00
Eduardo Quezada 9241dc6fe7 Merge remote-tracking branch 'pret/master' into pokefirered_pokeemeraldSync4
# Conflicts:
#	include/battle.h
#	include/cable_club.h
#	src/battle_anim_fire.c
#	src/battle_anim_ghost.c
#	src/battle_anim_ground.c
#	src/battle_message.c
#	src/cable_club.c
2022-09-04 17:44:13 -03:00
GriffinR 321f5371d8 Sync cable club 2022-08-25 18:48:54 -04:00
Eduardo Quezada 57374b796b Sync src/battle_controllers.c 2022-08-18 11:32:26 -04:00
GriffinR efa422d6fa Sync battle anim - mons 2022-08-17 13:14:34 -04:00
Eduardo Quezada 95dd979f09 Font constants and slight PSS sync 2022-07-31 21:00:27 -04:00
Eduardo Quezada 7f53f533bb Synced src/battle_script_commands.c 2022-07-29 09:42:03 -04:00
Eduardo Quezada f5e9cc595b Multiple changes
- BATTLESTRINGS_ID_ADDER ->BATTLESTRINGS_TABLE_START
- Defines for battle windows
- MAIL_NONE
- MON_DATA_FILLER -> MON_DATA_UNUSED_RIBBONS
- Usage of BattlePutTextOnWindow with masks
- PlayCry1 -> PlayCry_Normal
- BlendPalettes(0xFFFFFFFF -> BlendPalettes(PALETTES_ALL
- FillPalette(0 -> FillPalette(RGB_BLACK
2022-07-27 18:14:48 -04:00
Eduardo Quezada 611112269e StringCopy10 to StringCopy_Nickname 2022-07-27 14:35:19 -04:00
Eduardo Quezada 3b98289de2 BeginNormalPaletteFade PALETTES_ALL documentation 2022-07-27 13:16:28 -04:00
GriffinR b2c74cae84 Sync global 2021-11-19 20:36:59 -05:00
PikalaxALT aec808ac0d Flatten pos fields in struct Sprite 2021-07-07 09:05:48 -04:00
Deokishisu 8e4320cc21 Sync LinkPlayer Struct with pokeemerald
In pokefirered, the `LinkPlayer` struct used an 11-byte name field and puts extra link-related info in the last three bytes. pokeemerald separates these last three bytes into their own fields. This commit replicates how pokeemerald handles those fields.

Also renamed `IntlConvertLinkPlayerName` to pokeemerald's `ConvertLinkPlayerName` because I was there and noticed it.
2021-06-03 12:45:59 -04:00
PikalaxALT 03b4ea32a9 Merge remote-tracking branch 'origin' into doc_pokesum 2021-04-12 16:18:38 -04:00
Kurausukun 4b182affb6 standardize "grey" to "gray" 2021-04-09 22:34:08 -04:00
PikalaxALT 52c25bac8e Merge pull request #411 from Kurausukun/temp2
Fix Trade Nonmatchings (Thanks to Shoomer/RadicalDweamer)
2021-04-09 12:33:31 -04:00
Kurausukun 48fb5e9b45 correct text color variable names 2021-04-09 01:30:49 -04:00
Kurausukun 4446da96fe fix text color names 2021-04-09 01:11:31 -04:00
Kurausukun ba26e43f94 fix trade nonmatchings (thanks to shoomer) 2021-04-07 23:09:44 -04:00
PikalaxALT c99894bc60 Document Pokemon Summary Screen, 1 2021-04-04 09:59:40 -04:00
PikalaxALT 2f4f63afdb Document old man batttle controller 2021-03-15 14:27:50 -04:00
Deokishisu 57e3f5e0f8 Mirror pokeemerald PR#1329 & PR#1335 to pokefirered
The `giftRibbons` field in `SaveBlock1` has been split out into proper subfields. The new ExternalEvent structs deal with interconnectivity between external games/peripherals and FRLG. US & JP Colosseum Bonus Discs', Colosseum and XD's, Pokémon Channel's, and PokémonBox: Ruby & Sapphire's interactions with these fields has been documented.

The `giftRibbon#` fields in `PokemonSubstruct3` have also been renamed to their appropriate ribbons, and commented with distribution info if applicable. The previous `fatefulEncounter` field was actually filler, and relabeled as such, while the `obedient` bit was renamed `eventLegal`. All relevant constants and functions dealing with the Pokémon data structure were renamed with these changes in mind.

I still maintain that `eventLegal` is a misnomer and it should be called `fatefulEncounter` in all three repos.
2021-02-16 16:56:31 -05:00
GriffinR bb56d4a3f4 Give songs meaningful english names 2020-08-29 03:11:03 -04:00
PikalaxALT 8f8665e1dc Some documentation of berry_crush 2020-04-11 14:34:45 -04:00
PikalaxALT aea30489fc Create COPYWIN defines for CopyWindowToVram calls 2020-04-10 16:17:46 -04:00
PikalaxALT 5f7ed93363 Name as many symbols as I could in trade.c 2020-04-10 12:03:37 -04:00
PikalaxALT fc7f04322d Address review comments, 3 2020-04-10 11:16:53 -04:00
PikalaxALT fd66e15464 Address review comments, 2 2020-04-10 11:11:47 -04:00
PikalaxALT 61a06dffe7 Address review comments 2020-04-10 10:57:20 -04:00
PikalaxALT d79a499d91 Attempt to doc trade 2020-04-09 14:43:08 -04:00
PikalaxALT f0fe4904d0 through sub_8056918 2020-03-28 14:03:51 -04:00
PikalaxALT 3aeb294572 Port pokemon_storage_2 from emerald 2020-03-11 13:32:30 -04:00
PikalaxALT b7c28c4be7 Remove redundant include lines 2020-02-21 15:00:56 -05:00
PikalaxALT b3167d579b use uroom size/count macros; travis reverts back to agbcc master 2020-02-15 14:49:27 -05:00
PikalaxALT 57c2ea74a8 Address review comments 2020-02-12 17:02:45 -05:00
PikalaxALT aa4a979334 More function documentation in union_room, link, link_rfu_2 2020-02-12 15:32:14 -05:00
PikalaxALT 4770fac9eb More mevent documentation 2020-02-04 14:16:45 -05:00
PikalaxALT 7bd0a83d35 I'm so original with these commit names 2020-02-03 16:41:25 -05:00
PikalaxALT c0b05784d6 Finish union_room_chat_display 2020-01-25 13:35:34 -05:00
PikalaxALT 246e3461c7 Move GFtgtGname out of librfu.h 2020-01-14 12:41:43 -05:00
jiangzhengwenjz a436d79177 partially sync with knizz's documentation 2020-01-09 12:38:56 +08:00
jiangzhengwenjz a36b4dde1f sub_804F284 2019-12-20 10:07:14 +08:00
jiangzhengwenjz 84d9a1e723 sub_804C728; sub_804CF14 2019-12-19 13:43:11 +08:00
garak 36b2301fd2 mostly standardize to object event to prep for disassembly 2019-12-17 15:05:23 -05:00
jiangzhengwenjz 5c1bdd0eb5 party_menu third quarter 2019-11-23 08:09:23 +08:00
jiangzhengwenjz 49eb350462 party_menu second quarter 2019-11-23 08:09:23 +08:00
jiangzhengwenjz 1d96920da0 party_menu data 2019-11-23 08:09:23 +08:00
jiangzhengwenjz a4e7a35960 document some symbols 2019-11-23 08:09:22 +08:00
PikalaxALT f86bb07027 Review comments and documentation 2019-10-30 21:06:15 -04:00