Commit Graph

92 Commits

Author SHA1 Message Date
Alex 2044bea883 Rename battlerId to battler for consistency (#2126) 2025-05-09 12:43:23 +01:00
DavidJCobb 0f17e70371 Shorter names for engine/controller communication enum members 2025-05-02 00:01:15 -04:00
DavidJCobb b4ee45f3e8 Renamed BATTLELINKMSGTYPE_ to BATTLELINKCOMMTYPE_
I want to avoid the word "message" since PRET has already chosen "battle message" as the term for predefined strings usable in the battle scripts and UI.

I was considering the term "battle link packet" instead, but the library for wireless communications already uses the word "packet" even though GBATEK does not. I'm going with "battle link communication type" instead. For this particular context, I don't think we need a compound noun ("X type"); the singular noun "type" is fine enough.
2025-04-26 11:37:20 -04:00
DavidJCobb d8721b668e Fixed find-and-replace mistake
Functions were using the wrong constant.
2025-04-26 10:54:22 -04:00
DavidJCobb 9dc48899d3 BUFFER_A/B -> BATTLELINKMSGTYPE; link send/recv. task data names
Replaced the BUFFER_A and BUFFER_B constants with the BATTLELINKMSGTYPE enum, which also identifies the "controller becoming idle" message type.

Named the task data for the link send task and the link receive task. Added macros to functions related to those tasks, for legibility.
2025-04-26 00:13:42 -04:00
Bassoonian e5ac2fe0b1 Clean up pokemon/ball/dex mentions in comments 2023-12-12 19:02:36 +01:00
GriffinR aca7998b93 Add missing use of ALL_MOVES_MASK 2023-08-16 14:33:15 -04:00
GriffinR 65fee186f8 Automatically update nickname buffer sizes 2023-08-08 16:28:09 -04:00
GriffinR 0cc10a1ada Merge branch 'master' of https://github.com/pret/pokeemerald into ui-standardize 2023-01-18 11:07:12 -05:00
GriffinR 5b3596108d Add some missing PARTY_SIZE usage 2023-01-12 10:51:20 -05:00
Eduardo Quezada 3ed485632f Renamed gBaseStats to gSpeciesInfo 2022-10-24 17:01:48 -03:00
Eduardo Quezada 15d611ba65 Usage of BATTLE_PARTNER 2022-08-27 01:26:13 -04:00
Martin Griffin 6fed961ed6 Write palette IDs in hex 2022-08-19 15:29:35 +01:00
Eduardo Quezada 01558ff8f3 Struct pointers star standarizing 2022-07-29 11:15:33 -04:00
Eduardo Quezada 7b3401ee27 Standarized use of star in pointer types 2022-07-29 10:17:58 -04:00
GriffinR 1b35f9adad Use specific name limits for string limit functions 2021-11-17 22:11:03 -05:00
GriffinR f42eafc85b Merge branch 'master' into doc-banim 2021-11-13 23:26:46 -05:00
GriffinR e3b6337c3a Finish battle_anim_mons doc 2021-11-08 14:29:37 -05:00
GriffinR c4169cfd29 Disambiguate cry functions 2021-11-07 14:26:09 -05:00
GriffinR 54b254a829 Add CRY_MODE constants 2021-11-07 13:33:05 -05:00
GriffinR fc15b0d5f0 Add controller buffer constants, finish misc battle doc 2021-10-13 16:21:39 -04:00
GriffinR d8e65fc4b6 More battle doc, add battle window ids 2021-10-09 03:01:10 -04:00
PikalaxALT 810ca5f8ff Flatten pos fields in struct Sprite 2021-07-07 09:11:52 -04:00
GriffinR 62abcecc54 More usage of DISPLAY constants 2021-04-15 02:22:24 -04:00
GriffinR f4d8a91ba4 Misc battle script cleanup 2021-04-03 14:07:31 -04:00
GriffinR 74990a5a76 Sync player partner controller doc to player 2021-01-22 20:48:43 -05:00
GriffinR 63a7828772 Document battle_controller_player.c 2021-01-22 20:03:27 -05:00
GriffinR 4eca05ccf5 Document remainder of battle_controllers.c 2021-01-22 02:48:22 -05:00
GriffinR 2f426e0e7d Index battle controller cmd tables 2020-12-29 17:21:58 -05:00
GriffinR afb3472282 Minor battle_anim_throw cleanup 2020-08-30 15:11:44 -04:00
hondew e46b35455d Merge branch 'master' into pokeball-doc 2020-08-30 14:14:38 -04:00
hondew 328aecc96e Document throwing pokeball
continue

Document more

Doc more funcs

Remove workspace

Document shiny stars

Document PokeBlock

Clean up

Clean more
2020-08-30 14:08:06 -04:00
GriffinR 3014241179 Give songs meaningful english names 2020-08-20 19:06:14 -04:00
GriffinR 2756771958 More usage of ST_OAM constants and SPRITE macros 2019-12-06 19:05:44 -06:00
DizzyEggg 33979f0fa6 use ability num instead of alt ability 2019-05-16 17:09:43 -05:00
DizzyEggg b0223f691f Clean up data headers 2019-04-05 07:53:23 -05:00
Phlosioneer 5886f82ef5 Merge branch 'master' into extern-cleanup 2019-03-08 02:45:26 -05:00
DizzyEggg e79b6f747b Fix Controllers end command function names 2019-03-05 20:07:59 +01:00
Phlosioneer 3ceb1667c9 Reduce externs 2019-03-01 22:32:50 -05:00
Marcus Huderle 1253cbf5f6 Document some battle anim things 2019-02-06 21:14:28 -06:00
Philipp AUER 55202eac24 rename coords to size in struct MonCoords 2019-01-04 19:59:55 -06:00
melthelesbian 2dd706ca54 use max mon moves constant where able (#480)
* use max mon moves constant where able

* fix errors in script commands file

* fix more errors
2018-12-25 11:50:15 -06:00
Marcus Huderle c74468fd11 Document a bunch of battle anim stuff 2018-12-17 22:16:17 -06:00
shinny456 60484153a5 decompile electric.s 2018-12-16 22:23:05 -05:00
DizzyEggg dcb1d78fa9 Add battle controllers var to src from sym_ewram 2018-12-03 16:20:39 +01:00
Marcus Huderle 5947e0d229 Decompile rock 2018-11-25 17:00:18 -06:00
Marcus Huderle 72f0a079a9 Decompile all of battle_anim_utility_funcs 2018-11-19 09:37:25 -06:00
DizzyEggg 1b0cfb0757 Party Size and Num Stats 2018-11-18 20:00:36 +01:00
Slawter666 4311fd8b89 Sort includes into alphabetical order 2018-11-14 00:01:50 +00:00
garak 38fcc46abb Merge remote-tracking branch 'upstream/master' into pan-constants 2018-10-19 16:05:14 -04:00