Commit Graph

328 Commits

Author SHA1 Message Date
GriffinR 3d0326106e Z coord / height -> elevation 2022-01-21 12:48:19 -05:00
GriffinR 4024b3f1b3 Merge pull request #1590 from GriffinRichards/dex-enum
Convert pokedex defines to enums
2022-01-10 14:56:26 -05:00
GriffinR 5d033c2e4d Convert pokedex defines to enums 2022-01-05 12:18:49 -05:00
GriffinR aadab8b016 Move pokemon and easy chat constants to global, misc clean-up 2021-12-28 18:07:41 -05:00
GriffinR d414787932 Some TV clean-up 2021-11-16 16:22:17 -05:00
GriffinR 04cc923d6c Handle optional arguments for warp commands, add WARP_ID_NONE 2021-11-16 10:53:00 -05:00
GriffinR 1548e902cd Add MonCoods size macro 2021-11-08 09:41:23 -05:00
GriffinR d6571f2355 Merge pull request #1525 from GriffinRichards/doc-recmix
Document remainder of Record Mixing
2021-10-26 14:18:38 -04:00
GriffinR 6dc3c9864c Merge pull request #1520 from GriffinRichards/doc-random
Document random remaining symbols
2021-10-24 23:43:17 -04:00
GriffinR ab80264921 Merge pull request #1519 from GriffinRichards/doc-mgift
Document Mystery Gift
2021-10-24 15:50:39 -04:00
GriffinR 7f3c529935 Document record mixing mail swap 2021-10-24 15:49:19 -04:00
Jademalo 62436d9f67 IDE support formatting and consistency 2021-10-23 10:10:00 +01:00
Jademalo eb860a368e Improve IDE support 2021-10-22 04:30:33 +01:00
GriffinR 24b4e898ad More mauville_old_man clean up 2021-10-18 14:40:04 -04:00
GriffinR db8ce5d7f9 Clean up mauville_old_man, drop ScrSpecial prefix 2021-10-18 01:09:41 -04:00
GriffinR 3cd27acbea Document wonder news 2021-10-17 02:09:31 -04:00
GriffinR 5f9069628d Clean up mevent2 2021-10-17 01:35:26 -04:00
GriffinR c7d550e96c Clean up wonder card/news view 2021-10-17 01:15:16 -04:00
GriffinR 845a5e99cc General mystery gift documentation, finish mystery gift client/server/scripts 2021-10-16 23:35:17 -04:00
GriffinR c02001c46d Document mystery gift link scripts, general mystery gift 2021-10-15 12:05:06 -04:00
GriffinR 95406384f4 Start wonder card/news documenting 2021-10-14 13:24:20 -04:00
GriffinR a6ab2eb883 Merge branch 'master' into trailingSpaces 2021-09-23 21:39:21 -04:00
GriffinR cbf8863e5b Clean up Lilycove Lady 2021-09-09 15:24:34 -04:00
LOuroboros 554210c5e3 Removed trailing spaces in the most relevant files
Command used for the job:
egrep -rl ' $' --include *.c --include *.h --include  *.s --include  *.inc --include  *.txt *  | xargs sed -i 's/\s\+$//g'

Credits to Grant Murphy from Stack Overflow.
2021-08-24 19:59:32 -03:00
GriffinR aad090e154 Document TV 2021-04-26 12:35:35 -04:00
GriffinR 33ea2a1061 Remove unnecessary scope for TEST_BUTTON 2021-04-13 02:50:50 -04:00
GriffinR 4a1cfbead2 Document remaining overworld 2021-04-06 16:55:43 -04:00
GriffinR 86856098a3 Document Dewford Trend 2021-03-31 16:08:42 -04:00
GriffinR c40fb9288c Merge pull request #1378 from GriffinRichards/doc-berrycrush
Document Berry Crush
2021-03-29 12:38:16 -04:00
GriffinR dfc6ee0e9e Add SAFE_DIV 2021-03-21 13:43:14 -05:00
GriffinR 22e2c0a47c Document Berry Crush 2021-03-18 15:18:23 -04:00
GriffinR 3f59362397 Merge branch 'master' into doc-pokejump 2021-02-28 10:27:50 -05:00
GriffinR 117b90a261 Document pokemon jump 2021-02-26 17:26:39 -05:00
GriffinR c6141fea83 Document easy chat 2021-02-24 11:03:45 -05:00
GriffinR e059c4fdfa Use new gift ribbons size, label unused ribbons 2021-02-17 14:11:45 -05:00
Deokishisu 1dda9939ab Fix Swapped Comments on PokeCoupon Tiers 2021-02-16 16:08:58 -05:00
Deokishisu 7f55bf875c Move BoxRS Data Down to ExternalEventFlags
As suggested, moved the BoxRS data fields into ExternalEventFlags and packed that struct.
2021-02-16 16:01:18 -05:00
Deokishisu fb60e036ce Document Box: Ruby & Sapphire Fields
Labeled another field in the ExternalEventData struct used by Pokémon Box: Ruby & Sapphire.

Special thanks to Citrus Bolt#4642.
2021-02-16 15:37:58 -05:00
Deokishisu cd89d17b12 Document More External Events
Did research to determine how the Japanese Colosseum Bonus Disc modifies the ExternalEventData fields. The Ageto Celebi flag, as well as the flag for the three PokeCoupon title rewards, have been documented and included into the struct.

The PokeCoupon fields are actually 3-byte fields, so they have been turned into bitfields, since u24 isn't possible.

Also discovered that Channel and US Colosseum Bonus Disc Jirachi use the same flag, so renamed that flag and commented to explain.

Also made general comments explaining how the ExternalEventData and ExternalEventFlags are applicable to Emerald specifically.
2021-02-16 09:41:07 -05:00
GriffinR ee4af94a36 Merge pull request #1324 from GriffinRichards/doc-sb
Document remainder of secret_base.c
2021-02-15 17:41:55 -05:00
Deokishisu b89c3e901e Fix giftRibbons Field in SaveBlock1 & Relabel Gift Ribbons in pokemon.h
The giftRibbons field has been split out into proper subfields. The new ExternalEvent structs deal with interconnectivity between external games/peripherals and Emerald, such as PokéCoupon storage and the flag for receiving Wishmaker Jirachi.

The giftRibbon fields in `PokemonSubstruct3` have also been renamed to their appropriate ribbons, and commented with distribution info if applicable. The previous `fatefulEncounter` field was actually filler, and relabeled as such, while the obedient bit was renamed `fatefulEncounter`. All relevant constants and functions dealing with the Pokémon data structure were renamed with these changes in mind.
2021-02-15 11:40:16 -05:00
GriffinR 0851c34bac Add berry tree id constants 2021-02-05 15:25:12 -05:00
GriffinR a240481d5f Document secret_base.c 2021-02-05 12:08:25 -05:00
kageru 6f91f7e0e3 Use more constants in Battle Tower code 2020-11-17 17:40:26 +01:00
aaaaaa123456789 1c3d75f673 Merge branch 'master' into reverts 2020-10-26 12:16:36 -03:00
GriffinR 5259898325 Replace POKEMON_SLOTS_NUMBER 2020-10-01 17:07:12 -05:00
aaaaaa123456789 7dc95a0103 Undo PokeCodec's PRs
This commit undoes most of PokeCodec's PRs after the debate in chat. Some
harmless or completely superseded PRs have been left alone, as there is not
much benefit in attempting to undo them.

Reverts #1104, #1108, #1115, #1118, #1119, #1124, #1126, #1127, #1132, #1136,
#1137, #1139, #1140, #1144, #1148, #1149, #1150, #1153, #1155, #1177, #1179,
#1180, #1181, #1182 and #1183.
2020-09-13 06:30:55 -03:00
PokeCodec da582d5258 Make JOY Macros match 2020-09-04 20:41:29 -04:00
GriffinR 22c1bf965a Finish documenting berry blender 2020-08-24 17:06:55 -04:00
GriffinR 65bd2faf94 Merge branch 'master' of https://github.com/pret/pokeemerald into doc-contest 2020-08-16 05:59:10 -04:00