Commit Graph

56 Commits

Author SHA1 Message Date
Bassoonian 59d315734d Update header files to match source files (#2143) 2025-05-19 09:18:04 +01:00
Bassoonian 16357c7e29 Streamline pointer notation (#2139) 2025-05-16 12:04:44 +01:00
Alex 2044bea883 Rename battlerId to battler for consistency (#2126) 2025-05-09 12:43:23 +01:00
DavidJCobb 0f17e70371 Shorter names for engine/controller communication enum members 2025-05-02 00:01:15 -04:00
DavidJCobb 7ee3043c58 Update battle_controllers.h
typo
2025-04-26 11:47:48 -04:00
DavidJCobb 2864408060 Tweaks to documentation comments 2025-04-26 11:40:14 -04:00
DavidJCobb b4ee45f3e8 Renamed BATTLELINKMSGTYPE_ to BATTLELINKCOMMTYPE_
I want to avoid the word "message" since PRET has already chosen "battle message" as the term for predefined strings usable in the battle scripts and UI.

I was considering the term "battle link packet" instead, but the library for wireless communications already uses the word "packet" even though GBATEK does not. I'm going with "battle link communication type" instead. For this particular context, I don't think we need a compound noun ("X type"); the singular noun "type" is fine enough.
2025-04-26 11:37:20 -04:00
DavidJCobb 8f5c1a452d Update battle_controllers.h
Simplified macros.
2025-04-26 01:33:17 -04:00
DavidJCobb 2738d11b0f Additional fixes to last few commits
ROM now compiles, but it's not comparing as equal...
2025-04-26 01:00:16 -04:00
DavidJCobb a4370ffcde gBattleControllerExecFlags bits now identified via helper macros
Created "exposition" macros to describe operations performed on gBattleControllerExecFlags. Updated the battle engine internals to use them, to more clearly document how battle link communications actually work.
2025-04-26 00:45:03 -04:00
DavidJCobb 9dc48899d3 BUFFER_A/B -> BATTLELINKMSGTYPE; link send/recv. task data names
Replaced the BUFFER_A and BUFFER_B constants with the BATTLELINKMSGTYPE enum, which also identifies the "controller becoming idle" message type.

Named the task data for the link send task and the link receive task. Added macros to functions related to those tasks, for legibility.
2025-04-26 00:13:42 -04:00
GriffinR 709cfa1c9a Merge pull request #2014 from Bassoonian/battleterrain
Rename battle terrain to environment
2025-04-13 19:32:06 -04:00
psf 312749dd31 Changed type1 and type2 to be consistent (#2021)
* Changed type1 and type2 in gBattleMons to match gSpeciesInfo
* Changed monType1 and monType2 to monTypes to match gSpeciesInfo
2024-08-07 06:44:03 +01:00
Bassoonian 003bd54600 Rename battle terrain to environment 2024-07-13 12:02:18 +02:00
Eduardo Quezada 3bc2cf921c Sync src/battle_controllers.c with pokefirered 2022-08-18 14:30:22 -04:00
Eduardo Quezada 5d4b76c0ba Review changes from pokefirered #524 2022-07-29 17:00:07 -04:00
Eduardo Quezada 7b3401ee27 Standarized use of star in pointer types 2022-07-29 10:17:58 -04:00
GriffinR 5e6d8a77e4 Document some generic argument names 2022-05-31 14:34:25 -04:00
GriffinR fc15b0d5f0 Add controller buffer constants, finish misc battle doc 2021-10-13 16:21:39 -04:00
GriffinR f4d8a91ba4 Misc battle script cleanup 2021-04-03 14:07:31 -04:00
GriffinR 63a7828772 Document battle_controller_player.c 2021-01-22 20:03:27 -05:00
GriffinR 4eca05ccf5 Document remainder of battle_controllers.c 2021-01-22 02:48:22 -05:00
GriffinR 2f426e0e7d Index battle controller cmd tables 2020-12-29 17:21:58 -05:00
GriffinR 6db014cc32 Document party_menu first pass 2019-10-25 15:41:06 -04:00
GriffinR 85d97542cd Use MAX_MON_MOVES constants 2019-09-16 19:21:23 -05:00
DizzyEggg dcb1d78fa9 Add battle controllers var to src from sym_ewram 2018-12-03 16:20:39 +01:00
Slawter666 6fcf878e2f Tidy up header files 2018-11-13 22:28:46 +00:00
Diegoisawesome a07d69d7c2 Finish pokemon_summary_screen 2018-08-14 22:00:35 -07:00
DizzyEggg bf0178238a Battle files - review changes 2018-07-16 20:47:30 +02:00
DizzyEggg 008d961b2a add party menu defines 2018-07-07 19:57:09 +02:00
DizzyEggg 272b98da6c document party status summary 2018-06-28 21:06:32 +02:00
DizzyEggg ab36efdaf4 document bounce effect 2018-06-20 23:07:51 +02:00
camthesaxman 6a4967689e more renaming 2018-02-06 13:48:02 -06:00
DizzyEggg 9151a6d094 dump battlescripts, rename battlescripts 2017-11-25 18:42:31 +01:00
DizzyEggg 192817a7dc clarify controllers terminator 2017-10-31 18:49:29 +01:00
DizzyEggg 712ae56167 review change battle controllers 2017-10-31 18:04:08 +01:00
DizzyEggg 1506184465 battle controller opponent is done 2017-10-26 23:12:48 +02:00
DizzyEggg df4e32a307 player battle controller is done 2017-10-22 18:43:15 +02:00
DizzyEggg 813b1bfd4a label and do more work at player controller 2017-10-22 01:04:02 +02:00
DizzyEggg 3d1c16523e start working on battle controllers, especially player 2017-10-21 17:32:35 +02:00
DizzyEggg 14e41d6c50 rom3 is decompiled 2017-10-14 11:34:26 +02:00
DizzyEggg 20d158cf4a start decompiling emitters 2017-10-13 19:46:27 +02:00
DizzyEggg c78679ae66 rom3 decomp start 2017-10-13 17:22:50 +02:00
DizzyEggg 57e5624e06 battle9 is being worked on 2017-10-10 18:01:45 +02:00
DizzyEggg 95e4ae06ce battle message decompiled and dumped 2017-10-08 14:54:51 +02:00
DizzyEggg 3cc20c7c3f battle 2 is done 2017-10-06 17:06:45 +02:00
DizzyEggg 46fe1f441f giant battle handler is done wohohohhohoho 2017-10-03 21:35:27 +02:00
DizzyEggg db58d5e24a battle2 3500 C lines 2017-10-02 23:32:39 +02:00
DizzyEggg bc3b4b4d9a battle 4 commands are decompiled 2017-09-28 15:34:21 +02:00
DizzyEggg d769ec1374 battle 4 up to a8 2017-09-26 22:39:59 +02:00