DavidJCobb
b4ee45f3e8
Renamed BATTLELINKMSGTYPE_ to BATTLELINKCOMMTYPE_
...
I want to avoid the word "message" since PRET has already chosen "battle message" as the term for predefined strings usable in the battle scripts and UI.
I was considering the term "battle link packet" instead, but the library for wireless communications already uses the word "packet" even though GBATEK does not. I'm going with "battle link communication type" instead. For this particular context, I don't think we need a compound noun ("X type"); the singular noun "type" is fine enough.
2025-04-26 11:37:20 -04:00
DavidJCobb
d8721b668e
Fixed find-and-replace mistake
...
Functions were using the wrong constant.
2025-04-26 10:54:22 -04:00
DavidJCobb
2738d11b0f
Additional fixes to last few commits
...
ROM now compiles, but it's not comparing as equal...
2025-04-26 01:00:16 -04:00
DavidJCobb
bab9f0cfef
gBattleControllerExecFlags macro in MarkAllBattlersForControllerExec
...
whoops, missed one
2025-04-26 00:46:06 -04:00
DavidJCobb
a4370ffcde
gBattleControllerExecFlags bits now identified via helper macros
...
Created "exposition" macros to describe operations performed on gBattleControllerExecFlags. Updated the battle engine internals to use them, to more clearly document how battle link communications actually work.
2025-04-26 00:45:03 -04:00
DavidJCobb
9dc48899d3
BUFFER_A/B -> BATTLELINKMSGTYPE; link send/recv. task data names
...
Replaced the BUFFER_A and BUFFER_B constants with the BATTLELINKMSGTYPE enum, which also identifies the "controller becoming idle" message type.
Named the task data for the link send task and the link receive task. Added macros to functions related to those tasks, for legibility.
2025-04-26 00:13:42 -04:00
Estellar
dd70446db5
Added constant in Birch speech dialogue
2025-04-23 18:46:11 -04:00
GriffinR
f11bddf854
Fixes for Mirage Tower graphics ( #2120 )
...
* Add documentation for CreateCeilingCrumbleSprites
* Combine mirage tower graphics
* Add comment about mirage tower / player palette
2025-04-14 08:12:45 +02:00
GriffinR
709cfa1c9a
Merge pull request #2014 from Bassoonian/battleterrain
...
Rename battle terrain to environment
2025-04-13 19:32:06 -04:00
Martin Griffin
2a0d3fd070
Merge pull request #2118 from cawtds/linkdirection-range-x-access
...
Make linkDirection more robust to member reordering
2025-04-10 06:47:06 +01:00
pokemonmasteraaron
d890436b2a
Fixed a compilation error if using AGBPrint as your log handler, misnamed AGBPrintfInit should be AGBPrintInit
2025-04-09 09:06:20 -04:00
cawtds
1672d99060
make linkDirection more robust to member reordering
2025-04-09 13:40:39 +02:00
Eduardo Quezada
a3075325a0
GENDER_COUNT in sPlayer/RivalAvatarGfxIds ( #2117 )
2025-04-05 20:18:07 -04:00
Isaac Aronson
56947be5d6
Fix union room typo
2025-03-28 10:26:01 -05:00
Hedara
521432b269
Renamed a berry tag variable
2025-03-24 13:47:47 +01:00
Hedara
4a1d273b08
Changed unused compressed pal include from u16 to u32
2025-03-24 11:41:49 +01:00
Raymond Dodge
7b6b9ab655
Remove casts in decoration.c ( #2110 )
2025-03-18 18:41:51 -04:00
Frank
a0a8434e26
Converted apprenctice IDs from hex to decimal
2025-02-13 12:13:22 -05:00
GriffinR
45d1c7ca7d
Merge pull request #2086 from DizzyEggg/patch-5
...
extern void * const gNullScriptPtr;
2025-02-11 14:45:19 -05:00
GriffinR
eb8eeaec48
Merge pull request #2094 from hedara90/pc-align-fix
...
Fixed potential unaligned issue in PC screen
2025-02-11 14:42:19 -05:00
GriffinR
a4350005e7
Merge pull request #2092 from AsparagusEduardo/patch-2
...
Fixed Gen 1/2's Transform "pink color" reference
2025-02-11 14:40:34 -05:00
shachar700
95aa41f0d4
Fixed switchout bug in multibattle where order of mons gets messed up ( #2099 )
2025-01-29 07:43:13 +00:00
Raymond Dodge
a3d0978762
Replace easy_chat alphabetialOrder magic numbers with EC_INDEX values ( #2096 )
2025-01-18 20:58:03 -05:00
DizzyEggg
e83f7c79eb
Fix conflicting types for rotating gate functions ( #2087 )
2025-01-17 18:19:21 -05:00
DizzyEggg
0a436d580e
Extern gSprites and gOamMatrices with known array size ( #2090 )
2025-01-17 18:18:17 -05:00
GriffinR
2f67b17571
Document bard music ( #2053 )
...
* Missing bard song limit constants
* Index bard sound arrays with word constants
* Document bard music
2025-01-17 17:54:38 +00:00
DizzyEggg
9385dfed67
Fix CaveTransition pals
2025-01-15 10:08:02 +01:00
Hedara
9bf7a772d0
Fixed potential unaligned issue in PC screen
2025-01-14 09:50:08 +01:00
Eduardo Quezada
453bb29b73
Fixed Gen 1/2's Transform "pink color" reference
2025-01-12 07:43:57 -03:00
DizzyEggg
07255a2237
extern void * const gNullScriptPtr;
2025-01-10 11:55:02 +01:00
DizzyEggg
84856817b2
remove undef TASK_NONE from list_menu
2025-01-09 19:33:45 +01:00
DizzyEggg
9ab4f5d26a
extern gAncientPowerRockSpriteTemplate fix
2025-01-09 15:50:39 +01:00
DizzyEggg
0ec1189f34
extern const gBasicHitSplatSpriteTemplate
2025-01-07 22:14:54 +01:00
Eduardo Quezada
50d325f081
Slight contest documentation ( #2078 )
2024-12-27 11:09:33 -05:00
DizzyEggg
861c579c11
remove sBirchSpeechPlatformBlackPal ( #2075 )
2024-12-13 17:39:51 -05:00
Eduardo Quezada
5483e05db6
Fixed brace style inconsistencies
2024-12-05 12:46:50 -03:00
Eduardo Quezada
e605ffba53
Fix recorded battle link player loops ( #2071 )
2024-12-04 16:22:16 -05:00
Eduardo Quezada
4beb0efbcc
Added extra encoded character support ( #2050 )
2024-11-24 20:46:01 -05:00
Martin Griffin
f775b09ae0
Merge pull request #2055 from GriffinRichards/spinda-spots
...
Add TRY_DRAW_SPOT_PIXEL
2024-11-20 12:22:59 +00:00
Lactozilla
b60da57d8a
Remove usage of gHeap in sSpritePalettes_ContestantsTurnBlinkEffect
...
Those offsets into gHeap are actually just inside of eContestTempSave.
2024-11-12 14:28:33 -03:00
GriffinR
da791cde94
Add TRY_DRAW_SPOT_PIXEL
2024-10-24 12:45:47 -04:00
Frank
544b76fbbf
Added value for bard sound length
2024-10-21 09:04:42 -04:00
luckytyphlosion
a55c75d350
Get rid of common syms ( #2040 )
2024-10-14 23:52:11 -04:00
Rose
9ad0018c17
Fix typo: | should be || in Task_TryFieldPoisonWhiteOut
...
Yes, this is honestly overkill, as it doesn't actually fix any behavioral bugs, but I was suggested to do this. This was a typo made in the source that GameFreak made, and the compiler warns against this. I opened a PR in pokeemerald expansion and was suggested to open one here.
2024-10-10 10:27:33 -04:00
psf
9a24c031bb
Replaced copyright magic numbers in intro.c with constants ( #2035 )
2024-10-02 20:48:54 -04:00
GriffinR
44e9228a6e
Merge pull request #2038 from GriffinRichards/gflib-syms
...
Remove explicit symbol sizes in sym_common.txt
2024-10-02 15:34:42 -04:00
Scyrous
1dc85df1f0
Update cable_car.c
2024-09-29 14:38:08 +02:00
Scyrous
8e2c3ca3f2
Bugfix for cable car sprite array count
2024-09-29 14:13:50 +02:00
GriffinR
80a37c16be
Remove explicit symbol sizes in sym_common.txt
2024-09-25 16:14:10 -04:00
Kurausukun
52c2728ff6
remove gflib
2024-09-18 10:37:34 -04:00
