Commit Graph

149 Commits

Author SHA1 Message Date
GriffinR d414787932 Some TV clean-up 2021-11-16 16:22:17 -05:00
GriffinR 5d9c31a610 Label slot machine ids, fix GetPriceReduction 2021-11-16 15:43:52 -05:00
GriffinR 04cc923d6c Handle optional arguments for warp commands, add WARP_ID_NONE 2021-11-16 10:53:00 -05:00
GriffinR a950f9c771 Clean up international_string_util 2021-10-17 21:51:11 -04:00
LOuroboros 554210c5e3 Removed trailing spaces in the most relevant files
Command used for the job:
egrep -rl ' $' --include *.c --include *.h --include  *.s --include  *.inc --include  *.txt *  | xargs sed -i 's/\s\+$//g'

Credits to Grant Murphy from Stack Overflow.
2021-08-24 19:59:32 -03:00
GriffinR 72bb2bd160 Merge pull request #1474 from GriffinRichards/clean-miragetower
Clean up Mirage Tower
2021-07-10 23:26:41 -04:00
GriffinR 0f538102d9 Add local id constants for C 2021-07-05 13:54:43 -04:00
GriffinR 8f43d1ebeb Document smart shopper TV show 2021-07-02 01:45:23 -04:00
GriffinR aad090e154 Document TV 2021-04-26 12:35:35 -04:00
GriffinR 8be2c5d60b Document Contest Lady TV Show 2021-04-02 01:49:38 -04:00
GriffinR 771a434730 Label Trend Watcher TV show texts 2021-03-31 16:29:42 -04:00
GriffinR 86856098a3 Document Dewford Trend 2021-03-31 16:08:42 -04:00
PikalaxALT e6b1b97aa1 Nonmatching resoltuion
- Fix fakematch in Cmd_get_used_held_item
- Remove `static` overrides in MODERN in four objects
2021-03-12 13:55:07 -05:00
GriffinR c6141fea83 Document easy chat 2021-02-24 11:03:45 -05:00
GriffinR 02c1fbd733 Document ribbon TV show, add new ribbon IDs/size 2021-02-18 09:59:24 -05:00
GriffinR ee4af94a36 Merge pull request #1324 from GriffinRichards/doc-sb
Document remainder of secret_base.c
2021-02-15 17:41:55 -05:00
Deokishisu 7b2bf8c7e2 Rename obedient/fatefulEncounter to eventLegal
Per discussion on pret, `obedient`/`fatefulEncounter` has been renamed to `eventLegal`, and all related functions and constants have been modified with this in mind.

Additionally, fixed some whitespace alignment issues in `script_cmd_table.h`, `pokemon.h`, and `tv.c` from the last commit.
2021-02-15 14:54:35 -05:00
Deokishisu b89c3e901e Fix giftRibbons Field in SaveBlock1 & Relabel Gift Ribbons in pokemon.h
The giftRibbons field has been split out into proper subfields. The new ExternalEvent structs deal with interconnectivity between external games/peripherals and Emerald, such as PokéCoupon storage and the flag for receiving Wishmaker Jirachi.

The giftRibbon fields in `PokemonSubstruct3` have also been renamed to their appropriate ribbons, and commented with distribution info if applicable. The previous `fatefulEncounter` field was actually filler, and relabeled as such, while the obedient bit was renamed `fatefulEncounter`. All relevant constants and functions dealing with the Pokémon data structure were renamed with these changes in mind.
2021-02-15 11:40:16 -05:00
GriffinR 2e57a00d17 Use GAME_LANGUAGE instead of LANGUAGE_ENGLISH 2021-02-05 12:08:49 -05:00
GriffinR 8fe4d004e3 Merge pull request #1305 from GriffinRichards/doc-battletv
Document battle tv data
2021-01-21 12:27:14 -05:00
GriffinR b65980cd4e Remove unused local variables and functions 2021-01-19 18:19:33 -05:00
GriffinR 564278fd49 Document battle tv data 2021-01-14 06:29:59 -05:00
MCboy e31158d017 add spaces around - and remove comment from include in battle.h 2020-11-06 23:29:52 +03:30
MCboy 3b91735e63 use constants for ball throw count 2020-11-06 22:59:46 +03:30
GriffinR 5259898325 Replace POKEMON_SLOTS_NUMBER 2020-10-01 17:07:12 -05:00
GriffinR 2ed726c0b9 Fix BreakinsNews typo 2020-09-04 07:27:52 -04:00
GriffinR 22c1bf965a Finish documenting berry blender 2020-08-24 17:06:55 -04:00
GriffinR 65bd2faf94 Merge branch 'master' of https://github.com/pret/pokeemerald into doc-contest 2020-08-16 05:59:10 -04:00
GriffinR e98e4652fd Document contest live updates 2020-08-16 05:18:09 -04:00
GriffinR 463d79c7c1 Start documenting naming screen 2020-08-07 02:00:41 -04:00
GriffinR ebb6c4ee66 Merge branch 'master' into doc-overworld 2020-07-08 15:51:58 -04:00
Michael Panzlaff 3264cf697f fix aggressive loop optimizations
Previously, aggressive loop optimizations with a new compiler were not
possible due to undefined behaviour at end of arrays.

A macro "UBFIX" is added to allow ifdefs for fixes which resolve
undefined behavior. For example newer GCC versions will detect various
bugs in the original game code and will otherwise not compile with -Werror.
2020-07-05 18:09:59 +02:00
GriffinR abdf7cbf02 Label fishing effect functions 2020-06-29 16:53:38 -04:00
GriffinR 4ea6992172 Continue documenting overworld/field effects 2020-06-29 01:26:29 -04:00
nullableVoidPtr 8381828571 Match sub_80F0708
Special thanks to @kazblox
2020-06-10 21:13:58 +08:00
GriffinR f6275cce57 Misc constant use in TV 2020-02-17 13:09:35 -06:00
GriffinR 956090b05f Merge branch 'master' of https://github.com/pret/pokeemerald into fix-eventobj 2020-02-12 13:05:57 -05:00
GriffinR 084bd66924 Document Trainer Card 2020-02-08 14:31:17 -06:00
GriffinR 655910a16f Merge branch 'master' into fix-eventobj 2020-01-12 22:42:43 -05:00
GriffinR 6a470ddfda Some script clean up, document secret base secrets show 2020-01-12 19:39:30 -06:00
GriffinR f559fa3fe2 Merge master into ObjEvent rename 2019-11-25 20:00:04 -05:00
GriffinR 63ee15fc28 Document Frontier Util 2019-11-25 18:37:48 -06:00
GriffinR ec3e86f1d2 Standardize Event Object to Object Event 2019-11-20 22:55:44 -05:00
GriffinR 5c5c1836bb Document Trainer Fan Club 2019-11-20 09:08:24 -06:00
GriffinR ff7e11c0b0 Merge branch 'master' into doc-scriptclean 2019-11-13 19:25:41 -05:00
GriffinR ef8370566f Document Contest scripts 2019-11-13 18:20:55 -06:00
GriffinR 7455bd9b9a Document interview and TV scripts, and misc script clean up 2019-11-12 14:20:05 -05:00
GriffinR a38bff8c17 Document Slateport scripts 2019-11-09 08:37:06 -06:00
GriffinR 5ef300c10b Document dept store 2019-11-04 16:49:06 -06:00
GriffinR 9a86769847 Document obtain_item.inc 2019-10-22 17:57:28 -05:00