Commit Graph

64 Commits

Author SHA1 Message Date
gAlfonso-bit c9c5586068 Fixed ChangeBgY_ScreenOff‘s signature. (#1447)
* Fix Functions

* Fix ChangeBgY_ScreenOff signature

* Remove unneeded changes

* Fix argument mismatch

Just to get this out of the way

* Not needed

* Update palette.c
2021-05-27 07:32:09 -05:00
Kurausukun 94939e395b one last goto 2021-05-24 13:31:54 -05:00
gAlfonso-bit aca96a1510 Mark 0xFFF8 as ~7
Since 7 is used as a mask, I wondered if 0xFFF8 was used to undo the mask and it turns out it was.
2021-05-24 07:36:08 -05:00
gAlfonso-bit a454f9c187 UBFIX: sprite.c (#1442)
Fix out-of-bounds array access in `SortSprites()`.

Co-authored-by: Marcus Huderle <huderlem@gmail.com>
2021-05-23 09:10:55 -05:00
Kurausukun dfd87e09f9 [LEAK-INFORMED] fix text.c "eff" fakematch 2021-05-13 11:26:15 -05:00
GriffinR cd2a99b7c4 Doc storage - misc cleanup, some item/cursor 2021-04-17 13:33:29 -04:00
Kurausukun 3e725272fc standardize "grey" to "gray" 2021-04-09 22:39:34 -04:00
GriffinR 51970f97b0 Merge pull request #1393 from GriffinRichards/doc-dewfordtrend
Document Dewford Trend and match_call.c
2021-04-01 22:19:48 -04:00
GriffinR f58465a274 Document match_call.c 2021-04-01 03:29:15 -04:00
Kurausukun 102582a3df Merge branch 'master' of https://github.com/pret/pokeemerald into fr_doc 2021-03-29 18:36:18 -04:00
Marcus Huderle 6cceb05cb7 Document some text-related things 2021-03-29 11:20:00 -05:00
GriffinR dfc6ee0e9e Add SAFE_DIV 2021-03-21 13:43:14 -05:00
Kurausukun 0691632ac6 oops 2021-03-19 18:52:37 -04:00
Kurausukun 7198d40ec8 port some documentation from FR 2021-03-19 18:49:19 -04:00
N e79048e8ee Remove unneeded bitwise operations 2021-03-04 19:35:25 -06:00
N b86b66660c Revert void change 2021-03-04 19:32:36 -06:00
N 8f5bd2fb33 Fix prefixes of variable names
Many static variables in this function are falsely labeled with a g prefix, as if it were global, when they are in fact state variables.
2021-03-04 19:32:36 -06:00
GriffinR b04f0aaa2b Use SPRITE_NONE constant 2021-02-24 11:03:32 -05:00
GriffinR da67b6ebd9 More window cleanup 2021-02-18 15:01:18 -05:00
GriffinR d62f89b20c Minor window/bg cleanup 2021-02-18 10:00:07 -05:00
GriffinR b65980cd4e Remove unused local variables and functions 2021-01-19 18:19:33 -05:00
Sierraffinity a982e6ab88 Make div by zero fix more concice 2021-01-04 16:39:47 -08:00
Sierraffinity 67a656a4df Fix/document possible division by zero in ConvertScaleParam 2021-01-04 16:26:28 -08:00
aaaaaa123456789 ca950a8daf Solve merge conflicts from previous commit 2020-11-02 22:18:26 -03:00
aaaaaa123456789 bacc831aa9 Re-apply joypad macros (minus merge conflicts) 2020-11-02 22:02:39 -03:00
aaaaaa123456789 1c3d75f673 Merge branch 'master' into reverts 2020-10-26 12:16:36 -03:00
Kurausukun 063596d87b re-match GLYPH_COPY 2020-10-21 04:26:45 -04:00
MeatLoaf3 5f17b07d0c Change toOrrX and toOrrY to u8 2020-10-02 11:17:11 -04:00
Revo 22c6c03429 Remove unnecessary comments 2020-10-01 17:06:33 -05:00
Revo 7f1fa72746 :masuda: 2020-10-01 17:06:33 -05:00
ProjectRevoTPP 7c697e9536 Resolve fakematch CopyGlyphToWindow. 2020-10-01 17:06:33 -05:00
aaaaaa123456789 7dc95a0103 Undo PokeCodec's PRs
This commit undoes most of PokeCodec's PRs after the debate in chat. Some
harmless or completely superseded PRs have been left alone, as there is not
much benefit in attempting to undo them.

Reverts #1104, #1108, #1115, #1118, #1119, #1124, #1126, #1127, #1132, #1136,
#1137, #1139, #1140, #1144, #1148, #1149, #1150, #1153, #1155, #1177, #1179,
#1180, #1181, #1182 and #1183.
2020-09-13 06:30:55 -03:00
PokeCodec de274dcb07 Removed unneeded comments 2020-09-04 21:20:52 -04:00
PokeCodec 28ef2fb774 Switch to button macros 2020-09-04 21:11:55 -04:00
PokeCodec ae9a60eb2a Documenting and whitespace fixing 2020-09-04 19:49:53 -04:00
PokeCodec 5504ceada3 Change array count of pointer value to array count of the first element 2020-08-30 14:33:11 -04:00
PokeCodec 83a7060143 Cleanup window.c 2020-08-25 15:56:17 -04:00
PokeCodec 75fea51712 refactor 2020-08-24 15:32:57 -04:00
PokeCodec b52c0d1a2e Cleaned up variables 2020-08-24 15:20:50 -04:00
PokeCodec 86a1e89879 Documentation of unk field 2020-08-23 21:34:31 -04:00
GriffinR 0e7f634b00 Wrap asm statements in NONMATCHING 2020-08-18 08:16:09 -04:00
PokeCodec d3e00cadcc Enum Time 2020-08-14 23:53:20 -04:00
GriffinR fa4d31ba96 Fix newline warning 2020-08-12 19:53:08 -04:00
GriffinR b3c4cd8a32 Merge pull request #1127 from PokeCodec/glyphMatch
Glyph match
2020-08-12 18:43:40 -04:00
PokeCodec f33737ae97 bool8 2020-08-12 12:53:59 -04:00
PokeCodec 4e20e2a3ea Match CopyGlyphToWindow 2020-08-12 12:34:01 -04:00
GriffinR cc4255d4c0 Add some charmap constant usage 2020-08-11 00:23:28 -04:00
GriffinR ebb6c4ee66 Merge branch 'master' into doc-overworld 2020-07-08 15:51:58 -04:00
GriffinR 18d57a3802 Document some overworld and field effects 2020-06-23 15:48:53 -04:00
GriffinR 7632404ba5 Document union_room_chat.c 2020-06-02 18:35:00 -04:00