Commit Graph

65 Commits

Author SHA1 Message Date
GriffinR 783e8e72cf Merge pull request #569 from GriffinRichards/sync-numtiles
Sync num_tiles flags, document tm_case
2022-11-17 19:18:37 -05:00
GriffinR 21220c9427 Merge branch 'master' into sync-numtiles 2022-11-10 12:27:47 -05:00
GriffinR d055ebad83 Document item_case 2022-11-10 12:26:05 -05:00
GriffinR 9983b41c1d Sync union room 2022-11-08 01:19:15 -05:00
GriffinR b3c47d0059 Finish syncing link_rfu_2 2022-11-07 14:07:48 -05:00
GriffinR 87ce3fd349 Merge branch 'master' of https://github.com/pret/pokefirered into sync-rfu2 2022-11-07 10:41:03 -05:00
GriffinR 9e59afca88 Document DrawHelpMessageWindowTiles 2022-11-02 13:53:27 -04:00
GriffinR 3de70980e5 Document text window 2022-10-05 15:00:58 -04:00
GriffinR aeef671c42 Merge branch 'master' of https://github.com/pret/pokefirered into doc-strings 2022-09-22 13:36:32 -04:00
cbt6 e33ed44b7f Add parentheses and case statements 2022-09-23 00:39:59 +08:00
cbt6 500a488442 Remove goto in ItemUseCB_MedicineStep
Leak-informed
2022-09-17 16:21:42 +08:00
cbt6 61ad87a314 Document party menu 2022-09-17 14:29:32 +08:00
GriffinR 7b2da8e402 Sync/document the rest of strings.c 2022-09-13 14:48:54 -04:00
Eduardo Quezada 81ef26732d Removed UNUSED attribute 2022-09-04 18:06:58 -03:00
GriffinR 7c0b46f6da Merge pull request #541 from GriffinRichards/sync-script
Sync script.c
2022-08-26 23:55:31 -04:00
GriffinR 72f76b19b3 Sync script.c 2022-08-22 20:27:23 -04:00
GriffinR 8a793e73a5 Sync link_rfu_2 2022-08-19 15:27:54 -04:00
GriffinR a064849864 Sync/document battle_message.c 2022-08-12 13:58:24 -04:00
Eduardo Quezada 95dd979f09 Font constants and slight PSS sync 2022-07-31 21:00:27 -04:00
Eduardo Quezada 4a60396428 Colors 2022-07-29 22:49:52 -04:00
Eduardo Quezada dfe6c6885c Synced sound.c 2022-07-29 18:15:25 -04:00
Eduardo Quezada 0709da5867 Multiple changes 2 2022-07-28 01:20:05 -04:00
Eduardo Quezada f5e9cc595b Multiple changes
- BATTLESTRINGS_ID_ADDER ->BATTLESTRINGS_TABLE_START
- Defines for battle windows
- MAIL_NONE
- MON_DATA_FILLER -> MON_DATA_UNUSED_RIBBONS
- Usage of BattlePutTextOnWindow with masks
- PlayCry1 -> PlayCry_Normal
- BlendPalettes(0xFFFFFFFF -> BlendPalettes(PALETTES_ALL
- FillPalette(0 -> FillPalette(RGB_BLACK
2022-07-27 18:14:48 -04:00
Eduardo Quezada 3b98289de2 BeginNormalPaletteFade PALETTES_ALL documentation 2022-07-27 13:16:28 -04:00
GriffinR b2c74cae84 Sync global 2021-11-19 20:36:59 -05:00
GriffinR 1150e16b68 Merge pull request #450 from PikalaxALT/flatten_sprite_pos
Flatten pos fields in struct Sprite
2021-07-25 12:51:51 -04:00
PikalaxALT 864d371c25 Swap two fields in player PC struct 2021-07-17 20:33:31 -04:00
PikalaxALT aec808ac0d Flatten pos fields in struct Sprite 2021-07-07 09:05:48 -04:00
Deokishisu dd3d464b6a Fix Magic Number in party_menu.c
`DisplayPartyPokemonDataForMoveTutorOrEvolutionItem` in `party_menu.c` had a magic number that was missed. This commit fixes it.
2021-07-01 03:11:05 -04:00
PikalaxALT c99894bc60 Document Pokemon Summary Screen, 1 2021-04-04 09:59:40 -04:00
PikalaxALT 014596dea5 Document and refactor AdjustFriendship 2021-03-18 17:50:55 -04:00
PikalaxALT c5aa5d3722 Fix faulty search&replace 2021-03-18 15:00:06 -04:00
PikalaxALT c779411957 Sync EVO_MODE consts from emerald 2021-03-18 13:14:08 -04:00
PikalaxALT 4d86834d12 Document item use functions in pokemon.c 2021-03-16 21:16:31 -04:00
PikalaxALT 81da6acff5 battle_gfx_sfx_util sync emerald names to unnamed syms 2021-03-15 19:32:49 -04:00
PikalaxALT 2f4f63afdb Document old man batttle controller 2021-03-15 14:27:50 -04:00
Deokishisu 57e3f5e0f8 Mirror pokeemerald PR#1329 & PR#1335 to pokefirered
The `giftRibbons` field in `SaveBlock1` has been split out into proper subfields. The new ExternalEvent structs deal with interconnectivity between external games/peripherals and FRLG. US & JP Colosseum Bonus Discs', Colosseum and XD's, Pokémon Channel's, and PokémonBox: Ruby & Sapphire's interactions with these fields has been documented.

The `giftRibbon#` fields in `PokemonSubstruct3` have also been renamed to their appropriate ribbons, and commented with distribution info if applicable. The previous `fatefulEncounter` field was actually filler, and relabeled as such, while the `obedient` bit was renamed `eventLegal`. All relevant constants and functions dealing with the Pokémon data structure were renamed with these changes in mind.

I still maintain that `eventLegal` is a misnomer and it should be called `fatefulEncounter` in all three repos.
2021-02-16 16:56:31 -05:00
GriffinR 1f6dc0e86b Use trainer constants in flags, automatically update flags/vars count 2021-01-29 15:50:01 -05:00
GriffinR bb56d4a3f4 Give songs meaningful english names 2020-08-29 03:11:03 -04:00
PikalaxALT aea30489fc Create COPYWIN defines for CopyWindowToVram calls 2020-04-10 16:17:46 -04:00
PikalaxALT 0394317ae4 Merge branch 'various_documentation' of github.com:PikalaxALT/pokefirered into various_documentation 2020-04-06 18:00:47 -04:00
PikalaxALT c78101535b Split quest_log.c 2020-04-06 17:58:24 -04:00
GriffinR 250f955ae6 Start documenting region map 2020-04-01 17:32:22 -04:00
PikalaxALT 77a6b8a820 Address review comments; doc round 2 2020-03-22 14:26:44 -04:00
PikalaxALT faab53204c Start doccing PSA 2020-03-21 20:52:44 -04:00
GriffinR 4df660dc76 Add enums for help system text, label help context 2020-03-04 18:26:54 -05:00
PikalaxALT 9c03c850a2 Fly field effect 2020-02-27 16:35:06 -05:00
PikalaxALT c93915120f Port many field_effect.c names from Emerald 2020-02-27 11:45:08 -05:00
PikalaxALT b7c28c4be7 Remove redundant include lines 2020-02-21 15:00:56 -05:00
PikalaxALT 7bd0a83d35 I'm so original with these commit names 2020-02-03 16:41:25 -05:00