Commit Graph

7930 Commits

Author SHA1 Message Date
Josh 65f9c04757 Key split restructure (#2168)
Key split tables have been given names based on usage (KeySplitTable1 -> keysplit_piano etc) and a new macro has been set up to better represent the individual bytes for key splits with it being more obvious to how said bytes are used for the respective voice in the voicegroup.

---------

Co-authored-by: Martin Griffin <martinrgriffin@gmail.com>
2025-08-02 02:11:50 +01:00
Josh 0dfec24967 Allow names for voicegroups and use a macro for use with drumsets (#2149)
mid2agb has been modified to allow more than just numbers when naming voicegroups and voicegroups have been renamed to match. A "voice_group" macro has been set up with a optional parameter for the starting note will shift the offset by the specified amount * 0xC which is the length of 1 voice in a voicegroup. All drumset voicegroups have a "starting_note" of 36.
2025-07-30 19:43:08 +01:00
GriffinR f85baa5358 Merge pull request #2164 from cawtds/shop-menu-palette
Document shop menu palette
2025-07-26 14:36:03 -04:00
cawtds 5da5cb4c8c document shop menu palette 2025-07-26 20:19:45 +02:00
GriffinR 6f8a1bbdb8 Add pack/unpack for data masks (#2163) 2025-07-23 09:28:34 +01:00
GriffinR 20012cba6e Merge pull request #2130 from Catnip-Consumer/preproc-windows-fixes
Apply fixes to preproc for Windows compatibility
2025-07-21 18:56:37 -04:00
Philipp AUER e63e89e270 Fix potential stack memory leak in gbagfx due to out of bounds read (#2162)
* fix(tools): gbagfx potential oob read

---------

Co-authored-by: sbird <sbird@no.tld>
2025-07-21 18:33:44 +01:00
GriffinR e22b799d7f Merge pull request #2160 from rayrobdod/align_rl
Fix RL compressed data alignment
2025-07-17 13:22:41 -04:00
Raymond Dodge 80b9c23d0a Fix RL compressed data alignment
`RLUnComp`, like `LZ77UnComp`, expects the source data to be word-aligned.
So, to mirror how lz-compressed data is defined as `u32[]` to enforce
word-alignment, this changes rl-compressed data to be defined as `u32[]`
to enforce word-alignment.
2025-07-06 13:49:47 -04:00
GriffinR aac44d0f91 Merge pull request #2073 from AsparagusEduardo/_pret/pr/pyramidLocation
Improve Pyramid location documentaion
2025-06-30 13:30:14 -04:00
GriffinR 6ead1e50df Merge pull request #2159 from GriffinRichards/mapsec-default
Add explicit defaults for MAPSEC data
2025-06-30 13:25:48 -04:00
GriffinR 0c7c81e02f Merge branch 'master' into _pret/pr/pyramidLocation 2025-06-30 11:51:45 -04:00
GriffinR 44c3069895 Add explicit defaults for MAPSEC data 2025-06-26 16:26:59 -04:00
GriffinR 670d3a6c9f Merge pull request #2152 from GriffinRichards/mapsec-data
Relax MAPSEC region map data requirements
2025-06-25 22:05:35 -04:00
GriffinR 2a7a4f1e76 Merge pull request #2127 from AsparagusEduardo/_pret/maxLinkPlayers
Fix other missing instances of MAX_LINK_PLAYERS
2025-06-25 22:05:13 -04:00
DizzyEggg 9df5ab16e8 Ensure sMonMarkings_Gfx alignment (#2158) 2025-06-25 19:41:23 +01:00
DizzyEggg 64a6e8817c Fix sGpuRegBuffer potential alignment issues (#2157) 2025-06-25 17:54:13 +01:00
DizzyEggg e1b83d6056 Match graphics declarations with externs (#2089) 2025-06-23 20:31:18 +01:00
GriffinR 4ce83c7d96 Merge pull request #2104 from GriffinRichards/fix-collision-comparison
Fix collision comparison in PlayerNotOnBikeMoving
2025-06-22 20:05:30 -04:00
GriffinR f029fc5eac Merge pull request #2156 from DizzyEggg/temps
Fix wrong keep temps files directory in makefile
2025-06-22 19:54:58 -04:00
DizzyEggg 53f8ae11ff Move gTradePlatform_Tilemap to header (#2088) 2025-06-22 19:48:37 -04:00
DizzyEggg 01fc7e76ef Fix wrong keep temps files directory in makefile 2025-06-22 11:26:31 +02:00
GriffinR e2e3438674 Add missing uses of LOCALID_NONE for trainerbattle 2025-06-20 15:33:12 -04:00
psf 75fe3e7da6 Fixed typo in sMoveRelearnerMenuState (#2155) 2025-06-17 15:38:33 +01:00
GriffinR bfa3e4a07b Merge pull request #2145 from abaresk/remove-berryfix
Remove berry yield bug fix
2025-06-15 00:41:33 -04:00
GriffinR 5a3fc2a61b Merge pull request #2154 from DizzyEggg/patch-1
Fix AnimItemSteal_Step3 and AnimKnockOffOpponentsItem matches
2025-06-13 11:28:26 -04:00
DizzyEggg 1cc4321a42 Fix AnimItemSteal_Step3 and AnimKnockOffOpponentsItem matches 2025-06-13 16:45:24 +02:00
GriffinR 50d81616cd Relax MAPSEC region map data requirements 2025-06-10 13:05:03 -04:00
GriffinR ec6e85d4b4 Merge pull request #2151 from ghoulslash/pret/repeatparticlefix
Fix Repeat Ball Particle Animation Sprite Count
2025-06-09 16:43:57 -04:00
ghoulslash 96844bd3bb fix sprite count in RepeatBallOpenParticleAnimation 2025-06-09 16:19:25 -04:00
GriffinR 2101c73266 Merge pull request #2150 from cawtds/list-menu-documentation
Document list menu functions
2025-06-02 21:24:06 -04:00
cawtds b36a78ed47 replace magic numbers with enums 2025-06-02 22:55:41 +02:00
cawtds 0fc900514b sync list menu functions with firered 2025-06-02 22:51:26 +02:00
GriffinR 0c32d840fa Merge pull request #2141 from pret/porymap-6
Update for Porymap 6
2025-05-27 10:53:17 -04:00
GriffinR fba096a500 Remove map_group_count.h 2025-05-22 13:59:23 -04:00
GriffinR d6962aacd7 Merge pull request #2146 from AlexOn1ine/removeFiles
Remove files that were wrongly commited
2025-05-22 13:58:18 -04:00
AlexOn1ine e245f1ec22 Remove files that were wrongly commited 2025-05-22 14:33:31 +02:00
Alex b31a73f990 Rename ItemId_GetX to GetItemX (#2116) 2025-05-22 13:27:52 +01:00
Abaresk bef343cefa Remove berry yield bug fix 2025-05-21 16:11:18 -04:00
Kurausukun bd0a02c456 Correct C23 Checks (#2144) 2025-05-19 15:43:06 +01:00
Bassoonian 59d315734d Update header files to match source files (#2143) 2025-05-19 09:18:04 +01:00
Kurausukun e1e7d1cf35 Fixes for C23 Support (#2138)
* fixes for c23 support
* include global.h in m4a.c & remove <string.h> include
2025-05-19 09:11:59 +01:00
Bassoonian 16357c7e29 Streamline pointer notation (#2139) 2025-05-16 12:04:44 +01:00
GriffinR 74bf498aaa Merge pull request #2137 from mrgriffin/pret-suspicious-setvar
Warn on suspicious setvar usages
2025-05-15 17:21:00 -04:00
Martin Griffin 54e9505d2b Warn on suspicious setvar usages 2025-05-15 09:42:59 +01:00
GriffinR 929bc8b990 Merge branch 'master' of https://github.com/pret/pokeemerald into porymap-6 2025-05-14 11:50:11 -04:00
GriffinR 0aae36984f Merge pull request #2136 from mrgriffin/pret-remove-files
Remove files that should not have been committed in #2126
2025-05-13 12:15:58 -04:00
Martin Griffin 484c41c49d Remove files that should not have been committed 2025-05-13 14:56:31 +01:00
Alex 51b000860b Add BattlerId enum and document (#2135) 2025-05-11 07:36:39 +01:00
Alex baf5be2035 Replace: moveId -> move, moveIdx -> moveIndex (#2134) 2025-05-09 16:33:23 +01:00