GriffinR
263026e432
Merge pull request #2128 from DavidJCobb/re-battle-weather-anims
...
Identified task and sprite fields related to battle weather animations
2025-05-02 11:33:04 -04:00
GriffinR
5a036aedcf
Merge pull request #2131 from hedara90/fix-mapson-g++-include
...
Added missing include due to g++ changes
2025-05-02 11:28:12 -04:00
Hedara
c8d3a6b4df
Added missing include due to g++ changes
2025-05-02 16:03:55 +02:00
DavidJCobb
0f17e70371
Shorter names for engine/controller communication enum members
2025-05-02 00:01:15 -04:00
DavidJCobb
d83b0671f7
Battle anims, ice: ARRAY_COUNT works if used with a cast
2025-05-01 23:49:05 -04:00
Catnip-Consumer
2cc013ff3e
Apply fixes to preproc for Windows compatibility
2025-04-28 14:36:19 +03:00
DavidJCobb
35b33a46e9
Identified task and sprite fields related to battle weather animations
...
Named task and sprite fields related to the animations for Hail, Rain Dance, and Sandstorm.
2025-04-28 05:39:52 -04:00
Eduardo Quezada
56bd65eb9d
Fix other missing instances of MAX_LINK_PLAYERS
2025-04-27 22:28:26 -04:00
DavidJCobb
7ee3043c58
Update battle_controllers.h
...
typo
2025-04-26 11:47:48 -04:00
DavidJCobb
2864408060
Tweaks to documentation comments
2025-04-26 11:40:14 -04:00
DavidJCobb
b4ee45f3e8
Renamed BATTLELINKMSGTYPE_ to BATTLELINKCOMMTYPE_
...
I want to avoid the word "message" since PRET has already chosen "battle message" as the term for predefined strings usable in the battle scripts and UI.
I was considering the term "battle link packet" instead, but the library for wireless communications already uses the word "packet" even though GBATEK does not. I'm going with "battle link communication type" instead. For this particular context, I don't think we need a compound noun ("X type"); the singular noun "type" is fine enough.
2025-04-26 11:37:20 -04:00
DavidJCobb
d8721b668e
Fixed find-and-replace mistake
...
Functions were using the wrong constant.
2025-04-26 10:54:22 -04:00
DavidJCobb
8f5c1a452d
Update battle_controllers.h
...
Simplified macros.
2025-04-26 01:33:17 -04:00
DavidJCobb
2738d11b0f
Additional fixes to last few commits
...
ROM now compiles, but it's not comparing as equal...
2025-04-26 01:00:16 -04:00
DavidJCobb
bab9f0cfef
gBattleControllerExecFlags macro in MarkAllBattlersForControllerExec
...
whoops, missed one
2025-04-26 00:46:06 -04:00
DavidJCobb
a4370ffcde
gBattleControllerExecFlags bits now identified via helper macros
...
Created "exposition" macros to describe operations performed on gBattleControllerExecFlags. Updated the battle engine internals to use them, to more clearly document how battle link communications actually work.
2025-04-26 00:45:03 -04:00
DavidJCobb
9dc48899d3
BUFFER_A/B -> BATTLELINKMSGTYPE; link send/recv. task data names
...
Replaced the BUFFER_A and BUFFER_B constants with the BATTLELINKMSGTYPE enum, which also identifies the "controller becoming idle" message type.
Named the task data for the link send task and the link receive task. Added macros to functions related to those tasks, for legibility.
2025-04-26 00:13:42 -04:00
Martin Griffin
66c07f9c33
Merge pull request #2123 from estellarc/birch-dialog-box
...
Missing constant in Birch speech dialogue
2025-04-24 09:04:03 +01:00
Estellar
dd70446db5
Added constant in Birch speech dialogue
2025-04-23 18:46:11 -04:00
GriffinR
f11bddf854
Fixes for Mirage Tower graphics ( #2120 )
...
* Add documentation for CreateCeilingCrumbleSprites
* Combine mirage tower graphics
* Add comment about mirage tower / player palette
2025-04-14 08:12:45 +02:00
GriffinR
709cfa1c9a
Merge pull request #2014 from Bassoonian/battleterrain
...
Rename battle terrain to environment
2025-04-13 19:32:06 -04:00
Martin Griffin
2a0d3fd070
Merge pull request #2118 from cawtds/linkdirection-range-x-access
...
Make linkDirection more robust to member reordering
2025-04-10 06:47:06 +01:00
GriffinR
6d71c656fc
Merge pull request #2119 from pokemonmasteraaron/fix-agbprint
...
Fixed init call when using AGBPrint as log handler
2025-04-09 13:32:25 -04:00
pokemonmasteraaron
d890436b2a
Fixed a compilation error if using AGBPrint as your log handler, misnamed AGBPrintfInit should be AGBPrintInit
2025-04-09 09:06:20 -04:00
cawtds
1672d99060
make linkDirection more robust to member reordering
2025-04-09 13:40:39 +02:00
Eduardo Quezada
a3075325a0
GENDER_COUNT in sPlayer/RivalAvatarGfxIds ( #2117 )
2025-04-05 20:18:07 -04:00
DizzyEggg
4618ba7407
Align gMPlayTrack_BGM
2025-04-01 00:31:38 +02:00
Martin Griffin
990d418060
Merge pull request #2114 from aronson/typo-union-room
...
Fix union room typo
2025-03-28 15:44:25 +00:00
Isaac Aronson
56947be5d6
Fix union room typo
2025-03-28 10:26:01 -05:00
Hedara
521432b269
Renamed a berry tag variable
2025-03-24 13:47:47 +01:00
Martin Griffin
c8696bf279
Merge pull request #2112 from hedara90/fix-incorrect-pal-include
...
Changed unused compressed pal include from u16 to u32
2025-03-24 10:50:24 +00:00
Hedara
4a1d273b08
Changed unused compressed pal include from u16 to u32
2025-03-24 11:41:49 +01:00
Raymond Dodge
7b6b9ab655
Remove casts in decoration.c ( #2110 )
2025-03-18 18:41:51 -04:00
GriffinR
04eb22f4ea
Fix offset for towerInterview in BattleFrontier
2025-03-15 17:45:42 -04:00
GriffinR
b464fdbbde
Fix collision comparison in PlayerNotOnBikeMoving
2025-02-13 15:37:18 -05:00
GriffinR
f827022704
Merge pull request #2103 from fdeblasio/apprenticeIdHexToDec
...
Converted apprenctice IDs from hex to decimal
2025-02-13 12:39:51 -05:00
Frank
a0a8434e26
Converted apprenctice IDs from hex to decimal
2025-02-13 12:13:22 -05:00
GriffinR
45d1c7ca7d
Merge pull request #2086 from DizzyEggg/patch-5
...
extern void * const gNullScriptPtr;
2025-02-11 14:45:19 -05:00
GriffinR
07c897ad48
Merge pull request #2101 from GriffinRichards/heal-locations-file
...
Generate heal location constants automatically
2025-02-11 14:44:43 -05:00
GriffinR
eb8eeaec48
Merge pull request #2094 from hedara90/pc-align-fix
...
Fixed potential unaligned issue in PC screen
2025-02-11 14:42:19 -05:00
GriffinR
a4350005e7
Merge pull request #2092 from AsparagusEduardo/patch-2
...
Fixed Gen 1/2's Transform "pink color" reference
2025-02-11 14:40:34 -05:00
GriffinR
cdadd7d2ed
Generate heal location constants automatically, move data back to a single file.
2025-02-03 20:25:11 -05:00
GriffinR
678fdf9979
Merge pull request #2047 from GriffinRichards/generate-map-constants
...
Generate local IDs from map.json files
2025-02-03 16:18:32 -05:00
shachar700
95aa41f0d4
Fixed switchout bug in multibattle where order of mons gets messed up ( #2099 )
2025-01-29 07:43:13 +00:00
Raymond Dodge
a3d0978762
Replace easy_chat alphabetialOrder magic numbers with EC_INDEX values ( #2096 )
2025-01-18 20:58:03 -05:00
DizzyEggg
e83f7c79eb
Fix conflicting types for rotating gate functions ( #2087 )
2025-01-17 18:19:21 -05:00
DizzyEggg
0a436d580e
Extern gSprites and gOamMatrices with known array size ( #2090 )
2025-01-17 18:18:17 -05:00
GriffinR
2f67b17571
Document bard music ( #2053 )
...
* Missing bard song limit constants
* Index bard sound arrays with word constants
* Document bard music
2025-01-17 17:54:38 +00:00
Raymond Dodge
b5b0ffd511
Define field script opcode constants ( #2005 )
...
Replace the magic number opcodes in field script command macros with
these new constants
2025-01-17 17:04:00 +00:00
Martin Griffin
9952b676db
Merge pull request #2095 from DizzyEggg/transition
...
Fix CaveTransition pals
2025-01-15 09:21:22 +00:00
