Commit Graph

5199 Commits

Author SHA1 Message Date
Kurausukun
e1e7d1cf35 Fixes for C23 Support (#2138)
* fixes for c23 support
* include global.h in m4a.c & remove <string.h> include
2025-05-19 09:11:59 +01:00
Bassoonian
16357c7e29 Streamline pointer notation (#2139) 2025-05-16 12:04:44 +01:00
Martin Griffin
484c41c49d Remove files that should not have been committed 2025-05-13 14:56:31 +01:00
Alex
51b000860b Add BattlerId enum and document (#2135) 2025-05-11 07:36:39 +01:00
Alex
baf5be2035 Replace: moveId -> move, moveIdx -> moveIndex (#2134) 2025-05-09 16:33:23 +01:00
Alex
2044bea883 Rename battlerId to battler for consistency (#2126) 2025-05-09 12:43:23 +01:00
Eduardo Quezada
15e39339b9 InitSpritePosToAnimAttacker documentation 2025-05-06 15:11:38 -04:00
GriffinR
c39ef1a030 Merge pull request #2125 from DavidJCobb/battle-link-re
Battle link reverse-engineering
2025-05-05 18:17:28 -04:00
DavidJCobb
0f17e70371 Shorter names for engine/controller communication enum members 2025-05-02 00:01:15 -04:00
DavidJCobb
d83b0671f7 Battle anims, ice: ARRAY_COUNT works if used with a cast 2025-05-01 23:49:05 -04:00
DavidJCobb
35b33a46e9 Identified task and sprite fields related to battle weather animations
Named task and sprite fields related to the animations for Hail, Rain Dance, and Sandstorm.
2025-04-28 05:39:52 -04:00
DavidJCobb
2864408060 Tweaks to documentation comments 2025-04-26 11:40:14 -04:00
DavidJCobb
b4ee45f3e8 Renamed BATTLELINKMSGTYPE_ to BATTLELINKCOMMTYPE_
I want to avoid the word "message" since PRET has already chosen "battle message" as the term for predefined strings usable in the battle scripts and UI.

I was considering the term "battle link packet" instead, but the library for wireless communications already uses the word "packet" even though GBATEK does not. I'm going with "battle link communication type" instead. For this particular context, I don't think we need a compound noun ("X type"); the singular noun "type" is fine enough.
2025-04-26 11:37:20 -04:00
DavidJCobb
d8721b668e Fixed find-and-replace mistake
Functions were using the wrong constant.
2025-04-26 10:54:22 -04:00
DavidJCobb
2738d11b0f Additional fixes to last few commits
ROM now compiles, but it's not comparing as equal...
2025-04-26 01:00:16 -04:00
DavidJCobb
bab9f0cfef gBattleControllerExecFlags macro in MarkAllBattlersForControllerExec
whoops, missed one
2025-04-26 00:46:06 -04:00
DavidJCobb
a4370ffcde gBattleControllerExecFlags bits now identified via helper macros
Created "exposition" macros to describe operations performed on gBattleControllerExecFlags. Updated the battle engine internals to use them, to more clearly document how battle link communications actually work.
2025-04-26 00:45:03 -04:00
DavidJCobb
9dc48899d3 BUFFER_A/B -> BATTLELINKMSGTYPE; link send/recv. task data names
Replaced the BUFFER_A and BUFFER_B constants with the BATTLELINKMSGTYPE enum, which also identifies the "controller becoming idle" message type.

Named the task data for the link send task and the link receive task. Added macros to functions related to those tasks, for legibility.
2025-04-26 00:13:42 -04:00
Estellar
dd70446db5 Added constant in Birch speech dialogue 2025-04-23 18:46:11 -04:00
GriffinR
f11bddf854 Fixes for Mirage Tower graphics (#2120)
* Add documentation for CreateCeilingCrumbleSprites

* Combine mirage tower graphics

* Add comment about mirage tower / player palette
2025-04-14 08:12:45 +02:00
GriffinR
709cfa1c9a Merge pull request #2014 from Bassoonian/battleterrain
Rename battle terrain to environment
2025-04-13 19:32:06 -04:00
Martin Griffin
2a0d3fd070 Merge pull request #2118 from cawtds/linkdirection-range-x-access
Make linkDirection more robust to member reordering
2025-04-10 06:47:06 +01:00
pokemonmasteraaron
d890436b2a Fixed a compilation error if using AGBPrint as your log handler, misnamed AGBPrintfInit should be AGBPrintInit 2025-04-09 09:06:20 -04:00
cawtds
1672d99060 make linkDirection more robust to member reordering 2025-04-09 13:40:39 +02:00
Eduardo Quezada
a3075325a0 GENDER_COUNT in sPlayer/RivalAvatarGfxIds (#2117) 2025-04-05 20:18:07 -04:00
Isaac Aronson
56947be5d6 Fix union room typo 2025-03-28 10:26:01 -05:00
Hedara
521432b269 Renamed a berry tag variable 2025-03-24 13:47:47 +01:00
Hedara
4a1d273b08 Changed unused compressed pal include from u16 to u32 2025-03-24 11:41:49 +01:00
Raymond Dodge
7b6b9ab655 Remove casts in decoration.c (#2110) 2025-03-18 18:41:51 -04:00
Frank
a0a8434e26 Converted apprenctice IDs from hex to decimal 2025-02-13 12:13:22 -05:00
GriffinR
45d1c7ca7d Merge pull request #2086 from DizzyEggg/patch-5
extern void * const gNullScriptPtr;
2025-02-11 14:45:19 -05:00
GriffinR
eb8eeaec48 Merge pull request #2094 from hedara90/pc-align-fix
Fixed potential unaligned issue in PC screen
2025-02-11 14:42:19 -05:00
GriffinR
a4350005e7 Merge pull request #2092 from AsparagusEduardo/patch-2
Fixed Gen 1/2's Transform "pink color" reference
2025-02-11 14:40:34 -05:00
shachar700
95aa41f0d4 Fixed switchout bug in multibattle where order of mons gets messed up (#2099) 2025-01-29 07:43:13 +00:00
Raymond Dodge
a3d0978762 Replace easy_chat alphabetialOrder magic numbers with EC_INDEX values (#2096) 2025-01-18 20:58:03 -05:00
DizzyEggg
e83f7c79eb Fix conflicting types for rotating gate functions (#2087) 2025-01-17 18:19:21 -05:00
DizzyEggg
0a436d580e Extern gSprites and gOamMatrices with known array size (#2090) 2025-01-17 18:18:17 -05:00
GriffinR
2f67b17571 Document bard music (#2053)
* Missing bard song limit constants
* Index bard sound arrays with word constants
* Document bard music
2025-01-17 17:54:38 +00:00
DizzyEggg
9385dfed67 Fix CaveTransition pals 2025-01-15 10:08:02 +01:00
Hedara
9bf7a772d0 Fixed potential unaligned issue in PC screen 2025-01-14 09:50:08 +01:00
Eduardo Quezada
453bb29b73 Fixed Gen 1/2's Transform "pink color" reference 2025-01-12 07:43:57 -03:00
DizzyEggg
07255a2237 extern void * const gNullScriptPtr; 2025-01-10 11:55:02 +01:00
DizzyEggg
84856817b2 remove undef TASK_NONE from list_menu 2025-01-09 19:33:45 +01:00
DizzyEggg
9ab4f5d26a extern gAncientPowerRockSpriteTemplate fix 2025-01-09 15:50:39 +01:00
DizzyEggg
0ec1189f34 extern const gBasicHitSplatSpriteTemplate 2025-01-07 22:14:54 +01:00
Eduardo Quezada
50d325f081 Slight contest documentation (#2078) 2024-12-27 11:09:33 -05:00
DizzyEggg
861c579c11 remove sBirchSpeechPlatformBlackPal (#2075) 2024-12-13 17:39:51 -05:00
Eduardo Quezada
5483e05db6 Fixed brace style inconsistencies 2024-12-05 12:46:50 -03:00
Eduardo Quezada
e605ffba53 Fix recorded battle link player loops (#2071) 2024-12-04 16:22:16 -05:00
Eduardo Quezada
4beb0efbcc Added extra encoded character support (#2050) 2024-11-24 20:46:01 -05:00