Commit Graph

7902 Commits

Author SHA1 Message Date
DizzyEggg
01fc7e76ef Fix wrong keep temps files directory in makefile 2025-06-22 11:26:31 +02:00
GriffinR
e2e3438674 Add missing uses of LOCALID_NONE for trainerbattle 2025-06-20 15:33:12 -04:00
psf
75fe3e7da6 Fixed typo in sMoveRelearnerMenuState (#2155) 2025-06-17 15:38:33 +01:00
GriffinR
bfa3e4a07b Merge pull request #2145 from abaresk/remove-berryfix
Remove berry yield bug fix
2025-06-15 00:41:33 -04:00
GriffinR
5a3fc2a61b Merge pull request #2154 from DizzyEggg/patch-1
Fix AnimItemSteal_Step3 and AnimKnockOffOpponentsItem matches
2025-06-13 11:28:26 -04:00
DizzyEggg
1cc4321a42 Fix AnimItemSteal_Step3 and AnimKnockOffOpponentsItem matches 2025-06-13 16:45:24 +02:00
GriffinR
ec6e85d4b4 Merge pull request #2151 from ghoulslash/pret/repeatparticlefix
Fix Repeat Ball Particle Animation Sprite Count
2025-06-09 16:43:57 -04:00
ghoulslash
96844bd3bb fix sprite count in RepeatBallOpenParticleAnimation 2025-06-09 16:19:25 -04:00
GriffinR
2101c73266 Merge pull request #2150 from cawtds/list-menu-documentation
Document list menu functions
2025-06-02 21:24:06 -04:00
cawtds
b36a78ed47 replace magic numbers with enums 2025-06-02 22:55:41 +02:00
cawtds
0fc900514b sync list menu functions with firered 2025-06-02 22:51:26 +02:00
GriffinR
0c32d840fa Merge pull request #2141 from pret/porymap-6
Update for Porymap 6
2025-05-27 10:53:17 -04:00
GriffinR
fba096a500 Remove map_group_count.h 2025-05-22 13:59:23 -04:00
GriffinR
d6962aacd7 Merge pull request #2146 from AlexOn1ine/removeFiles
Remove files that were wrongly commited
2025-05-22 13:58:18 -04:00
AlexOn1ine
e245f1ec22 Remove files that were wrongly commited 2025-05-22 14:33:31 +02:00
Alex
b31a73f990 Rename ItemId_GetX to GetItemX (#2116) 2025-05-22 13:27:52 +01:00
Abaresk
bef343cefa Remove berry yield bug fix 2025-05-21 16:11:18 -04:00
Kurausukun
bd0a02c456 Correct C23 Checks (#2144) 2025-05-19 15:43:06 +01:00
Bassoonian
59d315734d Update header files to match source files (#2143) 2025-05-19 09:18:04 +01:00
Kurausukun
e1e7d1cf35 Fixes for C23 Support (#2138)
* fixes for c23 support
* include global.h in m4a.c & remove <string.h> include
2025-05-19 09:11:59 +01:00
Bassoonian
16357c7e29 Streamline pointer notation (#2139) 2025-05-16 12:04:44 +01:00
GriffinR
74bf498aaa Merge pull request #2137 from mrgriffin/pret-suspicious-setvar
Warn on suspicious setvar usages
2025-05-15 17:21:00 -04:00
Martin Griffin
54e9505d2b Warn on suspicious setvar usages 2025-05-15 09:42:59 +01:00
GriffinR
929bc8b990 Merge branch 'master' of https://github.com/pret/pokeemerald into porymap-6 2025-05-14 11:50:11 -04:00
GriffinR
0aae36984f Merge pull request #2136 from mrgriffin/pret-remove-files
Remove files that should not have been committed in #2126
2025-05-13 12:15:58 -04:00
Martin Griffin
484c41c49d Remove files that should not have been committed 2025-05-13 14:56:31 +01:00
Alex
51b000860b Add BattlerId enum and document (#2135) 2025-05-11 07:36:39 +01:00
Alex
baf5be2035 Replace: moveId -> move, moveIdx -> moveIndex (#2134) 2025-05-09 16:33:23 +01:00
Alex
2044bea883 Rename battlerId to battler for consistency (#2126) 2025-05-09 12:43:23 +01:00
Martin Griffin
384b8f127e Merge pull request #2132 from AsparagusEduardo/_pret/pr/respectMonPicOffsets
`InitSpritePosToAnimAttacker` documentation
2025-05-07 07:02:14 +01:00
Eduardo Quezada
15e39339b9 InitSpritePosToAnimAttacker documentation 2025-05-06 15:11:38 -04:00
GriffinR
c39ef1a030 Merge pull request #2125 from DavidJCobb/battle-link-re
Battle link reverse-engineering
2025-05-05 18:17:28 -04:00
GriffinR
263026e432 Merge pull request #2128 from DavidJCobb/re-battle-weather-anims
Identified task and sprite fields related to battle weather animations
2025-05-02 11:33:04 -04:00
GriffinR
5a036aedcf Merge pull request #2131 from hedara90/fix-mapson-g++-include
Added missing include due to g++ changes
2025-05-02 11:28:12 -04:00
Hedara
c8d3a6b4df Added missing include due to g++ changes 2025-05-02 16:03:55 +02:00
DavidJCobb
0f17e70371 Shorter names for engine/controller communication enum members 2025-05-02 00:01:15 -04:00
DavidJCobb
d83b0671f7 Battle anims, ice: ARRAY_COUNT works if used with a cast 2025-05-01 23:49:05 -04:00
DavidJCobb
35b33a46e9 Identified task and sprite fields related to battle weather animations
Named task and sprite fields related to the animations for Hail, Rain Dance, and Sandstorm.
2025-04-28 05:39:52 -04:00
DavidJCobb
7ee3043c58 Update battle_controllers.h
typo
2025-04-26 11:47:48 -04:00
DavidJCobb
2864408060 Tweaks to documentation comments 2025-04-26 11:40:14 -04:00
DavidJCobb
b4ee45f3e8 Renamed BATTLELINKMSGTYPE_ to BATTLELINKCOMMTYPE_
I want to avoid the word "message" since PRET has already chosen "battle message" as the term for predefined strings usable in the battle scripts and UI.

I was considering the term "battle link packet" instead, but the library for wireless communications already uses the word "packet" even though GBATEK does not. I'm going with "battle link communication type" instead. For this particular context, I don't think we need a compound noun ("X type"); the singular noun "type" is fine enough.
2025-04-26 11:37:20 -04:00
DavidJCobb
d8721b668e Fixed find-and-replace mistake
Functions were using the wrong constant.
2025-04-26 10:54:22 -04:00
DavidJCobb
8f5c1a452d Update battle_controllers.h
Simplified macros.
2025-04-26 01:33:17 -04:00
DavidJCobb
2738d11b0f Additional fixes to last few commits
ROM now compiles, but it's not comparing as equal...
2025-04-26 01:00:16 -04:00
DavidJCobb
bab9f0cfef gBattleControllerExecFlags macro in MarkAllBattlersForControllerExec
whoops, missed one
2025-04-26 00:46:06 -04:00
DavidJCobb
a4370ffcde gBattleControllerExecFlags bits now identified via helper macros
Created "exposition" macros to describe operations performed on gBattleControllerExecFlags. Updated the battle engine internals to use them, to more clearly document how battle link communications actually work.
2025-04-26 00:45:03 -04:00
DavidJCobb
9dc48899d3 BUFFER_A/B -> BATTLELINKMSGTYPE; link send/recv. task data names
Replaced the BUFFER_A and BUFFER_B constants with the BATTLELINKMSGTYPE enum, which also identifies the "controller becoming idle" message type.

Named the task data for the link send task and the link receive task. Added macros to functions related to those tasks, for legibility.
2025-04-26 00:13:42 -04:00
Martin Griffin
66c07f9c33 Merge pull request #2123 from estellarc/birch-dialog-box
Missing constant in Birch speech dialogue
2025-04-24 09:04:03 +01:00
Estellar
dd70446db5 Added constant in Birch speech dialogue 2025-04-23 18:46:11 -04:00
GriffinR
f11bddf854 Fixes for Mirage Tower graphics (#2120)
* Add documentation for CreateCeilingCrumbleSprites

* Combine mirage tower graphics

* Add comment about mirage tower / player palette
2025-04-14 08:12:45 +02:00