Commit Graph

3102 Commits

Author SHA1 Message Date
Martin Griffin
d1d5435487 Improve undefined map assembler messages (#2196) 2025-10-29 21:34:03 -04:00
DavidJCobb
7fd0029ed7 Add typedefs for MAPSEC and METLOC values (#2183)
Added typedefs: mapsec_t, metloc_t, and variants for MAPSEC and METLOC values. There are some rough edges that could do with smoothing out, but for now, this gets us close to ideal with a ROM that compares equal.

Per feedback, all typedefs to mention the underlying type within the typedef name. The documentation comments reflect and explain the naming convention.

Updated comments to reflect the fact that we're no longer using SET8 for a Pokemon's met locations, in favor of a new macro (added by this PR) that adjusts to match the width of whatever is being set.
2025-10-19 17:37:13 +01:00
Estellar
0965dffe70 Use TaskFunc wherever posible (#2188) 2025-10-18 17:53:50 +01:00
Estellar
f4f7c38255 Use MainCallback wherever posible (#2184) 2025-10-14 09:41:27 +01:00
Alex
208f97e1e3 Rename passive damage hitmarker (#2174) 2025-08-21 13:43:19 +01:00
Josh
0dfec24967 Allow names for voicegroups and use a macro for use with drumsets (#2149)
mid2agb has been modified to allow more than just numbers when naming voicegroups and voicegroups have been renamed to match. A "voice_group" macro has been set up with a optional parameter for the starting note will shift the offset by the specified amount * 0xC which is the length of 1 voice in a voicegroup. All drumset voicegroups have a "starting_note" of 36.
2025-07-30 19:43:08 +01:00
GriffinR
6f8a1bbdb8 Add pack/unpack for data masks (#2163) 2025-07-23 09:28:34 +01:00
Raymond Dodge
80b9c23d0a Fix RL compressed data alignment
`RLUnComp`, like `LZ77UnComp`, expects the source data to be word-aligned.
So, to mirror how lz-compressed data is defined as `u32[]` to enforce
word-alignment, this changes rl-compressed data to be defined as `u32[]`
to enforce word-alignment.
2025-07-06 13:49:47 -04:00
GriffinR
0c7c81e02f Merge branch 'master' into _pret/pr/pyramidLocation 2025-06-30 11:51:45 -04:00
DizzyEggg
e1b83d6056 Match graphics declarations with externs (#2089) 2025-06-23 20:31:18 +01:00
DizzyEggg
53f8ae11ff Move gTradePlatform_Tilemap to header (#2088) 2025-06-22 19:48:37 -04:00
cawtds
0fc900514b sync list menu functions with firered 2025-06-02 22:51:26 +02:00
GriffinR
0c32d840fa Merge pull request #2141 from pret/porymap-6
Update for Porymap 6
2025-05-27 10:53:17 -04:00
Alex
b31a73f990 Rename ItemId_GetX to GetItemX (#2116) 2025-05-22 13:27:52 +01:00
Kurausukun
bd0a02c456 Correct C23 Checks (#2144) 2025-05-19 15:43:06 +01:00
Bassoonian
59d315734d Update header files to match source files (#2143) 2025-05-19 09:18:04 +01:00
Kurausukun
e1e7d1cf35 Fixes for C23 Support (#2138)
* fixes for c23 support
* include global.h in m4a.c & remove <string.h> include
2025-05-19 09:11:59 +01:00
Bassoonian
16357c7e29 Streamline pointer notation (#2139) 2025-05-16 12:04:44 +01:00
GriffinR
929bc8b990 Merge branch 'master' of https://github.com/pret/pokeemerald into porymap-6 2025-05-14 11:50:11 -04:00
Alex
51b000860b Add BattlerId enum and document (#2135) 2025-05-11 07:36:39 +01:00
Alex
baf5be2035 Replace: moveId -> move, moveIdx -> moveIndex (#2134) 2025-05-09 16:33:23 +01:00
Alex
2044bea883 Rename battlerId to battler for consistency (#2126) 2025-05-09 12:43:23 +01:00
DavidJCobb
0f17e70371 Shorter names for engine/controller communication enum members 2025-05-02 00:01:15 -04:00
DavidJCobb
7ee3043c58 Update battle_controllers.h
typo
2025-04-26 11:47:48 -04:00
DavidJCobb
2864408060 Tweaks to documentation comments 2025-04-26 11:40:14 -04:00
DavidJCobb
b4ee45f3e8 Renamed BATTLELINKMSGTYPE_ to BATTLELINKCOMMTYPE_
I want to avoid the word "message" since PRET has already chosen "battle message" as the term for predefined strings usable in the battle scripts and UI.

I was considering the term "battle link packet" instead, but the library for wireless communications already uses the word "packet" even though GBATEK does not. I'm going with "battle link communication type" instead. For this particular context, I don't think we need a compound noun ("X type"); the singular noun "type" is fine enough.
2025-04-26 11:37:20 -04:00
DavidJCobb
8f5c1a452d Update battle_controllers.h
Simplified macros.
2025-04-26 01:33:17 -04:00
DavidJCobb
2738d11b0f Additional fixes to last few commits
ROM now compiles, but it's not comparing as equal...
2025-04-26 01:00:16 -04:00
DavidJCobb
a4370ffcde gBattleControllerExecFlags bits now identified via helper macros
Created "exposition" macros to describe operations performed on gBattleControllerExecFlags. Updated the battle engine internals to use them, to more clearly document how battle link communications actually work.
2025-04-26 00:45:03 -04:00
DavidJCobb
9dc48899d3 BUFFER_A/B -> BATTLELINKMSGTYPE; link send/recv. task data names
Replaced the BUFFER_A and BUFFER_B constants with the BATTLELINKMSGTYPE enum, which also identifies the "controller becoming idle" message type.

Named the task data for the link send task and the link receive task. Added macros to functions related to those tasks, for legibility.
2025-04-26 00:13:42 -04:00
GriffinR
709cfa1c9a Merge pull request #2014 from Bassoonian/battleterrain
Rename battle terrain to environment
2025-04-13 19:32:06 -04:00
cawtds
1672d99060 make linkDirection more robust to member reordering 2025-04-09 13:40:39 +02:00
Hedara
521432b269 Renamed a berry tag variable 2025-03-24 13:47:47 +01:00
GriffinR
04eb22f4ea Fix offset for towerInterview in BattleFrontier 2025-03-15 17:45:42 -04:00
GriffinR
cdadd7d2ed Generate heal location constants automatically, move data back to a single file. 2025-02-03 20:25:11 -05:00
DizzyEggg
e83f7c79eb Fix conflicting types for rotating gate functions (#2087) 2025-01-17 18:19:21 -05:00
DizzyEggg
0a436d580e Extern gSprites and gOamMatrices with known array size (#2090) 2025-01-17 18:18:17 -05:00
GriffinR
2f67b17571 Document bard music (#2053)
* Missing bard song limit constants
* Index bard sound arrays with word constants
* Document bard music
2025-01-17 17:54:38 +00:00
shachar700
a0e8753083 Update vars.h (cleanup)
Removed an extra are
2025-01-06 22:17:24 +02:00
Eduardo Quezada
50d325f081 Slight contest documentation (#2078) 2024-12-27 11:09:33 -05:00
GriffinR
dbff8c4360 Merge branch 'porymap-6' into generate-map-constants 2024-12-09 20:25:41 -05:00
Eduardo Quezada
29ef1cf9ad Stick to the new name 2024-12-05 21:00:55 -03:00
Eduardo Quezada
720b2daecc Improve Pyramid location documentaion 2024-12-05 18:25:27 -03:00
GriffinR
382ee9e276 Merge branch 'master' of https://github.com/pret/pokeemerald into porymap-6 2024-11-23 16:10:33 -05:00
GriffinR
b89fda79ea Generate MAPSEC constants from JSON 2024-11-06 21:43:13 -05:00
Frank
544b76fbbf Added value for bard sound length 2024-10-21 09:04:42 -04:00
GriffinR
0eb6d1d74c Merge branch 'porymap-6' of https://github.com/pret/pokeemerald into generate-map-constants 2024-10-15 22:04:45 -04:00
GriffinR
da9c0239d9 Merge branch 'master' of https://github.com/pret/pokeemerald into porymap-6 2024-10-15 22:02:40 -04:00
luckytyphlosion
a55c75d350 Get rid of common syms (#2040) 2024-10-14 23:52:11 -04:00
GriffinR
a0be2cbf7b Fix Fallorbor typo 2024-10-12 23:50:12 -04:00