Commit Graph

3068 Commits

Author SHA1 Message Date
Kurausukun e1e7d1cf35 Fixes for C23 Support (#2138)
* fixes for c23 support
* include global.h in m4a.c & remove <string.h> include
2025-05-19 09:11:59 +01:00
Bassoonian 16357c7e29 Streamline pointer notation (#2139) 2025-05-16 12:04:44 +01:00
Alex 51b000860b Add BattlerId enum and document (#2135) 2025-05-11 07:36:39 +01:00
Alex baf5be2035 Replace: moveId -> move, moveIdx -> moveIndex (#2134) 2025-05-09 16:33:23 +01:00
Alex 2044bea883 Rename battlerId to battler for consistency (#2126) 2025-05-09 12:43:23 +01:00
DavidJCobb 0f17e70371 Shorter names for engine/controller communication enum members 2025-05-02 00:01:15 -04:00
DavidJCobb 7ee3043c58 Update battle_controllers.h
typo
2025-04-26 11:47:48 -04:00
DavidJCobb 2864408060 Tweaks to documentation comments 2025-04-26 11:40:14 -04:00
DavidJCobb b4ee45f3e8 Renamed BATTLELINKMSGTYPE_ to BATTLELINKCOMMTYPE_
I want to avoid the word "message" since PRET has already chosen "battle message" as the term for predefined strings usable in the battle scripts and UI.

I was considering the term "battle link packet" instead, but the library for wireless communications already uses the word "packet" even though GBATEK does not. I'm going with "battle link communication type" instead. For this particular context, I don't think we need a compound noun ("X type"); the singular noun "type" is fine enough.
2025-04-26 11:37:20 -04:00
DavidJCobb 8f5c1a452d Update battle_controllers.h
Simplified macros.
2025-04-26 01:33:17 -04:00
DavidJCobb 2738d11b0f Additional fixes to last few commits
ROM now compiles, but it's not comparing as equal...
2025-04-26 01:00:16 -04:00
DavidJCobb a4370ffcde gBattleControllerExecFlags bits now identified via helper macros
Created "exposition" macros to describe operations performed on gBattleControllerExecFlags. Updated the battle engine internals to use them, to more clearly document how battle link communications actually work.
2025-04-26 00:45:03 -04:00
DavidJCobb 9dc48899d3 BUFFER_A/B -> BATTLELINKMSGTYPE; link send/recv. task data names
Replaced the BUFFER_A and BUFFER_B constants with the BATTLELINKMSGTYPE enum, which also identifies the "controller becoming idle" message type.

Named the task data for the link send task and the link receive task. Added macros to functions related to those tasks, for legibility.
2025-04-26 00:13:42 -04:00
GriffinR 709cfa1c9a Merge pull request #2014 from Bassoonian/battleterrain
Rename battle terrain to environment
2025-04-13 19:32:06 -04:00
cawtds 1672d99060 make linkDirection more robust to member reordering 2025-04-09 13:40:39 +02:00
Hedara 521432b269 Renamed a berry tag variable 2025-03-24 13:47:47 +01:00
GriffinR 04eb22f4ea Fix offset for towerInterview in BattleFrontier 2025-03-15 17:45:42 -04:00
DizzyEggg e83f7c79eb Fix conflicting types for rotating gate functions (#2087) 2025-01-17 18:19:21 -05:00
DizzyEggg 0a436d580e Extern gSprites and gOamMatrices with known array size (#2090) 2025-01-17 18:18:17 -05:00
GriffinR 2f67b17571 Document bard music (#2053)
* Missing bard song limit constants
* Index bard sound arrays with word constants
* Document bard music
2025-01-17 17:54:38 +00:00
shachar700 a0e8753083 Update vars.h (cleanup)
Removed an extra are
2025-01-06 22:17:24 +02:00
Eduardo Quezada 50d325f081 Slight contest documentation (#2078) 2024-12-27 11:09:33 -05:00
Frank 544b76fbbf Added value for bard sound length 2024-10-21 09:04:42 -04:00
luckytyphlosion a55c75d350 Get rid of common syms (#2040) 2024-10-14 23:52:11 -04:00
GriffinR a0be2cbf7b Fix Fallorbor typo 2024-10-12 23:50:12 -04:00
Kurausukun 52c2728ff6 remove gflib 2024-09-18 10:37:34 -04:00
DizzyEggg c4b5818d98 remove ScriptContext_Enable from secret_base.h 2024-09-14 19:13:02 +02:00
Icedude907 625a006cab [Build System Rewrite] mapjson now takes output directory parameters. (#1949) 2024-08-29 14:01:01 -04:00
Martin Griffin 56d3faa32f Merge pull request #2025 from Bassoonian/cleandefinespaces
Clean up defines lacking spaces
2024-08-21 19:04:12 +01:00
GriffinR 3f49c5cbaf Fix trainer match call flags 2024-08-15 23:00:20 +02:00
Bassoonian c1ee43254e Clean up defines lacking spaces 2024-08-15 19:34:56 +02:00
GriffinR a3d5f54b75 Fix type for offset in MapConnection 2024-08-13 19:10:24 +02:00
psf 312749dd31 Changed type1 and type2 to be consistent (#2021)
* Changed type1 and type2 in gBattleMons to match gSpeciesInfo
* Changed monType1 and monType2 to monTypes to match gSpeciesInfo
2024-08-07 06:44:03 +01:00
pkmnsnfrn 91b48a10d4 Added constant for NUM_SNOWFLAKE_SPRITES 2024-07-26 21:57:42 -07:00
Bassoonian 367f6dc8fd Address concerns 2024-07-13 18:01:54 +02:00
Bassoonian 003bd54600 Rename battle terrain to environment 2024-07-13 12:02:18 +02:00
sneed b592c6eae5 Add POKE_ICON_BASE_PAL_TAG to a header 2024-05-23 02:45:22 +03:00
GriffinR b08d62b615 Merge pull request #1961 from GriffinRichards/doc-camera-sprite
Document camera sprite functions
2024-03-21 21:23:53 -04:00
DizzyEggg 132ca1be14 Change Safe Div to explicitly check b != 0 2024-02-02 22:57:02 +01:00
GriffinR 8e8d2f5efa Remove non-existent tilesets from label comments and alphabetize 2024-01-18 14:31:04 -05:00
Bassoonian 6365431122 Add PokéNav too 2023-12-12 23:20:22 +01:00
Bassoonian e5ac2fe0b1 Clean up pokemon/ball/dex mentions in comments 2023-12-12 19:02:36 +01:00
GriffinR 2db9ab2a2f Document camera sprite functions 2023-11-22 13:52:56 -05:00
SnorlaxMonster 190e77e9c8 Rename HITMARKER_IGNORE_SAFEGUARD
Rename HITMARKER_IGNORE_SAFEGUARD to HITMARKER_STATUS_ABILITY_EFFECT.
This flag is used exclusively by status-inflicting Abilities,
and has 3 main functions:
- Whether the effect bypasses Shield Dust
- Whether the effect bypasses Safeguard
- Which text string to display when the status condition is inflicted
   (i.e. whether it was inflicted by a move or Ability)

I believe this new name better represents what the flag actually does.
This name was structured to parallel HITMARKER_SYNCHRONISE_EFFECT.
2023-11-18 13:57:50 +11:00
GriffinR 12a64fecb4 Merge pull request #1936 from GriffinRichards/doc-datahpupdate
Document datahpupdate
2023-11-07 12:25:26 -05:00
Bassoonian f472d768dd Rename Undiscovered to No Eggs Discovered 2023-10-28 16:32:55 +02:00
GriffinR 5712777dc2 Correct dynamic type flag name 2023-10-20 12:57:36 -04:00
GriffinR ffdc2456cb Document datahpupdate 2023-10-20 12:50:32 -04:00
Eduardo Quezada 927e4b6071 Renamed time amounts 2023-09-20 19:04:50 -03:00
Eduardo Quezada fb6f45b2c3 Slight RTC documentation + Evolution times constants 2023-09-17 13:45:06 -03:00